* [PATCH 2/4] x86: fix asm memory constraints in local_64.h
@ 2007-12-16 12:03 Harvey Harrison
0 siblings, 0 replies; 2+ messages in thread
From: Harvey Harrison @ 2007-12-16 12:03 UTC (permalink / raw)
To: Ingo Molnar; +Cc: H. Peter Anvin, LKML, Thomas Gleixner
Use the shorter +m form rather than =m and m.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
include/asm-x86/local_64.h | 30 ++++++++++++++----------------
1 files changed, 14 insertions(+), 16 deletions(-)
diff --git a/include/asm-x86/local_64.h b/include/asm-x86/local_64.h
index da61076..7808f53 100644
--- a/include/asm-x86/local_64.h
+++ b/include/asm-x86/local_64.h
@@ -5,32 +5,30 @@ static inline void local_inc(local_t *l)
{
__asm__ __volatile__(
"incq %0"
- :"=m" (l->a.counter)
- :"m" (l->a.counter));
+ :"+m" (l->a.counter));
}
static inline void local_dec(local_t *l)
{
__asm__ __volatile__(
"decq %0"
- :"=m" (l->a.counter)
- :"m" (l->a.counter));
+ :"+m" (l->a.counter));
}
static inline void local_add(long i, local_t *l)
{
__asm__ __volatile__(
"addq %1,%0"
- :"=m" (l->a.counter)
- :"ir" (i), "m" (l->a.counter));
+ :"+m" (l->a.counter)
+ :"ir" (i));
}
static inline void local_sub(long i, local_t *l)
{
__asm__ __volatile__(
"subq %1,%0"
- :"=m" (l->a.counter)
- :"ir" (i), "m" (l->a.counter));
+ :"+m" (l->a.counter)
+ :"ir" (i));
}
/**
@@ -48,8 +46,8 @@ static inline int local_sub_and_test(long i, local_t *l)
__asm__ __volatile__(
"subq %2,%0; sete %1"
- :"=m" (l->a.counter), "=qm" (c)
- :"ir" (i), "m" (l->a.counter) : "memory");
+ :"+m" (l->a.counter), "=qm" (c)
+ :"ir" (i) : "memory");
return c;
}
@@ -67,8 +65,8 @@ static inline int local_dec_and_test(local_t *l)
__asm__ __volatile__(
"decq %0; sete %1"
- :"=m" (l->a.counter), "=qm" (c)
- :"m" (l->a.counter) : "memory");
+ :"+m" (l->a.counter), "=qm" (c)
+ : : "memory");
return c != 0;
}
@@ -86,8 +84,8 @@ static inline int local_inc_and_test(local_t *l)
__asm__ __volatile__(
"incq %0; sete %1"
- :"=m" (l->a.counter), "=qm" (c)
- :"m" (l->a.counter) : "memory");
+ :"+m" (l->a.counter), "=qm" (c)
+ : : "memory");
return c != 0;
}
@@ -106,8 +104,8 @@ static inline int local_add_negative(long i, local_t *l)
__asm__ __volatile__(
"addq %2,%0; sets %1"
- :"=m" (l->a.counter), "=qm" (c)
- :"ir" (i), "m" (l->a.counter) : "memory");
+ :"+m" (l->a.counter), "=qm" (c)
+ :"ir" (i) : "memory");
return c;
}
--
1.5.4.rc0.1083.gf568
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/4] x86: fix asm memory constraints in local_64.h
@ 2007-12-17 0:54 Harvey Harrison
0 siblings, 0 replies; 2+ messages in thread
From: Harvey Harrison @ 2007-12-17 0:54 UTC (permalink / raw)
To: Ingo Molnar; +Cc: H. Peter Anvin, LKML, Thomas Gleixner
Use the shorter +m form rather than =m and m.
Signed-off-by: Harvey Harrison <harvey.harrison@gmail.com>
---
include/asm-x86/local_64.h | 30 ++++++++++++++----------------
1 files changed, 14 insertions(+), 16 deletions(-)
diff --git a/include/asm-x86/local_64.h b/include/asm-x86/local_64.h
index da61076..7808f53 100644
--- a/include/asm-x86/local_64.h
+++ b/include/asm-x86/local_64.h
@@ -5,32 +5,30 @@ static inline void local_inc(local_t *l)
{
__asm__ __volatile__(
"incq %0"
- :"=m" (l->a.counter)
- :"m" (l->a.counter));
+ :"+m" (l->a.counter));
}
static inline void local_dec(local_t *l)
{
__asm__ __volatile__(
"decq %0"
- :"=m" (l->a.counter)
- :"m" (l->a.counter));
+ :"+m" (l->a.counter));
}
static inline void local_add(long i, local_t *l)
{
__asm__ __volatile__(
"addq %1,%0"
- :"=m" (l->a.counter)
- :"ir" (i), "m" (l->a.counter));
+ :"+m" (l->a.counter)
+ :"ir" (i));
}
static inline void local_sub(long i, local_t *l)
{
__asm__ __volatile__(
"subq %1,%0"
- :"=m" (l->a.counter)
- :"ir" (i), "m" (l->a.counter));
+ :"+m" (l->a.counter)
+ :"ir" (i));
}
/**
@@ -48,8 +46,8 @@ static inline int local_sub_and_test(long i, local_t *l)
__asm__ __volatile__(
"subq %2,%0; sete %1"
- :"=m" (l->a.counter), "=qm" (c)
- :"ir" (i), "m" (l->a.counter) : "memory");
+ :"+m" (l->a.counter), "=qm" (c)
+ :"ir" (i) : "memory");
return c;
}
@@ -67,8 +65,8 @@ static inline int local_dec_and_test(local_t *l)
__asm__ __volatile__(
"decq %0; sete %1"
- :"=m" (l->a.counter), "=qm" (c)
- :"m" (l->a.counter) : "memory");
+ :"+m" (l->a.counter), "=qm" (c)
+ : : "memory");
return c != 0;
}
@@ -86,8 +84,8 @@ static inline int local_inc_and_test(local_t *l)
__asm__ __volatile__(
"incq %0; sete %1"
- :"=m" (l->a.counter), "=qm" (c)
- :"m" (l->a.counter) : "memory");
+ :"+m" (l->a.counter), "=qm" (c)
+ : : "memory");
return c != 0;
}
@@ -106,8 +104,8 @@ static inline int local_add_negative(long i, local_t *l)
__asm__ __volatile__(
"addq %2,%0; sets %1"
- :"=m" (l->a.counter), "=qm" (c)
- :"ir" (i), "m" (l->a.counter) : "memory");
+ :"+m" (l->a.counter), "=qm" (c)
+ :"ir" (i) : "memory");
return c;
}
--
1.5.4.rc0.1083.gf568
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-12-17 0:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-12-17 0:54 [PATCH 2/4] x86: fix asm memory constraints in local_64.h Harvey Harrison
-- strict thread matches above, loose matches on Subject: below --
2007-12-16 12:03 Harvey Harrison
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox