From: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
To: Daniel Walker <dwalker@fifo99.com>
Cc: Andy Isaacson <adi@hexapodia.org>,
jmorris@namei.org, len.brown@intel.com,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andy Isaacson <adi@vmware.com>,
linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net,
dds@google.com, Mimi Zohar <zohar@linux.vnet.ibm.com>,
Shahbaz Khan <shaz.linux@gmail.com>,
seiji.munetoh@gmail.com
Subject: Re: [PATCH] tpm_tis: TPM_STS_DATA_EXPECT workaround
Date: Thu, 10 Sep 2009 17:06:14 -0300 [thread overview]
Message-ID: <1252613174.4837.117.camel@blackbox> (raw)
In-Reply-To: <1252612709.30578.219.camel@desktop>
On Thu, 2009-09-10 at 12:58 -0700, Daniel Walker wrote:
> On Thu, 2009-09-10 at 16:54 -0300, Rajiv Andrade wrote:
>
> > Signed-off-by: Rajiv Andrade <srajiv@linux.vnet.ibm.com>
> > ---
> > diff --git a/drivers/char/tpm/tpm_tis.c b/drivers/char/tpm/tpm_tis.c
> > index aec1931..c9990db 100644
> > --- a/drivers/char/tpm/tpm_tis.c
> > +++ b/drivers/char/tpm/tpm_tis.c
> > @@ -257,6 +257,10 @@ out:
> > return size;
> > }
> >
> > +static int itpm = 0;
>
> This patch has some checkpatch issues .. Could you run it
> through ./script/checkpatch.pl and fix the issues that get reported?
>
Thanks for reminding me Daniel, it indeed complained about the itpm
initialization to 0 and about a whitespace. Will post the fixed patch in
reply to this note (avoid the quotes)
Rajiv
next prev parent reply other threads:[~2009-09-10 20:06 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-01 1:04 [PATCH 0/6] tpm_tis: various cleanups, and support for Intel iTPM Andy Isaacson
2009-07-01 1:04 ` [PATCH 1/6] tpm_tis: various cleanups Andy Isaacson
2009-09-10 19:56 ` Rajiv Andrade
2009-07-01 1:04 ` [PATCH 2/6] tpm_tis: add MODULE_DEVICE_TABLE to enable autoload Andy Isaacson
2009-09-10 19:56 ` Rajiv Andrade
2009-07-01 1:04 ` [PATCH 3/6] tpm_tis: set timeouts before calling request_locality Andy Isaacson
2009-07-01 1:04 ` [PATCH 4/6] tpm_tis: print complete vendor information Andy Isaacson
2009-09-10 19:57 ` Rajiv Andrade
2009-07-01 1:04 ` [PATCH 5/6] tpm_tis: convert from pnp_driver to acpi_driver Andy Isaacson
2009-07-01 10:01 ` Alan Cox
2009-07-01 13:45 ` Rajiv Andrade
2009-07-16 17:26 ` Rajiv Andrade
2009-07-16 17:43 ` [PATCH] TPM: DATA_EXPECT bit check bypass Rajiv Andrade
2009-07-16 20:08 ` Valdis.Kletnieks
2009-07-16 20:50 ` Rajiv Andrade
2009-07-16 21:20 ` Rajiv Andrade
2009-07-20 23:28 ` Andy Isaacson
2009-07-24 17:12 ` Rajiv Andrade
2009-07-20 18:27 ` [PATCH 5/6] tpm_tis: convert from pnp_driver to acpi_driver Andy Isaacson
2009-09-10 19:08 ` Rajiv Andrade
2009-09-10 19:54 ` [PATCH] tpm_tis: TPM_STS_DATA_EXPECT workaround Rajiv Andrade
2009-09-10 19:58 ` Daniel Walker
2009-09-10 20:06 ` Rajiv Andrade [this message]
2009-09-10 20:09 ` Rajiv Andrade
2009-09-11 23:34 ` Seiji Munetoh
2009-09-24 18:43 ` Rajiv Andrade
2009-10-28 2:45 ` David Smith
2009-10-31 14:24 ` Eric Paris
2009-11-01 22:09 ` James Morris
2009-09-10 20:27 ` Andy Isaacson
2009-07-01 1:04 ` [PATCH 6/6] tpm_tis: add workarounds for iTPM Andy Isaacson
2009-07-03 18:18 ` [tpmdd-devel] " Marcin Obara
2009-07-03 19:33 ` Andy Isaacson
2009-07-03 20:10 ` Marcin Obara
2009-07-03 20:20 ` Andy Isaacson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252613174.4837.117.camel@blackbox \
--to=srajiv@linux.vnet.ibm.com \
--cc=adi@hexapodia.org \
--cc=adi@vmware.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dds@google.com \
--cc=dwalker@fifo99.com \
--cc=jmorris@namei.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=seiji.munetoh@gmail.com \
--cc=shaz.linux@gmail.com \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox