* [PATCH 1/4] mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback handler
@ 2010-08-09 6:48 Axel Lin
2010-08-09 9:15 ` Samuel Ortiz
0 siblings, 1 reply; 5+ messages in thread
From: Axel Lin @ 2010-08-09 6:48 UTC (permalink / raw)
To: linux-kernel; +Cc: Samuel Ortiz, Kyungmin Park, Marek Szyprowski, Mark Brown
The i2c_client received in probe() should not be kfree()'d.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mfd/max8998.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
index 0d68de2..73e6f5c 100644
--- a/drivers/mfd/max8998.c
+++ b/drivers/mfd/max8998.c
@@ -89,10 +89,8 @@ static int max8998_i2c_probe(struct i2c_client *i2c,
int ret = 0;
max8998 = kzalloc(sizeof(struct max8998_dev), GFP_KERNEL);
- if (max8998 == NULL) {
- kfree(i2c);
+ if (max8998 == NULL)
return -ENOMEM;
- }
i2c_set_clientdata(i2c, max8998);
max8998->dev = &i2c->dev;
--
1.5.4.3
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH 1/4] mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback handler
2010-08-09 6:48 [PATCH 1/4] mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback handler Axel Lin
@ 2010-08-09 9:15 ` Samuel Ortiz
2010-08-09 9:36 ` Liam Girdwood
0 siblings, 1 reply; 5+ messages in thread
From: Samuel Ortiz @ 2010-08-09 9:15 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Kyungmin Park, Marek Szyprowski, Mark Brown,
Liam Girdwood
Hi Axel,
On Mon, Aug 09, 2010 at 02:48:16PM +0800, Axel Lin wrote:
> The i2c_client received in probe() should not be kfree()'d.
This should go through Liam's tree, I'm CC'ing him to this thread.
Cheers,
Samuel.
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/mfd/max8998.c | 4 +---
> 1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
> index 0d68de2..73e6f5c 100644
> --- a/drivers/mfd/max8998.c
> +++ b/drivers/mfd/max8998.c
> @@ -89,10 +89,8 @@ static int max8998_i2c_probe(struct i2c_client *i2c,
> int ret = 0;
>
> max8998 = kzalloc(sizeof(struct max8998_dev), GFP_KERNEL);
> - if (max8998 == NULL) {
> - kfree(i2c);
> + if (max8998 == NULL)
> return -ENOMEM;
> - }
>
> i2c_set_clientdata(i2c, max8998);
> max8998->dev = &i2c->dev;
> --
> 1.5.4.3
>
>
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/4] mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback handler
2010-08-09 9:15 ` Samuel Ortiz
@ 2010-08-09 9:36 ` Liam Girdwood
2010-08-09 9:44 ` Samuel Ortiz
0 siblings, 1 reply; 5+ messages in thread
From: Liam Girdwood @ 2010-08-09 9:36 UTC (permalink / raw)
To: Samuel Ortiz
Cc: Axel Lin, linux-kernel, Kyungmin Park, Marek Szyprowski,
Mark Brown
On Mon, 2010-08-09 at 11:15 +0200, Samuel Ortiz wrote:
> Hi Axel,
>
> On Mon, Aug 09, 2010 at 02:48:16PM +0800, Axel Lin wrote:
> > The i2c_client received in probe() should not be kfree()'d.
> This should go through Liam's tree, I'm CC'ing him to this thread.
Thanks, I assume I have you Ack too ?
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/4] mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback handler
2010-08-09 9:36 ` Liam Girdwood
@ 2010-08-09 9:44 ` Samuel Ortiz
2010-08-09 10:05 ` Liam Girdwood
0 siblings, 1 reply; 5+ messages in thread
From: Samuel Ortiz @ 2010-08-09 9:44 UTC (permalink / raw)
To: Liam Girdwood
Cc: Axel Lin, linux-kernel, Kyungmin Park, Marek Szyprowski,
Mark Brown
On Mon, Aug 09, 2010 at 10:36:12AM +0100, Liam Girdwood wrote:
> On Mon, 2010-08-09 at 11:15 +0200, Samuel Ortiz wrote:
> > Hi Axel,
> >
> > On Mon, Aug 09, 2010 at 02:48:16PM +0800, Axel Lin wrote:
> > > The i2c_client received in probe() should not be kfree()'d.
> > This should go through Liam's tree, I'm CC'ing him to this thread.
>
> Thanks, I assume I have you Ack too ?
Yup, sorry about that:
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Cheers,
Samuel.
> Thanks
>
> Liam
> --
> Freelance Developer, SlimLogic Ltd
> ASoC and Voltage Regulator Maintainer.
> http://www.slimlogic.co.uk
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/4] mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback handler
2010-08-09 9:44 ` Samuel Ortiz
@ 2010-08-09 10:05 ` Liam Girdwood
0 siblings, 0 replies; 5+ messages in thread
From: Liam Girdwood @ 2010-08-09 10:05 UTC (permalink / raw)
To: Samuel Ortiz
Cc: Axel Lin, linux-kernel, Kyungmin Park, Marek Szyprowski,
Mark Brown
On Mon, 2010-08-09 at 11:44 +0200, Samuel Ortiz wrote:
> On Mon, Aug 09, 2010 at 10:36:12AM +0100, Liam Girdwood wrote:
> > On Mon, 2010-08-09 at 11:15 +0200, Samuel Ortiz wrote:
> > > Hi Axel,
> > >
> > > On Mon, Aug 09, 2010 at 02:48:16PM +0800, Axel Lin wrote:
> > > > The i2c_client received in probe() should not be kfree()'d.
> > > This should go through Liam's tree, I'm CC'ing him to this thread.
> >
> > Thanks, I assume I have you Ack too ?
> Yup, sorry about that:
> Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
>
Applied.
Thanks
Liam
--
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2010-08-09 10:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-09 6:48 [PATCH 1/4] mfd: max8998 - fix incorrect kfree(i2c) in i2c_driver probe callback handler Axel Lin
2010-08-09 9:15 ` Samuel Ortiz
2010-08-09 9:36 ` Liam Girdwood
2010-08-09 9:44 ` Samuel Ortiz
2010-08-09 10:05 ` Liam Girdwood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox