public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* linux-next: build failure after merge of the final tree (security-testing tree related)
@ 2010-10-20  5:10 Stephen Rothwell
  2010-10-20 11:46 ` Eric Paris
  2010-10-20 22:28 ` James Morris
  0 siblings, 2 replies; 6+ messages in thread
From: Stephen Rothwell @ 2010-10-20  5:10 UTC (permalink / raw)
  To: James Morris; +Cc: linux-next, linux-kernel, Eric Paris

Hi James,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

security/selinux/ss/services.c: In function 'security_read_policy':
security/selinux/ss/services.c:3172: error: implicit declaration of function 'vmalloc_user'
security/selinux/ss/services.c:3172: warning: assignment makes pointer from integer without a cast

Caused by commit ed167abda544bb7f8cf09dc3d3608c79e1cfb25f ("SELinux:
allow userspace to read policy back out of the kernel") and
bb17427490e1e295f3c0550c308684bd952a585d ("selinux: implement mmap
on /selinux/policy").

Please see Rule 1 (in Documentation/SubmitChecklist).

I applied the following patch for today:

From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 20 Oct 2010 16:08:00 +1100
Subject: [PATCH] selinux: include vmalloc.h for vmalloc_user

---
 security/selinux/ss/services.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
index 3a1739b..223c1ff 100644
--- a/security/selinux/ss/services.c
+++ b/security/selinux/ss/services.c
@@ -51,6 +51,7 @@
 #include <linux/mutex.h>
 #include <linux/selinux.h>
 #include <linux/flex_array.h>
+#include <linux/vmalloc.h>
 #include <net/netlabel.h>
 
 #include "flask.h"
-- 
1.7.1

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: linux-next: build failure after merge of the final tree (security-testing tree related)
  2010-10-20  5:10 linux-next: build failure after merge of the final tree (security-testing tree related) Stephen Rothwell
@ 2010-10-20 11:46 ` Eric Paris
  2010-10-20 22:28 ` James Morris
  1 sibling, 0 replies; 6+ messages in thread
From: Eric Paris @ 2010-10-20 11:46 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: James Morris, linux-next, linux-kernel

On Wed, 2010-10-20 at 16:10 +1100, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> security/selinux/ss/services.c: In function 'security_read_policy':
> security/selinux/ss/services.c:3172: error: implicit declaration of function 'vmalloc_user'
> security/selinux/ss/services.c:3172: warning: assignment makes pointer from integer without a cast
> 
> Caused by commit ed167abda544bb7f8cf09dc3d3608c79e1cfb25f ("SELinux:
> allow userspace to read policy back out of the kernel") and
> bb17427490e1e295f3c0550c308684bd952a585d ("selinux: implement mmap
> on /selinux/policy").
> 
> Please see Rule 1 (in Documentation/SubmitChecklist).
> 
> I applied the following patch for today:
> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 20 Oct 2010 16:08:00 +1100
> Subject: [PATCH] selinux: include vmalloc.h for vmalloc_user

Huh, not sure why it builds cleanly here.  I'm applying my patch series
on top of linux-next from the 18th.  In any case this looks correct.

Acked-by: Eric Paris <eparis@redhat.com>

> 
> ---
>  security/selinux/ss/services.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
> index 3a1739b..223c1ff 100644
> --- a/security/selinux/ss/services.c
> +++ b/security/selinux/ss/services.c
> @@ -51,6 +51,7 @@
>  #include <linux/mutex.h>
>  #include <linux/selinux.h>
>  #include <linux/flex_array.h>
> +#include <linux/vmalloc.h>
>  #include <net/netlabel.h>
>  
>  #include "flask.h"
> -- 
> 1.7.1
> 



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build failure after merge of the final tree (security-testing tree related)
  2010-10-20  5:10 linux-next: build failure after merge of the final tree (security-testing tree related) Stephen Rothwell
  2010-10-20 11:46 ` Eric Paris
@ 2010-10-20 22:28 ` James Morris
  1 sibling, 0 replies; 6+ messages in thread
From: James Morris @ 2010-10-20 22:28 UTC (permalink / raw)
  To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Eric Paris

On Wed, 20 Oct 2010, Stephen Rothwell wrote:

> Hi James,
> 
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> security/selinux/ss/services.c: In function 'security_read_policy':
> security/selinux/ss/services.c:3172: error: implicit declaration of function 'vmalloc_user'
> security/selinux/ss/services.c:3172: warning: assignment makes pointer from integer without a cast
> 
> Caused by commit ed167abda544bb7f8cf09dc3d3608c79e1cfb25f ("SELinux:
> allow userspace to read policy back out of the kernel") and
> bb17427490e1e295f3c0550c308684bd952a585d ("selinux: implement mmap
> on /selinux/policy").
> 
> Please see Rule 1 (in Documentation/SubmitChecklist).
> 
> I applied the following patch for today:

Thanks, applied.

> 
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 20 Oct 2010 16:08:00 +1100
> Subject: [PATCH] selinux: include vmalloc.h for vmalloc_user
> 
> ---
>  security/selinux/ss/services.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/security/selinux/ss/services.c b/security/selinux/ss/services.c
> index 3a1739b..223c1ff 100644
> --- a/security/selinux/ss/services.c
> +++ b/security/selinux/ss/services.c
> @@ -51,6 +51,7 @@
>  #include <linux/mutex.h>
>  #include <linux/selinux.h>
>  #include <linux/flex_array.h>
> +#include <linux/vmalloc.h>
>  #include <net/netlabel.h>
>  
>  #include "flask.h"
> -- 
> 1.7.1
> 
> -- 
> Cheers,
> Stephen Rothwell                    sfr@canb.auug.org.au
> http://www.canb.auug.org.au/~sfr/
> 

-- 
James Morris
<jmorris@namei.org>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* linux-next: build failure after merge of the final tree (security-testing tree related)
@ 2010-11-29  2:25 Stephen Rothwell
  2010-11-29  2:57 ` Stephen Rothwell
  0 siblings, 1 reply; 6+ messages in thread
From: Stephen Rothwell @ 2010-11-29  2:25 UTC (permalink / raw)
  Cc: linux-next, linux-kernel, Mimi Zohar, David Safford

[-- Attachment #1: Type: text/plain, Size: 2199 bytes --]

Hi ,

After merging the final tree, today's linux-next build (powerpc allyesconfig)
failed like this:

security/keys/trusted_defined.c: In function 'init_sdesc':
security/keys/trusted_defined.c:52: error: implicit declaration of function 'ERR_PTR'
security/keys/trusted_defined.c:52: warning: return makes pointer from integer without a cast
security/keys/trusted_defined.c: In function 'TSS_sha1':
security/keys/trusted_defined.c:65: error: implicit declaration of function 'IS_ERR'
security/keys/trusted_defined.c:67: error: implicit declaration of function 'PTR_ERR'
make[3]: *** [security/keys/trusted_defined.o] Error 1
security/keys/encrypted_defined.c: In function 'aes_get_sizes':
security/keys/encrypted_defined.c:73: error: implicit declaration of function 'IS_ERR'
security/keys/encrypted_defined.c:74: error: implicit declaration of function 'PTR_ERR'
security/keys/encrypted_defined.c:74: warning: format '%ld' expects type 'long int', but argument 2 has type 'int'
security/keys/encrypted_defined.c: In function 'init_sdesc':
security/keys/encrypted_defined.c:270: error: implicit declaration of function 'ERR_PTR'
security/keys/encrypted_defined.c:270: warning: return makes pointer from integer without a cast
security/keys/encrypted_defined.c: In function 'init_blkcipher_desc':
security/keys/encrypted_defined.c:351: warning: format '%ld' expects type 'long int', but argument 3 has type 'int'
security/keys/encrypted_defined.c: In function 'encrypted_key_alloc':
security/keys/encrypted_defined.c:536: warning: return makes pointer from integer without a cast
security/keys/encrypted_defined.c:547: warning: return makes pointer from integer without a cast
security/keys/encrypted_defined.c:552: warning: return makes pointer from integer without a cast

Caused by commits d00a1c72f7f4661212299e6cb132dfa58030bcdb ("keys: add new
trusted key-type") and 7e70cb4978507cf31d76b90e4cfb4c28cad87f0c ("keys:
add new key-type encrypted").  Missing include(s).  See Rule 1 in
Documentation/SubmitChecklist.

I have reverted those commits for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: linux-next: build failure after merge of the final tree (security-testing tree related)
  2010-11-29  2:25 Stephen Rothwell
@ 2010-11-29  2:57 ` Stephen Rothwell
  0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2010-11-29  2:57 UTC (permalink / raw)
  To: James Morris; +Cc: linux-next, linux-kernel, Mimi Zohar, David Safford

[-- Attachment #1: Type: text/plain, Size: 2374 bytes --]

[Forgot to send this top James]

On Mon, 29 Nov 2010 13:25:20 +1100 Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> After merging the final tree, today's linux-next build (powerpc allyesconfig)
> failed like this:
> 
> security/keys/trusted_defined.c: In function 'init_sdesc':
> security/keys/trusted_defined.c:52: error: implicit declaration of function 'ERR_PTR'
> security/keys/trusted_defined.c:52: warning: return makes pointer from integer without a cast
> security/keys/trusted_defined.c: In function 'TSS_sha1':
> security/keys/trusted_defined.c:65: error: implicit declaration of function 'IS_ERR'
> security/keys/trusted_defined.c:67: error: implicit declaration of function 'PTR_ERR'
> make[3]: *** [security/keys/trusted_defined.o] Error 1
> security/keys/encrypted_defined.c: In function 'aes_get_sizes':
> security/keys/encrypted_defined.c:73: error: implicit declaration of function 'IS_ERR'
> security/keys/encrypted_defined.c:74: error: implicit declaration of function 'PTR_ERR'
> security/keys/encrypted_defined.c:74: warning: format '%ld' expects type 'long int', but argument 2 has type 'int'
> security/keys/encrypted_defined.c: In function 'init_sdesc':
> security/keys/encrypted_defined.c:270: error: implicit declaration of function 'ERR_PTR'
> security/keys/encrypted_defined.c:270: warning: return makes pointer from integer without a cast
> security/keys/encrypted_defined.c: In function 'init_blkcipher_desc':
> security/keys/encrypted_defined.c:351: warning: format '%ld' expects type 'long int', but argument 3 has type 'int'
> security/keys/encrypted_defined.c: In function 'encrypted_key_alloc':
> security/keys/encrypted_defined.c:536: warning: return makes pointer from integer without a cast
> security/keys/encrypted_defined.c:547: warning: return makes pointer from integer without a cast
> security/keys/encrypted_defined.c:552: warning: return makes pointer from integer without a cast
> 
> Caused by commits d00a1c72f7f4661212299e6cb132dfa58030bcdb ("keys: add new
> trusted key-type") and 7e70cb4978507cf31d76b90e4cfb4c28cad87f0c ("keys:
> add new key-type encrypted").  Missing include(s).  See Rule 1 in
> Documentation/SubmitChecklist.
> 
> I have reverted those commits for today.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* linux-next: build failure after merge of the final tree (security-testing tree related)
@ 2011-07-16 14:05 Stephen Rothwell
  0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2011-07-16 14:05 UTC (permalink / raw)
  To: James Morris; +Cc: linux-next, linux-kernel, Stefan Berger, Rajiv Andrade

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

Hi all,

After merging the final tree, today's linux-next build (powerpc
allyesconfig) failed like this:

drivers/char/tpm/tpm_tis.c: In function 'tpm_tis_resume':
drivers/char/tpm/tpm_tis.c:845:3: error: implicit declaration of function 'tpm_tis_reenable_interrupts'

Caused by commit 45baa1d1fa39 ("tpm_tis: Re-enable interrupts upon (S3)
resume").

I have just left this error for today.
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2011-07-16 14:05 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-20  5:10 linux-next: build failure after merge of the final tree (security-testing tree related) Stephen Rothwell
2010-10-20 11:46 ` Eric Paris
2010-10-20 22:28 ` James Morris
  -- strict thread matches above, loose matches on Subject: below --
2010-11-29  2:25 Stephen Rothwell
2010-11-29  2:57 ` Stephen Rothwell
2011-07-16 14:05 Stephen Rothwell

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox