[PATCH] regulator: Move lp3971 regulator driver to subsys_initcall()

[PATCH] regulator: Move lp3971 regulator driver to subsys_initcall()

[Axel Lin]

Regulators need to be available early in init in order to allow them
to be available for consumers when requested.

Other regulator drivers are already moved to subsys_initcall(),
looks like only lp3971 is missing.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
 drivers/regulator/lp3971.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c
index 0f22ef1..40520d9 100644
--- a/drivers/regulator/lp3971.c
+++ b/drivers/regulator/lp3971.c
@@ -554,7 +554,7 @@ static int __init lp3971_module_init(void)
 
 	return ret;
 }
-module_init(lp3971_module_init);
+subsys_initcall(lp3971_module_init);
 
 static void __exit lp3971_module_exit(void)
 {
-- 
1.7.2

Re: [PATCH] regulator: Move lp3971 regulator driver to subsys_initcall()

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 693 bytes --]

On Wed, Nov 17, 2010 at 11:00:44AM +0800, Axel Lin wrote:
> Regulators need to be available early in init in order to allow them
> to be available for consumers when requested.
> 
> Other regulator drivers are already moved to subsys_initcall(),
> looks like only lp3971 is missing.

My 2 cents: it is safer to create such patches with real HW when there is a
need (we deal with a similar situation in i2c). Janitorial might do more harm
than good. Another option might be to call the patch a RFC?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: [PATCH] regulator: Move lp3971 regulator driver to subsys_initcall()

[Axel Lin]

2010/11/17 Wolfram Sang <w.sang@pengutronix.de>:
> On Wed, Nov 17, 2010 at 11:00:44AM +0800, Axel Lin wrote:
>> Regulators need to be available early in init in order to allow them
>> to be available for consumers when requested.
>>
>> Other regulator drivers are already moved to subsys_initcall(),
>> looks like only lp3971 is missing.
>
> My 2 cents: it is safer to create such patches with real HW when there is a
> need (we deal with a similar situation in i2c). Janitorial might do more harm
> than good. Another option might be to call the patch a RFC?

Thanks for the comments.
I appreciate if someone who has this device can test it.
I only have a similar device ( lp3972 ) and it works with using
subsys_initcall().

Regards,
Axel
>
> Regards,
>
>   Wolfram
>
> --
> Pengutronix e.K.                           | Wolfram Sang                |
> Industrial Linux Solutions                 | http://www.pengutronix.de/  |
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (GNU/Linux)
>
> iEYEARECAAYFAkzjjlUACgkQD27XaX1/VRsF2QCfQn/bCEZSb0qkn1aj9SpqxsST
> zlMAoIyd6I+c4XitD1KRHe53/n3wlXOQ
> =MQc1
> -----END PGP SIGNATURE-----
>
>

Re: [PATCH] regulator: Move lp3971 regulator driver to subsys_initcall()

[Mark Brown]

On Wed, Nov 17, 2010 at 09:12:05AM +0100, Wolfram Sang wrote:
> On Wed, Nov 17, 2010 at 11:00:44AM +0800, Axel Lin wrote:

> > Regulators need to be available early in init in order to allow them
> > to be available for consumers when requested.

> > Other regulator drivers are already moved to subsys_initcall(),
> > looks like only lp3971 is missing.

> My 2 cents: it is safer to create such patches with real HW when there is a
> need (we deal with a similar situation in i2c). Janitorial might do more harm
> than good. Another option might be to call the patch a RFC?

Essentially any regulator driver has this requirement, it's just
something that was missed in the review when the patch was merged.
Grant has an idea for dealing with this differently by postpoing
registraton of dependant devices but for now all regulator drivers
should be registered early.

Re: [PATCH] regulator: Move lp3971 regulator driver to subsys_initcall()

[Mark Brown]

On Wed, Nov 17, 2010 at 11:00:44AM +0800, Axel Lin wrote:
> Regulators need to be available early in init in order to allow them
> to be available for consumers when requested.
> 
> Other regulator drivers are already moved to subsys_initcall(),
> looks like only lp3971 is missing.
> 
> Signed-off-by: Axel Lin <axel.lin@gmail.com>

Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>