* [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator
@ 2011-06-23 2:15 Axel Lin
2011-06-23 2:17 ` [PATCH 2/3] mfd: Fix build error for tps65911-comparator.c Axel Lin
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Axel Lin @ 2011-06-23 2:15 UTC (permalink / raw)
To: linux-kernel
Cc: Jorge Eduardo Candelaria, Samuel Ortiz, Liam Girdwood, Mark Brown
Base on Mark's comment [1], I make the Kconfig entry invisible to users.
[1] https://lkml.org/lkml/2011/5/14/136
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
Hi Jorge,
I don't have this device handy, can you help to test this serial of patches?
Thanks,
Axel
drivers/mfd/Kconfig | 3 +++
drivers/mfd/Makefile | 1 +
2 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
index 519ebab..76a7223 100644
--- a/drivers/mfd/Kconfig
+++ b/drivers/mfd/Kconfig
@@ -751,6 +751,9 @@ config MFD_TPS65910
if you say yes here you get support for the TPS65910 series of
Power Management chips.
+config TPS65911_COMPARATOR
+ tristate
+
endif # MFD_SUPPORT
menu "Multimedia Capabilities Port drivers"
diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile
index 5309ec3..35c5476 100644
--- a/drivers/mfd/Makefile
+++ b/drivers/mfd/Makefile
@@ -99,3 +99,4 @@ obj-$(CONFIG_MFD_OMAP_USB_HOST) += omap-usb-host.o
obj-$(CONFIG_MFD_PM8921_CORE) += pm8921-core.o
obj-$(CONFIG_MFD_PM8XXX_IRQ) += pm8xxx-irq.o
obj-$(CONFIG_MFD_TPS65910) += tps65910.o tps65910-irq.o
+obj-$(CONFIG_TPS65911_COMPARATOR) += tps65911-comparator.o
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/3] mfd: Fix build error for tps65911-comparator.c
2011-06-23 2:15 [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator Axel Lin
@ 2011-06-23 2:17 ` Axel Lin
2011-06-23 2:19 ` [PATCH 3/3] mfd: Remove comp1_threshold and comp2_threshold sysfs entries in tps65911_comparator_remove Axel Lin
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Axel Lin @ 2011-06-23 2:17 UTC (permalink / raw)
To: linux-kernel
Cc: Jorge Eduardo Candelaria, Samuel Ortiz, Liam Girdwood, Mark Brown
Fix below build error:
CC drivers/mfd/tps65911-comparator.o
drivers/mfd/tps65911-comparator.c: In function 'tps65911_comparator_probe':
drivers/mfd/tps65911-comparator.c:131: error: 'struct tps65910_platform_data' has no member named 'vmbch_threshold'
drivers/mfd/tps65911-comparator.c:137: error: 'struct tps65910_platform_data' has no member named 'vmbch2_threshold'
make[2]: *** [drivers/mfd/tps65911-comparator.o] Error 1
make[1]: *** [drivers/mfd] Error 2
make: *** [drivers] Error 2
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mfd/tps65911-comparator.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/tps65911-comparator.c b/drivers/mfd/tps65911-comparator.c
index 3d2dc56..283ac67 100644
--- a/drivers/mfd/tps65911-comparator.c
+++ b/drivers/mfd/tps65911-comparator.c
@@ -125,7 +125,7 @@ static DEVICE_ATTR(comp2_threshold, S_IRUGO, comp_threshold_show, NULL);
static __devinit int tps65911_comparator_probe(struct platform_device *pdev)
{
struct tps65910 *tps65910 = dev_get_drvdata(pdev->dev.parent);
- struct tps65910_platform_data *pdata = dev_get_platdata(tps65910->dev);
+ struct tps65910_board *pdata = dev_get_platdata(tps65910->dev);
int ret;
ret = comp_threshold_set(tps65910, COMP1, pdata->vmbch_threshold);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 3/3] mfd: Remove comp1_threshold and comp2_threshold sysfs entries in tps65911_comparator_remove
2011-06-23 2:15 [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator Axel Lin
2011-06-23 2:17 ` [PATCH 2/3] mfd: Fix build error for tps65911-comparator.c Axel Lin
@ 2011-06-23 2:19 ` Axel Lin
2011-06-23 14:19 ` [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator Valdis.Kletnieks
2011-07-04 15:14 ` Samuel Ortiz
3 siblings, 0 replies; 6+ messages in thread
From: Axel Lin @ 2011-06-23 2:19 UTC (permalink / raw)
To: linux-kernel
Cc: Jorge Eduardo Candelaria, Samuel Ortiz, Liam Girdwood, Mark Brown
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mfd/tps65911-comparator.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/drivers/mfd/tps65911-comparator.c b/drivers/mfd/tps65911-comparator.c
index 283ac67..e7ff783 100644
--- a/drivers/mfd/tps65911-comparator.c
+++ b/drivers/mfd/tps65911-comparator.c
@@ -157,6 +157,8 @@ static __devexit int tps65911_comparator_remove(struct platform_device *pdev)
struct tps65910 *tps65910;
tps65910 = dev_get_drvdata(pdev->dev.parent);
+ device_remove_file(&pdev->dev, &dev_attr_comp2_threshold);
+ device_remove_file(&pdev->dev, &dev_attr_comp1_threshold);
return 0;
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator
2011-06-23 2:15 [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator Axel Lin
2011-06-23 2:17 ` [PATCH 2/3] mfd: Fix build error for tps65911-comparator.c Axel Lin
2011-06-23 2:19 ` [PATCH 3/3] mfd: Remove comp1_threshold and comp2_threshold sysfs entries in tps65911_comparator_remove Axel Lin
@ 2011-06-23 14:19 ` Valdis.Kletnieks
2011-06-27 3:26 ` Axel Lin
2011-07-04 15:14 ` Samuel Ortiz
3 siblings, 1 reply; 6+ messages in thread
From: Valdis.Kletnieks @ 2011-06-23 14:19 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Jorge Eduardo Candelaria, Samuel Ortiz,
Liam Girdwood, Mark Brown
[-- Attachment #1: Type: text/plain, Size: 350 bytes --]
On Thu, 23 Jun 2011 10:15:51 +0800, Axel Lin said:
> Base on Mark's comment [1], I make the Kconfig entry invisible to users.
> +config TPS65911_COMPARATOR
> + tristate
> +
This can't possibly be right by itself- how would it ever get enabled, without
a SELECT pointing at it or a user selecting it?
Is there a follow-on patch that adds a user?
[-- Attachment #2: Type: application/pgp-signature, Size: 227 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator
2011-06-23 14:19 ` [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator Valdis.Kletnieks
@ 2011-06-27 3:26 ` Axel Lin
0 siblings, 0 replies; 6+ messages in thread
From: Axel Lin @ 2011-06-27 3:26 UTC (permalink / raw)
To: Valdis.Kletnieks
Cc: linux-kernel, Jorge Eduardo Candelaria, Samuel Ortiz,
Liam Girdwood, Mark Brown
2011/6/23 <Valdis.Kletnieks@vt.edu>:
> On Thu, 23 Jun 2011 10:15:51 +0800, Axel Lin said:
>> Base on Mark's comment [1], I make the Kconfig entry invisible to users.
>
>> +config TPS65911_COMPARATOR
>> + tristate
>> +
>
> This can't possibly be right by itself- how would it ever get enabled, without
> a SELECT pointing at it or a user selecting it?
>
> Is there a follow-on patch that adds a user?
>
I was thinking the driver that adds "tps65911-comparator" device should
select CONFIG_TPS65911_COMPARATOR symbol.
Or maybe it is ok just make config TPS65911_COMPARATOR visible to users and
make it depend on MFD_TPS65910.
Comments?
Regards,
Axel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator
2011-06-23 2:15 [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator Axel Lin
` (2 preceding siblings ...)
2011-06-23 14:19 ` [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator Valdis.Kletnieks
@ 2011-07-04 15:14 ` Samuel Ortiz
3 siblings, 0 replies; 6+ messages in thread
From: Samuel Ortiz @ 2011-07-04 15:14 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Jorge Eduardo Candelaria, Liam Girdwood, Mark Brown
Hi Axel,
On Thu, Jun 23, 2011 at 10:15:51AM +0800, Axel Lin wrote:
> Base on Mark's comment [1], I make the Kconfig entry invisible to users.
> [1] https://lkml.org/lkml/2011/5/14/136
Thanks for the patches. All 3 applied, with #1 and #2 queued to my for-linus
branch.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-07-04 15:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-23 2:15 [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator Axel Lin
2011-06-23 2:17 ` [PATCH 2/3] mfd: Fix build error for tps65911-comparator.c Axel Lin
2011-06-23 2:19 ` [PATCH 3/3] mfd: Remove comp1_threshold and comp2_threshold sysfs entries in tps65911_comparator_remove Axel Lin
2011-06-23 14:19 ` [PATCH 1/3] mfd: Add Makefile and Kconfig Entries for tps65911 comparator Valdis.Kletnieks
2011-06-27 3:26 ` Axel Lin
2011-07-04 15:14 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox