* [PATCH 10/10] Staging: comedi: fix brace printk() issue in pcl818.c
[not found] <[PATCH 9/9]Staging: comedi: fix printk issue in pcl818.c>
@ 2011-07-11 7:51 ` Ravishankar
2011-07-11 8:20 ` Tobias Klauser
0 siblings, 1 reply; 3+ messages in thread
From: Ravishankar @ 2011-07-11 7:51 UTC (permalink / raw)
To: gregkh, wfp5p; +Cc: devel, linux-kernel, Ravishankar, Ravishankar
From: Ravishankar <ravi.shankar@greenturtles.in>
This is a patch to the pcl818.c file that fixes up a printk() warning found by the checkpatch.pl tool
Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/pcl818.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
index 2fdb8c9..4069fee 100644
--- a/drivers/staging/comedi/drivers/pcl818.c
+++ b/drivers/staging/comedi/drivers/pcl818.c
@@ -1777,7 +1777,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
irq);
irq = 0; /* Can't use IRQ */
} else {
- printk(", irq=%u", irq);
+ printk(KERN_INFO ", irq=%u", irq);
}
}
}
@@ -1883,7 +1883,7 @@ no_dma:
if (check_single_ended(dev->iobase)) {
s->n_chan = this_board->n_aichan_se;
s->subdev_flags |= SDF_COMMON | SDF_GROUND;
- printk(", %dchans S.E. DAC", s->n_chan);
+ printk(KERN_INFO ", %dchans S.E. DAC", s->n_chan);
} else {
s->n_chan = this_board->n_aichan_diff;
s->subdev_flags |= SDF_DIFF;
--
1.6.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 10/10] Staging: comedi: fix brace printk() issue in pcl818.c
2011-07-11 7:51 ` [PATCH 10/10] Staging: comedi: fix brace printk() issue in pcl818.c Ravishankar
@ 2011-07-11 8:20 ` Tobias Klauser
0 siblings, 0 replies; 3+ messages in thread
From: Tobias Klauser @ 2011-07-11 8:20 UTC (permalink / raw)
To: Ravishankar; +Cc: gregkh, wfp5p, devel, linux-kernel, Ravishankar
On 2011-07-11 at 09:51:52 +0200, Ravishankar <ravishankarkm32@gmail.com> wrote:
> From: Ravishankar <ravi.shankar@greenturtles.in>
>
> This is a patch to the pcl818.c file that fixes up a printk() warning found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
> ---
> drivers/staging/comedi/drivers/pcl818.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
> index 2fdb8c9..4069fee 100644
> --- a/drivers/staging/comedi/drivers/pcl818.c
> +++ b/drivers/staging/comedi/drivers/pcl818.c
> @@ -1777,7 +1777,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
> irq);
> irq = 0; /* Can't use IRQ */
> } else {
> - printk(", irq=%u", irq);
> + printk(KERN_INFO ", irq=%u", irq);
This should be KERN_CONT.
> }
> }
> }
> @@ -1883,7 +1883,7 @@ no_dma:
> if (check_single_ended(dev->iobase)) {
> s->n_chan = this_board->n_aichan_se;
> s->subdev_flags |= SDF_COMMON | SDF_GROUND;
> - printk(", %dchans S.E. DAC", s->n_chan);
> + printk(KERN_INFO ", %dchans S.E. DAC", s->n_chan);
Ditto.
> } else {
> s->n_chan = this_board->n_aichan_diff;
> s->subdev_flags |= SDF_DIFF;
> --
> 1.6.5.2
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 10/10] Staging: comedi: fix brace printk() issue in pcl818.c
[not found] <[PATCH]Staging: comedi:fix printk()issue in pcl818.c>
@ 2011-07-11 8:57 ` Ravishankar
0 siblings, 0 replies; 3+ messages in thread
From: Ravishankar @ 2011-07-11 8:57 UTC (permalink / raw)
To: gregkh, wfp5p; +Cc: devel, linux-kernel, Ravishankar, Ravishankar
From: Ravishankar <ravi.shankar@greenturtles.in>
This is a patch to the pcl818.c file that fixes up a printk() warning found by the checkpatch.pl tool
Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/pcl818.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
index 2fdb8c9..4069fee 100644
--- a/drivers/staging/comedi/drivers/pcl818.c
+++ b/drivers/staging/comedi/drivers/pcl818.c
@@ -1777,7 +1777,7 @@ static int pcl818_attach(struct comedi_device *dev, struct comedi_devconfig *it)
irq);
irq = 0; /* Can't use IRQ */
} else {
- printk(", irq=%u", irq);
+ printk(KERN_CONT ", irq=%u", irq);
}
}
}
@@ -1883,7 +1883,7 @@ no_dma:
if (check_single_ended(dev->iobase)) {
s->n_chan = this_board->n_aichan_se;
s->subdev_flags |= SDF_COMMON | SDF_GROUND;
- printk(", %dchans S.E. DAC", s->n_chan);
+ printk(KERN_CONT ", %dchans S.E. DAC", s->n_chan);
} else {
s->n_chan = this_board->n_aichan_diff;
s->subdev_flags |= SDF_DIFF;
--
1.6.5.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-07-11 8:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <[PATCH 9/9]Staging: comedi: fix printk issue in pcl818.c>
2011-07-11 7:51 ` [PATCH 10/10] Staging: comedi: fix brace printk() issue in pcl818.c Ravishankar
2011-07-11 8:20 ` Tobias Klauser
[not found] <[PATCH]Staging: comedi:fix printk()issue in pcl818.c>
2011-07-11 8:57 ` Ravishankar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox