[PATCH] staging: rts_pstor: dont cast void* from kmalloc()

[PATCH] staging: rts_pstor: dont cast void* from kmalloc()

[Thomas Meyer]

From: Thomas Meyer <thomas@m3y3r.de>

 Casting (void *) value returned by kmalloc is useless
 as mentioned in Documentation/CodingStyle, Chap 14.

 The semantic patch that makes this output is available
 in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.

 More information about semantic patching is available at
 http://coccinelle.lip6.fr/

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff -u -p a/drivers/staging/rts_pstor/rtsx_scsi.c b/drivers/staging/rts_pstor/rtsx_scsi.c
--- a/drivers/staging/rts_pstor/rtsx_scsi.c 2011-05-05 20:48:37.168211054 +0200
+++ b/drivers/staging/rts_pstor/rtsx_scsi.c 2011-08-01 19:57:16.027347746 +0200
@@ -2730,7 +2730,7 @@ static int get_ms_information(struct scs
 		buf_len = data_len = 0x6A;
 	}
 
-	buf = (u8 *)kmalloc(buf_len, GFP_KERNEL);
+	buf = kmalloc(buf_len, GFP_KERNEL);
 	if (!buf) {
 		TRACE_RET(chip, TRANSPORT_ERROR);
 	}

[PATCH] Staging: rts_pstor: dont cast void* from kmalloc()

[Thomas Meyer]

From: Thomas Meyer <thomas@m3y3r.de>

 Casting (void *) value returned by kmalloc is useless
 as mentioned in Documentation/CodingStyle, Chap 14.

 The semantic patch that makes this output is available
 in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.

 More information about semantic patching is available at
 http://coccinelle.lip6.fr/

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff -u -p a/drivers/staging/rts_pstor/spi.c b/drivers/staging/rts_pstor/spi.c
--- a/drivers/staging/rts_pstor/spi.c 2011-05-27 19:17:05.999541117 +0200
+++ b/drivers/staging/rts_pstor/spi.c 2011-08-01 19:57:11.534038755 +0200
@@ -463,7 +463,7 @@ int spi_read_flash_id(struct scsi_cmnd *
 	}
 
 	if (len) {
-		buf = (u8 *)kmalloc(len, GFP_KERNEL);
+		buf = kmalloc(len, GFP_KERNEL);
 		if (!buf)
 			TRACE_RET(chip, STATUS_ERROR);
 

[PATCH] staging: rts_pstor: dont cast void* from kmalloc()

[Thomas Meyer]

From: Thomas Meyer <thomas@m3y3r.de>

 Casting (void *) value returned by kmalloc is useless
 as mentioned in Documentation/CodingStyle, Chap 14.

 The semantic patch that makes this output is available
 in scripts/coccinelle/api/alloc/drop_kmalloc_cast.cocci.

 More information about semantic patching is available at
 http://coccinelle.lip6.fr/

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff -u -p a/drivers/staging/rts_pstor/sd.c b/drivers/staging/rts_pstor/sd.c
--- a/drivers/staging/rts_pstor/sd.c 2011-07-28 15:32:18.233251740 +0200
+++ b/drivers/staging/rts_pstor/sd.c 2011-08-01 19:57:13.347362265 +0200
@@ -4139,7 +4139,7 @@ int sd_execute_read_data(struct scsi_cmn
 		cmd[3] = srb->cmnd[5];
 		cmd[4] = srb->cmnd[6];
 
-		buf = (u8 *)kmalloc(data_len, GFP_KERNEL);
+		buf = kmalloc(data_len, GFP_KERNEL);
 		if (buf == NULL) {
 			TRACE_RET(chip, TRANSPORT_ERROR);
 		}
@@ -4385,7 +4385,7 @@ int sd_execute_write_data(struct scsi_cm
 		u16 i;
 		u8 *buf;
 
-		buf = (u8 *)kmalloc(data_len, GFP_KERNEL);
+		buf = kmalloc(data_len, GFP_KERNEL);
 		if (buf == NULL) {
 			TRACE_RET(chip, TRANSPORT_ERROR);
 		}