From: Akshay Joshi <me@akshayjoshi.com>
To: Pavel Machek <pavel@ucw.cz>, Greg Kroah-Hartman <gregkh@suse.de>,
Pekka Enberg <penberg@kernel.org>,
Akshay Joshi <me@akshayjoshi.com>,
Ilia Mirkin <imirkin@alum.mit.edu>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c.
Date: Mon, 15 Aug 2011 20:24:27 -0400 [thread overview]
Message-ID: <1313454275-5604-1-git-send-email-me@akshayjoshi.com> (raw)
Split the case statement and the code that is executed if the condition
is met so that it passes checkpatch.pl and conforms to the kernel code
style.
Signed-off-by: Akshay Joshi <me@akshayjoshi.com>
---
drivers/staging/winbond/wb35reg.c | 105 ++++++++++++++++++++++++------------
1 files changed, 70 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/winbond/wb35reg.c b/drivers/staging/winbond/wb35reg.c
index da595f1..742636c 100644
--- a/drivers/staging/winbond/wb35reg.c
+++ b/drivers/staging/winbond/wb35reg.c
@@ -76,41 +76,76 @@ void Wb35Reg_Update(struct hw_data *pHwData, u16 RegisterNo, u32 RegisterValue
{
struct wb35_reg *reg = &pHwData->reg;
switch (RegisterNo) {
- case 0x3b0: reg->U1B0 = RegisterValue; break;
- case 0x3bc: reg->U1BC_LEDConfigure = RegisterValue; break;
- case 0x400: reg->D00_DmaControl = RegisterValue; break;
- case 0x800: reg->M00_MacControl = RegisterValue; break;
- case 0x804: reg->M04_MulticastAddress1 = RegisterValue; break;
- case 0x808: reg->M08_MulticastAddress2 = RegisterValue; break;
- case 0x824: reg->M24_MacControl = RegisterValue; break;
- case 0x828: reg->M28_MacControl = RegisterValue; break;
- case 0x82c: reg->M2C_MacControl = RegisterValue; break;
- case 0x838: reg->M38_MacControl = RegisterValue; break;
- case 0x840: reg->M40_MacControl = RegisterValue; break;
- case 0x844: reg->M44_MacControl = RegisterValue; break;
- case 0x848: reg->M48_MacControl = RegisterValue; break;
- case 0x84c: reg->M4C_MacStatus = RegisterValue; break;
- case 0x860: reg->M60_MacControl = RegisterValue; break;
- case 0x868: reg->M68_MacControl = RegisterValue; break;
- case 0x870: reg->M70_MacControl = RegisterValue; break;
- case 0x874: reg->M74_MacControl = RegisterValue; break;
- case 0x878: reg->M78_ERPInformation = RegisterValue; break;
- case 0x87C: reg->M7C_MacControl = RegisterValue; break;
- case 0x880: reg->M80_MacControl = RegisterValue; break;
- case 0x884: reg->M84_MacControl = RegisterValue; break;
- case 0x888: reg->M88_MacControl = RegisterValue; break;
- case 0x898: reg->M98_MacControl = RegisterValue; break;
- case 0x100c: reg->BB0C = RegisterValue; break;
- case 0x102c: reg->BB2C = RegisterValue; break;
- case 0x1030: reg->BB30 = RegisterValue; break;
- case 0x103c: reg->BB3C = RegisterValue; break;
- case 0x1048: reg->BB48 = RegisterValue; break;
- case 0x104c: reg->BB4C = RegisterValue; break;
- case 0x1050: reg->BB50 = RegisterValue; break;
- case 0x1054: reg->BB54 = RegisterValue; break;
- case 0x1058: reg->BB58 = RegisterValue; break;
- case 0x105c: reg->BB5C = RegisterValue; break;
- case 0x1060: reg->BB60 = RegisterValue; break;
+ case 0x3b0:
+ reg->U1B0 = RegisterValue; break;
+ case 0x3bc:
+ reg->U1BC_LEDConfigure = RegisterValue; break;
+ case 0x400:
+ reg->D00_DmaControl = RegisterValue; break;
+ case 0x800:
+ reg->M00_MacControl = RegisterValue; break;
+ case 0x804:
+ reg->M04_MulticastAddress1 = RegisterValue; break;
+ case 0x808:
+ reg->M08_MulticastAddress2 = RegisterValue; break;
+ case 0x824:
+ reg->M24_MacControl = RegisterValue; break;
+ case 0x828:
+ reg->M28_MacControl = RegisterValue; break;
+ case 0x82c:
+ reg->M2C_MacControl = RegisterValue; break;
+ case 0x838:
+ reg->M38_MacControl = RegisterValue; break;
+ case 0x840:
+ reg->M40_MacControl = RegisterValue; break;
+ case 0x844:
+ reg->M44_MacControl = RegisterValue; break;
+ case 0x848:
+ reg->M48_MacControl = RegisterValue; break;
+ case 0x84c:
+ reg->M4C_MacStatus = RegisterValue; break;
+ case 0x860:
+ reg->M60_MacControl = RegisterValue; break;
+ case 0x868:
+ reg->M68_MacControl = RegisterValue; break;
+ case 0x870:
+ reg->M70_MacControl = RegisterValue; break;
+ case 0x874:
+ reg->M74_MacControl = RegisterValue; break;
+ case 0x878:
+ reg->M78_ERPInformation = RegisterValue; break;
+ case 0x87C:
+ reg->M7C_MacControl = RegisterValue; break;
+ case 0x880:
+ reg->M80_MacControl = RegisterValue; break;
+ case 0x884:
+ reg->M84_MacControl = RegisterValue; break;
+ case 0x888:
+ reg->M88_MacControl = RegisterValue; break;
+ case 0x898:
+ reg->M98_MacControl = RegisterValue; break;
+ case 0x100c:
+ reg->BB0C = RegisterValue; break;
+ case 0x102c:
+ reg->BB2C = RegisterValue; break;
+ case 0x1030:
+ reg->BB30 = RegisterValue; break;
+ case 0x103c:
+ reg->BB3C = RegisterValue; break;
+ case 0x1048:
+ reg->BB48 = RegisterValue; break;
+ case 0x104c:
+ reg->BB4C = RegisterValue; break;
+ case 0x1050:
+ reg->BB50 = RegisterValue; break;
+ case 0x1054:
+ reg->BB54 = RegisterValue; break;
+ case 0x1058:
+ reg->BB58 = RegisterValue; break;
+ case 0x105c:
+ reg->BB5C = RegisterValue; break;
+ case 0x1060:
+ reg->BB60 = RegisterValue; break;
}
}
--
1.7.5.4
next reply other threads:[~2011-08-16 0:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 0:24 Akshay Joshi [this message]
2011-08-16 0:24 ` [PATCH 2/9] Staging: Winbond: Fix pointer style in wb35tx.c Akshay Joshi
2011-08-16 5:41 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 3/9] Staging: Winbond: Fix space issues " Akshay Joshi
2011-08-16 5:42 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond Akshay Joshi
2011-08-16 5:42 ` Pekka Enberg
2011-08-16 19:56 ` Gábor Stefanik
2011-08-16 21:24 ` Pekka Enberg
2011-08-16 21:38 ` Gábor Stefanik
2011-08-16 21:40 ` Gábor Stefanik
2011-08-17 5:41 ` Pekka Enberg
2011-08-17 19:15 ` Akshay Joshi
2011-08-17 19:17 ` Akshay Joshi
2011-08-17 21:08 ` Dan Carpenter
2011-08-16 21:43 ` Dan Carpenter
2011-08-17 0:19 ` Akshay Joshi
2011-08-16 0:24 ` [PATCH 5/9] Staging: Winbond: Fix spacing issues for spaces before tabs Akshay Joshi
2011-08-16 5:43 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 6/9] Staging: Winbond: Remove spacing issues related to pointers Akshay Joshi
2011-08-16 5:45 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 7/9] Staging: Winbond: Fix parentheses in returns Akshay Joshi
2011-08-16 5:45 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 8/9] Staging: Winbond: Use tabs instead of spaces for indents Akshay Joshi
2011-08-16 5:46 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 9/9] Staging: Winbond: Reposition a curly bracket Akshay Joshi
2011-08-16 5:46 ` Pekka Enberg
2011-08-16 5:41 ` [PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c Pekka Enberg
2011-08-23 22:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313454275-5604-1-git-send-email-me@akshayjoshi.com \
--to=me@akshayjoshi.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=imirkin@alum.mit.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox