From: Dan Carpenter <error27@gmail.com>
To: Pekka Enberg <penberg@kernel.org>
Cc: "Gábor Stefanik" <netrolller.3d@gmail.com>,
devel@driverdev.osuosl.org, "Greg Kroah-Hartman" <gregkh@suse.de>,
"Akshay Joshi" <me@akshayjoshi.com>,
linux-kernel@vger.kernel.org,
"Karthigan Srinivasan" <karthigan.srinivasan2@gmail.com>,
"Pavel Machek" <pavel@ucw.cz>
Subject: Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.
Date: Wed, 17 Aug 2011 00:43:52 +0300 [thread overview]
Message-ID: <20110816214352.GK26027@shale.localdomain> (raw)
In-Reply-To: <CAOJsxLGqc6khjGQMA=b1BwTv_4pv4ZgkdjJrgtMbRwuNDrN_iA@mail.gmail.com>
On Wed, Aug 17, 2011 at 12:24:06AM +0300, Pekka Enberg wrote:
> 2011/8/16 Gábor Stefanik <netrolller.3d@gmail.com>:
> >> -
> >> -//====================================
> >> -// Internal variable for module
> >> -//====================================
> >> +/*============================================================================
> >> +/* wb35rx.h --
> >> +/*============================================================================
> >
> > I'm pretty sure this is not an accepted kernel comment style.
>
> What's the problem? I think it's OK for this particular patch.
There are a five start open comment "/*" marks in a row that don't
have a matching close comment.
regards,
dan carpenter
next prev parent reply other threads:[~2011-08-16 21:46 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 0:24 [PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c Akshay Joshi
2011-08-16 0:24 ` [PATCH 2/9] Staging: Winbond: Fix pointer style in wb35tx.c Akshay Joshi
2011-08-16 5:41 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 3/9] Staging: Winbond: Fix space issues " Akshay Joshi
2011-08-16 5:42 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond Akshay Joshi
2011-08-16 5:42 ` Pekka Enberg
2011-08-16 19:56 ` Gábor Stefanik
2011-08-16 21:24 ` Pekka Enberg
2011-08-16 21:38 ` Gábor Stefanik
2011-08-16 21:40 ` Gábor Stefanik
2011-08-17 5:41 ` Pekka Enberg
2011-08-17 19:15 ` Akshay Joshi
2011-08-17 19:17 ` Akshay Joshi
2011-08-17 21:08 ` Dan Carpenter
2011-08-16 21:43 ` Dan Carpenter [this message]
2011-08-17 0:19 ` Akshay Joshi
2011-08-16 0:24 ` [PATCH 5/9] Staging: Winbond: Fix spacing issues for spaces before tabs Akshay Joshi
2011-08-16 5:43 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 6/9] Staging: Winbond: Remove spacing issues related to pointers Akshay Joshi
2011-08-16 5:45 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 7/9] Staging: Winbond: Fix parentheses in returns Akshay Joshi
2011-08-16 5:45 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 8/9] Staging: Winbond: Use tabs instead of spaces for indents Akshay Joshi
2011-08-16 5:46 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 9/9] Staging: Winbond: Reposition a curly bracket Akshay Joshi
2011-08-16 5:46 ` Pekka Enberg
2011-08-16 5:41 ` [PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c Pekka Enberg
2011-08-23 22:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110816214352.GK26027@shale.localdomain \
--to=error27@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=karthigan.srinivasan2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@akshayjoshi.com \
--cc=netrolller.3d@gmail.com \
--cc=pavel@ucw.cz \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox