From: Akshay Joshi <me@akshayjoshi.com>
To: Pavel Machek <pavel@ucw.cz>, Greg Kroah-Hartman <gregkh@suse.de>,
Pekka Enberg <penberg@kernel.org>,
Akshay Joshi <me@akshayjoshi.com>,
Karthigan Srinivasan <karthigan.srinivasan2@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH 3/9] Staging: Winbond: Fix space issues in wb35tx.c.
Date: Mon, 15 Aug 2011 20:24:29 -0400 [thread overview]
Message-ID: <1313454275-5604-3-git-send-email-me@akshayjoshi.com> (raw)
In-Reply-To: <1313454275-5604-1-git-send-email-me@akshayjoshi.com>
Issues with spaces (such as not having spaces inside of square brackets,
etc.) were fixed in the wb35tx.c file.
Signed-off-by: Akshay Joshi <me@akshayjoshi.com>
---
drivers/staging/winbond/wb35tx.c | 26 +++++++++++++-------------
1 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/winbond/wb35tx.c b/drivers/staging/winbond/wb35tx.c
index 21edbc9..49a43c1 100644
--- a/drivers/staging/winbond/wb35tx.c
+++ b/drivers/staging/winbond/wb35tx.c
@@ -36,7 +36,7 @@ static void Wb35Tx_complete(struct urb *pUrb)
// Variable setting
pWb35Tx->EP4vm_state = VM_COMPLETED;
pWb35Tx->EP4VM_status = pUrb->status; //Store the last result of Irp
- pMds->TxOwner[ pWb35Tx->TxSendIndex ] = 0;// Set the owner. Free the owner bit always.
+ pMds->TxOwner[pWb35Tx->TxSendIndex] = 0;// Set the owner. Free the owner bit always.
pWb35Tx->TxSendIndex++;
pWb35Tx->TxSendIndex %= MAX_USB_TX_BUFFER_NUMBER;
@@ -90,12 +90,12 @@ static void Wb35Tx(struct wbsoft_priv *adapter)
//
usb_fill_bulk_urb(pUrb, pHwData->udev,
usb_sndbulkpipe(pHwData->udev, 4),
- pTxBufferAddress, pMds->TxBufferSize[ SendIndex ],
+ pTxBufferAddress, pMds->TxBufferSize[SendIndex],
Wb35Tx_complete, adapter);
pWb35Tx->EP4vm_state = VM_RUNNING;
retv = usb_submit_urb(pUrb, GFP_ATOMIC);
- if (retv<0) {
+ if (retv < 0) {
printk("EP4 Tx Irp sending error\n");
goto cleanup;
}
@@ -137,7 +137,7 @@ unsigned char Wb35Tx_initial(struct hw_data *pHwData)
pWb35Tx->Tx2Urb = usb_alloc_urb(0, GFP_ATOMIC);
if (!pWb35Tx->Tx2Urb)
{
- usb_free_urb( pWb35Tx->Tx4Urb );
+ usb_free_urb(pWb35Tx->Tx4Urb);
return false;
}
@@ -151,12 +151,12 @@ void Wb35Tx_stop(struct hw_data *pHwData)
// Trying to canceling the Trp of EP2
if (pWb35Tx->EP2vm_state == VM_RUNNING)
- usb_unlink_urb( pWb35Tx->Tx2Urb ); // Only use unlink, let Wb35Tx_destrot to free them
+ usb_unlink_urb(pWb35Tx->Tx2Urb); // Only use unlink, let Wb35Tx_destrot to free them
pr_debug("EP2 Tx stop\n");
// Trying to canceling the Irp of EP4
if (pWb35Tx->EP4vm_state == VM_RUNNING)
- usb_unlink_urb( pWb35Tx->Tx4Urb ); // Only use unlink, let Wb35Tx_destrot to free them
+ usb_unlink_urb(pWb35Tx->Tx4Urb); // Only use unlink, let Wb35Tx_destrot to free them
pr_debug("EP4 Tx stop\n");
}
@@ -168,14 +168,14 @@ void Wb35Tx_destroy(struct hw_data *pHwData)
// Wait for VM stop
do {
msleep(10); // Delay for waiting function enter 940623.1.a
- } while( (pWb35Tx->EP2vm_state != VM_STOP) && (pWb35Tx->EP4vm_state != VM_STOP) );
+ } while ((pWb35Tx->EP2vm_state != VM_STOP) && (pWb35Tx->EP4vm_state != VM_STOP));
msleep(10); // Delay for waiting function enter 940623.1.b
if (pWb35Tx->Tx4Urb)
- usb_free_urb( pWb35Tx->Tx4Urb );
+ usb_free_urb(pWb35Tx->Tx4Urb);
if (pWb35Tx->Tx2Urb)
- usb_free_urb( pWb35Tx->Tx2Urb );
+ usb_free_urb(pWb35Tx->Tx2Urb);
pr_debug("Wb35Tx_destroy OK\n");
}
@@ -224,7 +224,7 @@ static void Wb35Tx_EP2VM_complete(struct urb *pUrb)
//The Urb is completed, check the result
if (pWb35Tx->EP2VM_status != 0) {
printk("EP2 IoCompleteRoutine return error\n");
- pWb35Tx->EP2vm_state= VM_STOP;
+ pWb35Tx->EP2vm_state = VM_STOP;
goto error;
}
@@ -238,7 +238,7 @@ static void Wb35Tx_EP2VM_complete(struct urb *pUrb)
T02.value |= ((cpu_to_le32(pltmp[i]) & 0xff) << 24);
TSTATUS.value = T02.value; //20061009 anson's endian
- Mds_SendComplete( adapter, &TSTATUS );
+ Mds_SendComplete(adapter, &TSTATUS);
T02.value = cpu_to_le32(pltmp[i]) >> 8;
}
@@ -265,8 +265,8 @@ static void Wb35Tx_EP2VM(struct wbsoft_priv *adapter)
//
// Issuing URB
//
- usb_fill_int_urb( pUrb, pHwData->udev, usb_rcvintpipe(pHwData->udev,2),
- pltmp, MAX_INTERRUPT_LENGTH, Wb35Tx_EP2VM_complete, adapter, 32);
+ usb_fill_int_urb(pUrb, pHwData->udev, usb_rcvintpipe(pHwData->udev, 2),
+ pltmp, MAX_INTERRUPT_LENGTH, Wb35Tx_EP2VM_complete, adapter, 32);
pWb35Tx->EP2vm_state = VM_RUNNING;
retv = usb_submit_urb(pUrb, GFP_ATOMIC);
--
1.7.5.4
next prev parent reply other threads:[~2011-08-16 0:25 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 0:24 [PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c Akshay Joshi
2011-08-16 0:24 ` [PATCH 2/9] Staging: Winbond: Fix pointer style in wb35tx.c Akshay Joshi
2011-08-16 5:41 ` Pekka Enberg
2011-08-16 0:24 ` Akshay Joshi [this message]
2011-08-16 5:42 ` [PATCH 3/9] Staging: Winbond: Fix space issues " Pekka Enberg
2011-08-16 0:24 ` [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond Akshay Joshi
2011-08-16 5:42 ` Pekka Enberg
2011-08-16 19:56 ` Gábor Stefanik
2011-08-16 21:24 ` Pekka Enberg
2011-08-16 21:38 ` Gábor Stefanik
2011-08-16 21:40 ` Gábor Stefanik
2011-08-17 5:41 ` Pekka Enberg
2011-08-17 19:15 ` Akshay Joshi
2011-08-17 19:17 ` Akshay Joshi
2011-08-17 21:08 ` Dan Carpenter
2011-08-16 21:43 ` Dan Carpenter
2011-08-17 0:19 ` Akshay Joshi
2011-08-16 0:24 ` [PATCH 5/9] Staging: Winbond: Fix spacing issues for spaces before tabs Akshay Joshi
2011-08-16 5:43 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 6/9] Staging: Winbond: Remove spacing issues related to pointers Akshay Joshi
2011-08-16 5:45 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 7/9] Staging: Winbond: Fix parentheses in returns Akshay Joshi
2011-08-16 5:45 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 8/9] Staging: Winbond: Use tabs instead of spaces for indents Akshay Joshi
2011-08-16 5:46 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 9/9] Staging: Winbond: Reposition a curly bracket Akshay Joshi
2011-08-16 5:46 ` Pekka Enberg
2011-08-16 5:41 ` [PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c Pekka Enberg
2011-08-23 22:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1313454275-5604-3-git-send-email-me@akshayjoshi.com \
--to=me@akshayjoshi.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=karthigan.srinivasan2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox