* [PATCH 1/2] mfd: da903x: Ensure setting bits if new value is different from the old value
@ 2011-10-31 6:23 Axel Lin
2011-10-31 6:24 ` [PATCH 2/2] mfd: tps6586x: " Axel Lin
0 siblings, 1 reply; 2+ messages in thread
From: Axel Lin @ 2011-10-31 6:23 UTC (permalink / raw)
To: linux-kernel; +Cc: Mike Rapoport, Eric Miao, Samuel Ortiz
It does not make sense to write new value only when all the bit_mask
bits are zero.
We need to write new value if the bit mask fields of new value is
not equal to old value.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mfd/da903x.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/da903x.c b/drivers/mfd/da903x.c
index 62ce685..1924b85 100644
--- a/drivers/mfd/da903x.c
+++ b/drivers/mfd/da903x.c
@@ -182,7 +182,7 @@ int da903x_set_bits(struct device *dev, int reg, uint8_t bit_mask)
if (ret)
goto out;
- if ((reg_val & bit_mask) == 0) {
+ if ((reg_val & bit_mask) != bit_mask) {
reg_val |= bit_mask;
ret = __da903x_write(chip->client, reg, reg_val);
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH 2/2] mfd: tps6586x: Ensure setting bits if new value is different from the old value
2011-10-31 6:23 [PATCH 1/2] mfd: da903x: Ensure setting bits if new value is different from the old value Axel Lin
@ 2011-10-31 6:24 ` Axel Lin
0 siblings, 0 replies; 2+ messages in thread
From: Axel Lin @ 2011-10-31 6:24 UTC (permalink / raw)
To: linux-kernel; +Cc: Mike Rapoport, Eric Miao, Samuel Ortiz
It does not make sense to write new value only when all the bit_mask
bits are zero.
We need to write new value if the bit mask fields of new value is
not equal to old value.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mfd/tps6586x.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
index bba26d9..a5ddf31 100644
--- a/drivers/mfd/tps6586x.c
+++ b/drivers/mfd/tps6586x.c
@@ -197,7 +197,7 @@ int tps6586x_set_bits(struct device *dev, int reg, uint8_t bit_mask)
if (ret)
goto out;
- if ((reg_val & bit_mask) == 0) {
+ if ((reg_val & bit_mask) != bit_mask) {
reg_val |= bit_mask;
ret = __tps6586x_write(to_i2c_client(dev), reg, reg_val);
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-31 6:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-31 6:23 [PATCH 1/2] mfd: da903x: Ensure setting bits if new value is different from the old value Axel Lin
2011-10-31 6:24 ` [PATCH 2/2] mfd: tps6586x: " Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox