From: Jonas Bonn <jonas@southpole.se>
To: Richard Weinberger <richard@nod.at>
Cc: linux@openrisc.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] OpenRISC: Export memory_start and memory_end
Date: Fri, 02 Mar 2012 07:51:42 +0100 [thread overview]
Message-ID: <1330671102.19557.100.camel@satguru> (raw)
In-Reply-To: <1330649715-32438-3-git-send-email-richard@nod.at>
[-- Attachment #1: Type: text/plain, Size: 1702 bytes --]
On Fri, 2012-03-02 at 01:55 +0100, Richard Weinberger wrote:
> At least virt_addr_valid() makes use of memory_end.
virt_addr_valid looks broken... it shouldn't be comparing a virtual
address against memory_end which is phys_addr_t.
/Jonas
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> arch/openrisc/include/asm/page.h | 4 ++--
> arch/openrisc/kernel/setup.c | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/openrisc/include/asm/page.h b/arch/openrisc/include/asm/page.h
> index b041b34..4dfe477 100644
> --- a/arch/openrisc/include/asm/page.h
> +++ b/arch/openrisc/include/asm/page.h
> @@ -71,8 +71,8 @@ typedef struct page *pgtable_t;
> #define __pgd(x) ((pgd_t) { (x) })
> #define __pgprot(x) ((pgprot_t) { (x) })
>
> -extern unsigned long memory_start;
> -extern unsigned long memory_end;
> +extern phys_addr_t memory_start;
> +extern phys_addr_t memory_end;
>
> #endif /* !__ASSEMBLY__ */
>
> diff --git a/arch/openrisc/kernel/setup.c b/arch/openrisc/kernel/setup.c
> index bf5eba2..c993c92 100644
> --- a/arch/openrisc/kernel/setup.c
> +++ b/arch/openrisc/kernel/setup.c
> @@ -52,6 +52,7 @@
> #include "vmlinux.h"
>
> char __initdata cmd_line[COMMAND_LINE_SIZE] = CONFIG_CMDLINE;
> +phys_addr_t memory_start, memory_end;
>
> static unsigned long __init setup_memory(void)
> {
> @@ -59,7 +60,6 @@ static unsigned long __init setup_memory(void)
> unsigned long ram_start_pfn;
> unsigned long free_ram_start_pfn;
> unsigned long ram_end_pfn;
> - phys_addr_t memory_start, memory_end;
> struct memblock_region *region;
>
> memory_end = memory_start = 0;
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-03-02 6:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 0:55 [PATCH 1/5] OpenRISC: Select GENERIC_ATOMIC64 Richard Weinberger
2012-03-02 0:55 ` [PATCH 2/5] OpenRISC: Use generic bitops.h Richard Weinberger
2012-03-02 6:50 ` Jonas Bonn
2012-03-02 8:47 ` Richard Weinberger
2012-03-02 0:55 ` [PATCH 3/5] OpenRISC: Export memory_start and memory_end Richard Weinberger
2012-03-02 6:51 ` Jonas Bonn [this message]
2012-03-02 8:48 ` Richard Weinberger
2012-03-02 9:14 ` Jonas Bonn
2012-03-02 0:55 ` [PATCH 4/5] OpenRISC: Include export.h Richard Weinberger
2012-03-02 0:55 ` [PATCH 5/5] OpenRISC: Export dump_stack() Richard Weinberger
2012-03-02 7:12 ` Jonas Bonn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330671102.19557.100.camel@satguru \
--to=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@openrisc.net \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox