From: Richard Weinberger <richard@nod.at>
To: Jonas Bonn <jonas@southpole.se>
Cc: linux@openrisc.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] OpenRISC: Export memory_start and memory_end
Date: Fri, 02 Mar 2012 09:48:34 +0100 [thread overview]
Message-ID: <4F508962.1070108@nod.at> (raw)
In-Reply-To: <1330671102.19557.100.camel@satguru>
[-- Attachment #1: Type: text/plain, Size: 390 bytes --]
Am 02.03.2012 07:51, schrieb Jonas Bonn:
> On Fri, 2012-03-02 at 01:55 +0100, Richard Weinberger wrote:
>> At least virt_addr_valid() makes use of memory_end.
>
> virt_addr_valid looks broken... it shouldn't be comparing a virtual
> address against memory_end which is phys_addr_t.
Then it's time to implement it correctly and match OpenRISC's
semantics.
Thanks,
//richard
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2012-03-02 8:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 0:55 [PATCH 1/5] OpenRISC: Select GENERIC_ATOMIC64 Richard Weinberger
2012-03-02 0:55 ` [PATCH 2/5] OpenRISC: Use generic bitops.h Richard Weinberger
2012-03-02 6:50 ` Jonas Bonn
2012-03-02 8:47 ` Richard Weinberger
2012-03-02 0:55 ` [PATCH 3/5] OpenRISC: Export memory_start and memory_end Richard Weinberger
2012-03-02 6:51 ` Jonas Bonn
2012-03-02 8:48 ` Richard Weinberger [this message]
2012-03-02 9:14 ` Jonas Bonn
2012-03-02 0:55 ` [PATCH 4/5] OpenRISC: Include export.h Richard Weinberger
2012-03-02 0:55 ` [PATCH 5/5] OpenRISC: Export dump_stack() Richard Weinberger
2012-03-02 7:12 ` Jonas Bonn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F508962.1070108@nod.at \
--to=richard@nod.at \
--cc=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@openrisc.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox