From: Jonas Bonn <jonas@southpole.se>
To: Richard Weinberger <richard@nod.at>
Cc: linux@openrisc.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] OpenRISC: Use generic bitops.h
Date: Fri, 02 Mar 2012 07:50:26 +0100 [thread overview]
Message-ID: <1330671026.19557.99.camel@satguru> (raw)
In-Reply-To: <1330649715-32438-2-git-send-email-richard@nod.at>
[-- Attachment #1: Type: text/plain, Size: 916 bytes --]
On Fri, 2012-03-02 at 01:55 +0100, Richard Weinberger wrote:
> There is no need to reinvent the wheel.
NAK... we have optimized versions for some of these operations so the
generic header isn't right for us.
Have a look at arch/openrisc/asm/include/bitops.h to see which functions
we override with accelerated versions.
/Jonas
>
> Signed-off-by: Richard Weinberger <richard@nod.at>
> ---
> arch/openrisc/include/asm/Kbuild | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/openrisc/include/asm/Kbuild b/arch/openrisc/include/asm/Kbuild
> index 11162e6..a283165 100644
> --- a/arch/openrisc/include/asm/Kbuild
> +++ b/arch/openrisc/include/asm/Kbuild
> @@ -4,6 +4,7 @@ header-y += spr_defs.h
>
> generic-y += atomic.h
> generic-y += auxvec.h
> +generic-y += bitops.h
> generic-y += bitsperlong.h
> generic-y += bug.h
> generic-y += bugs.h
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2012-03-02 6:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 0:55 [PATCH 1/5] OpenRISC: Select GENERIC_ATOMIC64 Richard Weinberger
2012-03-02 0:55 ` [PATCH 2/5] OpenRISC: Use generic bitops.h Richard Weinberger
2012-03-02 6:50 ` Jonas Bonn [this message]
2012-03-02 8:47 ` Richard Weinberger
2012-03-02 0:55 ` [PATCH 3/5] OpenRISC: Export memory_start and memory_end Richard Weinberger
2012-03-02 6:51 ` Jonas Bonn
2012-03-02 8:48 ` Richard Weinberger
2012-03-02 9:14 ` Jonas Bonn
2012-03-02 0:55 ` [PATCH 4/5] OpenRISC: Include export.h Richard Weinberger
2012-03-02 0:55 ` [PATCH 5/5] OpenRISC: Export dump_stack() Richard Weinberger
2012-03-02 7:12 ` Jonas Bonn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1330671026.19557.99.camel@satguru \
--to=jonas@southpole.se \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@openrisc.net \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox