* [PATCH] pipe: return -ENOIOCTLCMD instead of -EINVAL on unknown ioctl command
@ 2012-05-25 10:39 Will Deacon
2012-05-25 13:43 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Will Deacon @ 2012-05-25 10:39 UTC (permalink / raw)
To: linux-kernel; +Cc: Will Deacon, Al Viro, Andrew Morton
As described in commit 07d106d0a ("vfs: fix up ENOIOCTLCMD error
handling"), drivers should return -ENOIOCTLCMD if they receive an ioctl
command which they don't understand. Doing so will result in -ENOTTY
being returned to userspace, which matches the behaviour of the compat
layer if it fails to translate an ioctl command.
This patch fixes the pipe ioctl to return -ENOIOCTLCMD instead of
-EINVAL when passed an unknown ioctl command.
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
fs/pipe.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/pipe.c b/fs/pipe.c
index fec5e4a..95ebb56 100644
--- a/fs/pipe.c
+++ b/fs/pipe.c
@@ -693,7 +693,7 @@ static long pipe_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
return put_user(count, (int __user *)arg);
default:
- return -EINVAL;
+ return -ENOIOCTLCMD;
}
}
--
1.7.4.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] pipe: return -ENOIOCTLCMD instead of -EINVAL on unknown ioctl command
2012-05-25 10:39 [PATCH] pipe: return -ENOIOCTLCMD instead of -EINVAL on unknown ioctl command Will Deacon
@ 2012-05-25 13:43 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2012-05-25 13:43 UTC (permalink / raw)
To: Will Deacon; +Cc: linux-kernel, Al Viro, Andrew Morton
On Fri, 25 May 2012 11:39:13 +0100
Will Deacon <will.deacon@arm.com> wrote:
> As described in commit 07d106d0a ("vfs: fix up ENOIOCTLCMD error
> handling"), drivers should return -ENOIOCTLCMD if they receive an ioctl
> command which they don't understand. Doing so will result in -ENOTTY
> being returned to userspace, which matches the behaviour of the compat
> layer if it fails to translate an ioctl command.
>
> This patch fixes the pipe ioctl to return -ENOIOCTLCMD instead of
> -EINVAL when passed an unknown ioctl command.
>
> Cc: Al Viro <viro@zeniv.linux.org.uk>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Signed-off-by: Will Deacon <will.deacon@arm.com>
Acked-by: Alan Cox <alan@linux.intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-25 13:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-25 10:39 [PATCH] pipe: return -ENOIOCTLCMD instead of -EINVAL on unknown ioctl command Will Deacon
2012-05-25 13:43 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox