[PATCH] scripts/get_maintainer.pl: Add tested-by signature

[PATCH] scripts/get_maintainer.pl: Add tested-by signature

[Alexandre Pereira da Silva]

The tester of the patch should also be listed to receive patch
notifications.

Signed-off-by: Alexandre Pereira da Silva <aletes.xgr@gmail.com>
---
 scripts/get_maintainer.pl |    1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
index 0948c6b..5715773 100755
--- a/scripts/get_maintainer.pl
+++ b/scripts/get_maintainer.pl
@@ -81,6 +81,7 @@ my $penguin_chiefs = "\(" . join("|", @penguin_chief_names) . "\)";
 my @signature_tags = ();
 push(@signature_tags, "Signed-off-by:");
 push(@signature_tags, "Reviewed-by:");
+push(@signature_tags, "Tested-by:");
 push(@signature_tags, "Acked-by:");
 
 # rfc822 email address - preloaded methods go here.
-- 
1.7.10

Re: [PATCH] scripts/get_maintainer.pl: Add tested-by signature

[Joe Perches]

On Wed, 2012-06-20 at 08:51 -0300, Alexandre Pereira da Silva wrote:
> The tester of the patch should also be listed to receive patch
> notifications.
[]
> diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
[]
> @@ -81,6 +81,7 @@ my $penguin_chiefs = "\(" . join("|", @penguin_chief_names) . "\)";
>  my @signature_tags = ();
>  push(@signature_tags, "Signed-off-by:");
>  push(@signature_tags, "Reviewed-by:");
> +push(@signature_tags, "Tested-by:");
>  push(@signature_tags, "Acked-by:");

I have no objections to this, but maybe Florian Mickler
(cc'd) who did analysis on signatures awhile ago might.

Re: [PATCH] scripts/get_maintainer.pl: Add tested-by signature

[Andrew Morton]

On Wed, 20 Jun 2012 09:25:26 -0700
Joe Perches <joe@perches.com> wrote:

> On Wed, 2012-06-20 at 08:51 -0300, Alexandre Pereira da Silva wrote:
> > The tester of the patch should also be listed to receive patch
> > notifications.
> []
> > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> []
> > @@ -81,6 +81,7 @@ my $penguin_chiefs = "\(" . join("|", @penguin_chief_names) . "\)";
> >  my @signature_tags = ();
> >  push(@signature_tags, "Signed-off-by:");
> >  push(@signature_tags, "Reviewed-by:");
> > +push(@signature_tags, "Tested-by:");
> >  push(@signature_tags, "Acked-by:");
> 
> I have no objections to this, but maybe Florian Mickler
> (cc'd) who did analysis on signatures awhile ago might.
> 

Yes.  In my experience, a lot of tested-by's come from random internet
victims who happened to report a bug and who we'll never hear from
again and who don't want to be told other things about
whatever-part-of-the-kernel-that-was.

Perhaps the set "has a tested-by, doesn't have reported-by" would
filter out a lot of these, dunno.  It all sounds a bit marginal.



Also, lots of people have used a "Reported-and-tested-by" and there are
even a few lysdexic "Tested-and-[rR]eported-by" tags in there.

Any time I see one of these things I stomp on it and turn it into
separate reported-by and tested-by lines, as Reported-and-tested-by
just adds pointless duplication, work and noise.  But I appear to have
lost that fight.


This fashion of adding new and innovative changelog tags just creates
inaccuracy and work for people who wish to mine that data for something
useful, as Alexandre is finding out.

<does some data mining>

Geeze, guys.  Who knew there were so many Kernel Komedians?


ACKed-by:
AOLed-by:
About-fscking-timed-by:
Accked-by:
Aced-by:
Ached-by:
Acked-By:
Acked-and-Tested-by:
Acked-and-appreciated-by:
Acked-and-reviewed-by:
Acked-and-tested-by:
Acked-by:
Ackeded-by:
Aked-by:
Also-Bisected-by:
Also-Reported-by:
Also-Suggested-by:
Also-analyzed-by:
Also-reported-and-tested-by:
Also-reported-by:
Analysed-by:
Analyzed-by:
Antagonized-by:
Approved-by:
Bisected-and-reported-by:
Bisected-and-requested-by:
Bisected-and-tested-by:
Bisected-by:
Bisected-reported-and-tested-by:
Bitten-by-and-tested-by:
Bug-Identified-by:
Bug-fixed-by:
Bug-identified-by:
Bug-spotted-by:
Cause-discovered-by:
Cautiously-acked-by:
Checked-by:
Committed-by:
Compile-Tested-by:
Compile-tested-by:
Confirmed-by:
Debugged-and-tested-by:
Debugged-by:
Debugged-by:Gautham
Delightedly-acked-by:
Diagnoised-by:
Diagnosed-by:
Discovered-by:
Earlier-version-tested-by:
Embarrassingly-Acked-by:
Emphatically-Acked-by:
Encouraged-by:
Explained-by:
Fatfingered-by:
Finished-by:
Fix-proposed-by:
Fix-suggested-by:
Fixed-by:
Forwarded-by:
Gcc-bug-acked-by:
Grudgingly-acked-by:
Grumpily-requested-by:
Hacked-by:
Hardware-supplied-by:
Hella-acked-by:
Helped-by:
Hinted-by:
Humbly-acked-by:
Identified-by:
Inspired-by:
Inspried-by:
Jffs2-bit-acked-by:
Last-bug-reported-by:
Lightly-Tested-by:
Lightly-tested-by:
Liked-by:
List-Composed-By:
Located-by:
Maybe-reported-by:
Mentored-by:
Modified-by:
More-or-less-tested-by:
Most-Definitely-Acked-by:
Mostly-acked-by:
NACKed-by:
Noted-by:
Noticed-and-Acked-by:
Noticed-by:
Original-coded-by:
Origionally-authored-by:
Partly-suggested-by:
Patch-Inspired-by:
Patch-inspired-by:
Patch-updated-by:
Pointed-out-and-tested-by:
Poked-by:
Proposed-by:
Pushed-by:
Re-reported-by:
Reminded-by:
Repented-by:
Reporeted-by:
Reported--and-debugged-by:
Reported-And-Tested-by:
Reported-Bisected-Tested-by:
Reported-Bistected-and-Tested-by:
Reported-By:
Reported-Debuged-Tested-Acked-by:
Reported-Reviewed-and-Acked-by:
Reported-Tested-by:
Reported-and-Acked-by:
Reported-and-Bisected-by:
Reported-and-Debugged-by:
Reported-and-Reviewed-and-Tested-by:
Reported-and-Reviwed-by:
Reported-and-Tested-By:
Reported-and-Tested-by:
Reported-and-acked-by:
Reported-and-analyzed-by:
Reported-and-bisected-by:
Reported-and-compile-tested-by:
Reported-and-debugged-by:
Reported-and-helped-by:
Reported-and-introduced-by:
Reported-and-isolated-by:
Reported-and-requested-by:
Reported-and-reviewed-by:
Reported-and-root-caused-by:
Reported-and-tested-by:
Reported-any-tested-by:
Reported-bisected-and-tested-by:
Reported-bisected-tested-by:
Reported-by-Tested-by:
Reported-by-and-Tested-by:
Reported-by:
Reported-requested-and-tested-by:
Reported-tested-and-acked-by:
Reported-tested-and-bisected-by:
Reported-tested-and-fixed-by:
Reporteed-by:
Reproduced-by:
Requested-and-acked-by:
Requested-and-tested-by:
Requested-by:
Requsted-by:
Reveiewed-by:
Reviewed-By:
Reviewed-and-Acked-by:
Reviewed-and-Tested-by:
Reviewed-and-discussed-by:
Reviewed-and-tested-by:
Reviewed-and-wanted-by:
Reviewed-by:
Reviewied-by:
Reviwed-by:
Rewieved-by:
Root-caused-by:
Seconded-by:
Serial-parts-Acked-by:
Sight-catched-by:
Signed-by:
Signed-off-and-morning-tea-spilled-by:
Sort-Of-Acked-By:
Spotted-by:
Submitted-by:
Suggested-and-Acked-by:
Suggested-and-acked-by:
Suggested-and-tested-by:
Suggested-by:
Tentatively-acked-by:
Tested-By:
Tested-and-Acked-by:
Tested-and-Reported-by:
Tested-and-Verified-By:
Tested-and-acked-by:
Tested-and-bugfixed-by:
Tested-and-reported-by:
Tested-and-requested-by:
Tested-and-reviewed-by:
Tested-by:
Testted-by:
Triaged-by:
Verified-by:
Was-Acked-by:
Whatevered-by:

Re: [PATCH] scripts/get_maintainer.pl: Add tested-by signature

[Jesper Juhl]

On Wed, 20 Jun 2012, Andrew Morton wrote:

> On Wed, 20 Jun 2012 09:25:26 -0700
> Joe Perches <joe@perches.com> wrote:
> 
> > On Wed, 2012-06-20 at 08:51 -0300, Alexandre Pereira da Silva wrote:
> > > The tester of the patch should also be listed to receive patch
> > > notifications.
> > []
> > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> > []
> > > @@ -81,6 +81,7 @@ my $penguin_chiefs = "\(" . join("|", @penguin_chief_names) . "\)";
> > >  my @signature_tags = ();
> > >  push(@signature_tags, "Signed-off-by:");
> > >  push(@signature_tags, "Reviewed-by:");
> > > +push(@signature_tags, "Tested-by:");
> > >  push(@signature_tags, "Acked-by:");
> > 
> > I have no objections to this, but maybe Florian Mickler
> > (cc'd) who did analysis on signatures awhile ago might.
> > 
> 
> Yes.  In my experience, a lot of tested-by's come from random internet
> victims who happened to report a bug and who we'll never hear from
> again and who don't want to be told other things about
> whatever-part-of-the-kernel-that-was.
> 
> Perhaps the set "has a tested-by, doesn't have reported-by" would
> filter out a lot of these, dunno.  It all sounds a bit marginal.
> 
> 
> 
> Also, lots of people have used a "Reported-and-tested-by" and there are
> even a few lysdexic "Tested-and-[rR]eported-by" tags in there.
> 
> Any time I see one of these things I stomp on it and turn it into
> separate reported-by and tested-by lines, as Reported-and-tested-by
> just adds pointless duplication, work and noise.  But I appear to have
> lost that fight.
> 
> 
> This fashion of adding new and innovative changelog tags just creates
> inaccuracy and work for people who wish to mine that data for something
> useful, as Alexandre is finding out.
> 
> <does some data mining>
> 
> Geeze, guys.  Who knew there were so many Kernel Komedians?
> 
Andrew - stomp harder!

I'm well aware that it's not your job to fix this mess - just couldn't 
help myself commenting on your "Any time I see one of these things I stomp 
on it" comment...  You should stomp, and stomp HARD!

-- 
Jesper Juhl <jj@chaosbits.net>       http://www.chaosbits.net/
Don't top-post http://www.catb.org/jargon/html/T/top-post.html
Plain text mails only, please.

Re: [PATCH] scripts/get_maintainer.pl: Add tested-by signature

[Joe Perches]

On Wed, 2012-06-20 at 14:39 -0700, Andrew Morton wrote:
> On Wed, 20 Jun 2012 09:25:26 -0700
> Joe Perches <joe@perches.com> wrote:
> 
> > On Wed, 2012-06-20 at 08:51 -0300, Alexandre Pereira da Silva wrote:
> > > The tester of the patch should also be listed to receive patch
> > > notifications.
> > []
> > > diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl
> > []
> > > @@ -81,6 +81,7 @@ my $penguin_chiefs = "\(" . join("|", @penguin_chief_names) . "\)";
> > >  my @signature_tags = ();
> > >  push(@signature_tags, "Signed-off-by:");
> > >  push(@signature_tags, "Reviewed-by:");
> > > +push(@signature_tags, "Tested-by:");
> > >  push(@signature_tags, "Acked-by:");
> > 
> > I have no objections to this, but maybe Florian Mickler
> > (cc'd) who did analysis on signatures awhile ago might.
> > 
> 
> Yes.  In my experience, a lot of tested-by's come from random internet
> victims who happened to report a bug and who we'll never hear from
> again and who don't want to be told other things about
> whatever-part-of-the-kernel-that-was.
> 
> Perhaps the set "has a tested-by, doesn't have reported-by" would
> filter out a lot of these, dunno.  It all sounds a bit marginal.
> 
> 
> 
> Also, lots of people have used a "Reported-and-tested-by" and there are
> even a few lysdexic "Tested-and-[rR]eported-by" tags in there.
> 
> Any time I see one of these things I stomp on it and turn it into
> separate reported-by and tested-by lines, as Reported-and-tested-by
> just adds pointless duplication, work and noise.  But I appear to have
> lost that fight.
> 
> 
> This fashion of adding new and innovative changelog tags just creates
> inaccuracy and work for people who wish to mine that data for something
> useful, as Alexandre is finding out.
> 
> <does some data mining>
> 
> Geeze, guys.  Who knew there were so many Kernel Komedians?

Lighten up.
I don't think there's a real issue with Kernel Komedy.
It's a real small % of all signatures.

But comedi is still gross and ugly, keep at it Harley...

$ git log --pretty=oneline --since=1-year-ago | \
  wc -l
59347

$ git log --format=email --since=1-year-ago | \
  grep -Eio "^\s*[a-z0-9_-]+by:"| \
  sed -r 's/^\s+//g' | sort | uniq -c | sort -rn
 103179 Signed-off-by:
  10516 Acked-by:
   5435 Reviewed-by:
   2748 Reported-by:
   2450 Tested-by:
    252 Suggested-by:
    178 Signed-Off-by:
    172 Reported-and-tested-by:
     50 Requested-by:
     35 Tested-By: 
     34 Reviewed-By:
     31 Reported-and-Tested-by:
     26 Acked-By:
     22 Reviewed-and-Tested-by:
     13 Acked-and-tested-by:
     12 Signed-of-by:
     12 Originally-by:
      9 Reviewed-and-tested-by:
      9 Reported-By:
      9 Reported-and-bisected-by:
      8 Bisected-by:
      7 Tested-and-Acked-by:
      7 Reviwed-by:
      7 Inspired-by:
      6 Original-patch-by:
      6 Based-on-patch-by:
      6 ACKed-by:
      5 signed-off-by:
      5 Ack-by:
      4 Tested-and-Reported-by:
      4 Tested-and-acked-by:
      4 Signed-Off-By:
      4 Requested-and-tested-by:
      4 Acked-and-Tested-by:
      3 Suggested-and-acked-by:
      3 Reported-bisected-and-tested-by:
      3 Reported-and-acked-by:
      3 Proposed-by:
      3 Patch-updated-by:
      3 Origionally-authored-by:
      3 Noticed-by:
      3 Hacked-by:
      3 Debugged-by:
      3 Analyzed-by:
      2 Tested-and-reviewed-by:
      2 Suggested-and-Acked-by:
      2 Singed-off-by:
      2 SIgned-off-by:
      2 Reviewied-by:
      2 Reported-and-analyzed-by:
      2 Reported-and-Acked-by:
      2 Maybe-reported-by:
      2 Helped-by:
      2 Found-by:
      2 Broken-by:
      2 Acked-off-by:
      2 Ackec-by:
      1 Verified-by:
      1 Tracked-down-by:
      1 Tested-and-bugfixed-by:
      1 Spotted-by:
      1 Sined-off-by:
      1 Sig-off-by:
      1 Signed-Signed-off-by:
      1 Signed-off-by-by:
      1 Signed-off-By:
      1 Signed-ff-by:
      1 Reviewed-and-wanted-by:
      1 Reported-Tested-by:
      1 Reported-tested-and-bisected-by:
      1 Reported-tested-and-acked-by:
      1 Reported-requested-and-tested-by:
      1 Reported-by-and-Tested-by:
      1 Reported-any-tested-by:
      1 Reported-and-Tested-By:
      1 Reported-and-Reviewed-and-Tested-by:
      1 Reported-and-requested-by:
      1 Reported-and-Debugged-by:
      1 Reported-and-debugged-by:
      1 Report-by:
      1 Reporetd-by:
      1 Partly-suggested-by:
      1 Original-idea-by:
      1 Liked-by:
      1 Last-bug-reported-by:
      1 Inspried-by:
      1 Grumpily-requested-by:
      1 Fucked-up-by:
      1 Fixes-by:
      1 Fixed-by:
      1 Fix-by:
      1 Finished-by:
      1 Encouraged-by:
      1 Diagnosed-by:
      1 Diagnoised-by:
      1 cked-by:
      1 Bisected-reported-and-tested-by:
      1 Antagonized-by:
      1 Analysed-by:
      1 Also-written-by:
      1 Also-Reported-by:
      1 Also-reported-by:
      1 Aked-by:
      1 Ackeded-by:
      1 Ackedby:
      1 Acked-and-reviewed-by:
      1 Ached-by:
      1 Accked-by:

Re: [PATCH] scripts/get_maintainer.pl: Add tested-by signature

[richard -rw- weinberger]

On Wed, Jun 20, 2012 at 11:54 PM, Joe Perches <joe@perches.com> wrote:
>      1 Fucked-up-by:

We should push this one. :-)

-- 
Thanks,
//richard

Re: [PATCH] scripts/get_maintainer.pl: Add tested-by signature

[Joe Perches]

On Wed, 2012-06-20 at 23:58 +0200, richard -rw- weinberger wrote:
> On Wed, Jun 20, 2012 at 11:54 PM, Joe Perches <joe@perches.com> wrote:
> >      1 Fucked-up-by:
> 
> We should push this one. :-)

I'd hope as infrequently as possible,
but it's certainly useful or at least
truthful.

[PATCH] scripts/get_maintainer.pl: Test for non-standard signatures

[Joe Perches]

Warn on non-standard signature styles.

Signed-off-by: Joe Perches <joe@perches.com>
---
 scripts/checkpatch.pl |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 630319a..3e04f80 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1600,13 +1600,17 @@ sub process {
 
 # Check signature styles
 		if (!$in_header_lines &&
-		    $line =~ /^(\s*)($signature_tags)(\s*)(.*)/) {
+		    $line =~ /^(\s*)([a-z0-9_-]+by:|$signature_tags)(\s*)(.*)/i) {
 			my $space_before = $1;
 			my $sign_off = $2;
 			my $space_after = $3;
 			my $email = $4;
 			my $ucfirst_sign_off = ucfirst(lc($sign_off));
 
+			if ($sign_off !~ /$signature_tags/) {
+				WARN("BAD_SIGN_OFF",
+				     "Non-standard signature: $sign_off\n" . $herecurr);
+			}
 			if (defined $space_before && $space_before ne "") {
 				WARN("BAD_SIGN_OFF",
 				     "Do not use whitespace before $ucfirst_sign_off\n" . $herecurr);

Re: [PATCH] scripts/get_maintainer.pl: Test for non-standard signatures

[Joe Perches]

On Wed, 2012-06-20 at 15:10 -0700, Joe Perches wrote:
> Warn on non-standard signature styles.

Seriously crappy subject line.

It should be for checkpatch.

Please fix before applying.

Re: [PATCH] scripts/get_maintainer.pl: Add tested-by signature

[Alexandre Pereira da Silva]

On Thu, Jun 21, 2012 at 2:34 AM, Florian Mickler <florian@mickler.org> wrote:
> Hi,
> IMHO, If necessary the maintainers can manually cc additional people.
> Testedby normally doesn't mean code responsibility or code knowledge. (as
> Andrew pointed already out)

Thank you for your remarks.

Re: [PATCH] scripts/get_maintainer.pl: Add tested-by signature

[Geert Uytterhoeven]

On Wed, Jun 20, 2012 at 11:39 PM, Andrew Morton
<akpm@linux-foundation.org> wrote:
> This fashion of adding new and innovative changelog tags just creates
> inaccuracy and work for people who wish to mine that data for something
> useful, as Alexandre is finding out.
>
> <does some data mining>
>
> Geeze, guys.  Who knew there were so many Kernel Komedians?

I see my sporadically used "Not-yet-signed-off-by" doesn't show up.
Good, so far no one committed any of those ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] scripts/get_maintainer.pl: Add tested-by signature

[Peter Zijlstra]

On Wed, 2012-06-20 at 14:39 -0700, Andrew Morton wrote:
> Bug-spotted-by:
> Cause-discovered-by:
> Cautiously-acked-by:
> Checked-by:
> Committed-by:
> Compile-Tested-by:
> Compile-tested-by:
> Confirmed-by:
> Debugged-and-tested-by: 

You missed my favourite:

Commit 84599f8a59 carries:

  Chucked-on-by: Thomas Gleixner <tglx@linutronix.de>

[ although I must admit to it being a typo, in actual fact Thomas
  wanted to chuckle.. ]

Re: [PATCH] scripts/get_maintainer.pl: Add tested-by signature

[Joe Perches]

On Thu, 2012-06-28 at 12:04 +0200, Peter Zijlstra wrote:
> On Wed, 2012-06-20 at 14:39 -0700, Andrew Morton wrote:
> > Bug-spotted-by:
> > Cause-discovered-by:
> > Cautiously-acked-by:
> > Checked-by:
> > Committed-by:
> > Compile-Tested-by:
> > Compile-tested-by:
> > Confirmed-by:
> > Debugged-and-tested-by: 
> 
> You missed my favourite:

Some of mine are:

AOLed-by:
Blame-taken-by:
Heckled-for-on-IRC-by:
iSigned-off-by: (unfortunately not a contribution from Apple)