Re: [PATCH v4 8/8] ARM: mediatek: Add config option for mediatek SoCs.

Re: [PATCH v4 8/8] ARM: mediatek: Add config option for mediatek SoCs.

[Matthias Brugger]

2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
> From: "Joe.C" <yingjoe.chen@mediatek.com>
>
> Add config options for ARCH_MT6589, ARCH_MT8127, ARCH_MT8135. The
> upcoming pinctrl, clk drivers need to isolate SoCs support base on
> these options.
>
> Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
> ---
>  arch/arm/mach-mediatek/Kconfig | 22 +++++++++++++++++++---
>  1 file changed, 19 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-mediatek/Kconfig b/arch/arm/mach-mediatek/Kconfig
> index 2c043a2..25fe6cf 100644
> --- a/arch/arm/mach-mediatek/Kconfig
> +++ b/arch/arm/mach-mediatek/Kconfig
> @@ -1,6 +1,22 @@
> -config ARCH_MEDIATEK
> -       bool "Mediatek MT6589 SoC" if ARCH_MULTI_V7
> +menuconfig ARCH_MEDIATEK
> +       bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
>         select ARM_GIC
>         select MTK_TIMER
>         help
> -         Support for Mediatek Cortex-A7 Quad-Core-SoC MT6589.
> +         Support for Mediatek MT65xx & MT81xx SoCs
> +
> +if ARCH_MEDIATEK
> +
> +config MACH_MT6589
> +       bool "MediaTek MT6589 SoCs support"
> +       default ARCH_MEDIATEK
> +
> +config MACH_MT8127
> +       bool "MediaTek MT8127 SoCs support"
> +       default ARCH_MEDIATEK
> +
> +config MACH_MT8135
> +       bool "MediaTek MT8135 SoCs support"
> +       default ARCH_MEDIATEK
> +
> +endif

MACH_MTxxxx are not used nowhere, please remove them.

> --
> 1.8.1.1.dirty
>



-- 
motzblog.wordpress.com

Re: [PATCH v4 8/8] ARM: mediatek: Add config option for mediatek SoCs.

[Yingjoe Chen]

Hi Matthias,

On Wed, 2014-10-22 at 15:18 +0200, Matthias Brugger wrote:
> 2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
> > +
> > +if ARCH_MEDIATEK
> > +
> > +config MACH_MT6589
> > +       bool "MediaTek MT6589 SoCs support"
> > +       default ARCH_MEDIATEK
> > +
> > +config MACH_MT8127
> > +       bool "MediaTek MT8127 SoCs support"
> > +       default ARCH_MEDIATEK
> > +
> > +config MACH_MT8135
> > +       bool "MediaTek MT8135 SoCs support"
> > +       default ARCH_MEDIATEK
> > +
> > +endif
> 
> MACH_MTxxxx are not used nowhere, please remove them.

Yes, they are not used in this series yet.

MACH_MT8135 was used in mt8135 pinctrl driver [1] and will be used in
mt8135 clk driver we are about to send. I don't want to create false
dependency between these 2 series so I put it here.
Do you prefer add them when they are first used?

Joe.C

[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/289288.html

Re: [PATCH v4 8/8] ARM: mediatek: Add config option for mediatek SoCs.

[Matthias Brugger]

Hi Joe,

2014-10-22 15:31 GMT+02:00 Yingjoe Chen <yingjoe.chen@mediatek.com>:
>
> Hi Matthias,
>
> On Wed, 2014-10-22 at 15:18 +0200, Matthias Brugger wrote:
>> 2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
>> > +
>> > +if ARCH_MEDIATEK
>> > +
>> > +config MACH_MT6589
>> > +       bool "MediaTek MT6589 SoCs support"
>> > +       default ARCH_MEDIATEK
>> > +
>> > +config MACH_MT8127
>> > +       bool "MediaTek MT8127 SoCs support"
>> > +       default ARCH_MEDIATEK
>> > +
>> > +config MACH_MT8135
>> > +       bool "MediaTek MT8135 SoCs support"
>> > +       default ARCH_MEDIATEK
>> > +
>> > +endif
>>
>> MACH_MTxxxx are not used nowhere, please remove them.
>
> Yes, they are not used in this series yet.
>
> MACH_MT8135 was used in mt8135 pinctrl driver [1] and will be used in
> mt8135 clk driver we are about to send. I don't want to create false
> dependency between these 2 series so I put it here.
> Do you prefer add them when they are first used?

Yes please add them, when they are first used.
Today I had a look on the pinctrl patches you mentioned. It looks to
me as if the config is not needed in the series.

Thanks,
Matthias

[0] http://thread.gmane.org/gmane.linux.ports.arm.kernel/358505

>
> Joe.C
>
> [1]
> http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/289288.html
>
>



-- 
motzblog.wordpress.com

Re: [PATCH v4 8/8] ARM: mediatek: Add config option for mediatek SoCs.

[Yingjoe Chen]

On Wed, 2014-10-22 at 15:53 +0200, Matthias Brugger wrote:
> Hi Joe,
> 
> 2014-10-22 15:31 GMT+02:00 Yingjoe Chen <yingjoe.chen@mediatek.com>:
> >
> > Hi Matthias,
> >
> > On Wed, 2014-10-22 at 15:18 +0200, Matthias Brugger wrote:
> >> 2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
> >> > +
> >> > +if ARCH_MEDIATEK
> >> > +
> >> > +config MACH_MT6589
> >> > +       bool "MediaTek MT6589 SoCs support"
> >> > +       default ARCH_MEDIATEK
> >> > +
> >> > +config MACH_MT8127
> >> > +       bool "MediaTek MT8127 SoCs support"
> >> > +       default ARCH_MEDIATEK
> >> > +
> >> > +config MACH_MT8135
> >> > +       bool "MediaTek MT8135 SoCs support"
> >> > +       default ARCH_MEDIATEK
> >> > +
> >> > +endif
> >>
> >> MACH_MTxxxx are not used nowhere, please remove them.
> >
> > Yes, they are not used in this series yet.
> >
> > MACH_MT8135 was used in mt8135 pinctrl driver [1] and will be used in
> > mt8135 clk driver we are about to send. I don't want to create false
> > dependency between these 2 series so I put it here.
> > Do you prefer add them when they are first used?
> 
> Yes please add them, when they are first used.
> Today I had a look on the pinctrl patches you mentioned. It looks to
> me as if the config is not needed in the series.

OK, I'll remove these in next version.

Joe.C

> 
> Thanks,
> Matthias
> 
> [0] http://thread.gmane.org/gmane.linux.ports.arm.kernel/358505
> 
> >
> > Joe.C
> >
> > [1]
> > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-September/289288.html
> >
> >
> 
> 
> 

[PATCH v4 8/8] ARM: mediatek: Fix description for mediatek SoCs

[Yingjoe Chen]

From: "Joe.C" <yingjoe.chen@mediatek.com>

We support more MediaTek SoCs now, update the description.

Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
---
 arch/arm/mach-mediatek/Kconfig | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-mediatek/Kconfig
b/arch/arm/mach-mediatek/Kconfig
index 2c043a2..f73f588 100644
--- a/arch/arm/mach-mediatek/Kconfig
+++ b/arch/arm/mach-mediatek/Kconfig
@@ -1,6 +1,6 @@
 config ARCH_MEDIATEK
-	bool "Mediatek MT6589 SoC" if ARCH_MULTI_V7
+	bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
 	select ARM_GIC
 	select MTK_TIMER
 	help
-	  Support for Mediatek Cortex-A7 Quad-Core-SoC MT6589.
+	  Support for Mediatek MT65xx & MT81xx SoCs
-- 
1.8.1.1.dirty

Re: [PATCH v4 8/8] ARM: mediatek: Fix description for mediatek SoCs

[Yingjoe Chen]

Hi Matthias,

Is this series + this new 8/8 patch OK?
Anything else that I should change?

Joe.C

On Fri, 2014-10-24 at 13:37 +0800, Yingjoe Chen wrote:
> From: "Joe.C" <yingjoe.chen@mediatek.com>
> 
> We support more MediaTek SoCs now, update the description.
> 
> Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
> ---
>  arch/arm/mach-mediatek/Kconfig | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/mach-mediatek/Kconfig
> b/arch/arm/mach-mediatek/Kconfig
> index 2c043a2..f73f588 100644
> --- a/arch/arm/mach-mediatek/Kconfig
> +++ b/arch/arm/mach-mediatek/Kconfig
> @@ -1,6 +1,6 @@
>  config ARCH_MEDIATEK
> -	bool "Mediatek MT6589 SoC" if ARCH_MULTI_V7
> +	bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
>  	select ARM_GIC
>  	select MTK_TIMER
>  	help
> -	  Support for Mediatek Cortex-A7 Quad-Core-SoC MT6589.
> +	  Support for Mediatek MT65xx & MT81xx SoCs

Re: [PATCH v4 8/8] ARM: mediatek: Fix description for mediatek SoCs

[Matthias Brugger]

Hi Joe,

2014-10-31 2:37 GMT+01:00 Yingjoe Chen <yingjoe.chen@mediatek.com>:
> Hi Matthias,
>
> Is this series + this new 8/8 patch OK?
> Anything else that I should change?
>

I checked the patches on my mt8135 board and they work for me. So from
my site everything fine.

I added the patches to my tree [0] branches v3.19-next/soc and v3.19-next/dts
I made a small change to the commit message of patch 8 and I will try
to send the pull request asap.

Thanks,
Matthias

[0] https://github.com/mbgg/linux-mediatek

> Joe.C
>
> On Fri, 2014-10-24 at 13:37 +0800, Yingjoe Chen wrote:
>> From: "Joe.C" <yingjoe.chen@mediatek.com>
>>
>> We support more MediaTek SoCs now, update the description.
>>
>> Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
>> ---
>>  arch/arm/mach-mediatek/Kconfig | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/mach-mediatek/Kconfig
>> b/arch/arm/mach-mediatek/Kconfig
>> index 2c043a2..f73f588 100644
>> --- a/arch/arm/mach-mediatek/Kconfig
>> +++ b/arch/arm/mach-mediatek/Kconfig
>> @@ -1,6 +1,6 @@
>>  config ARCH_MEDIATEK
>> -     bool "Mediatek MT6589 SoC" if ARCH_MULTI_V7
>> +     bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
>>       select ARM_GIC
>>       select MTK_TIMER
>>       help
>> -       Support for Mediatek Cortex-A7 Quad-Core-SoC MT6589.
>> +       Support for Mediatek MT65xx & MT81xx SoCs
>
>
>



-- 
motzblog.wordpress.com

Re: [PATCH v4 8/8] ARM: mediatek: Fix description for mediatek SoCs

[Matthias Brugger]

2014-10-31 15:53 GMT+01:00 Matthias Brugger <matthias.bgg@gmail.com>:
> Hi Joe,
>
> 2014-10-31 2:37 GMT+01:00 Yingjoe Chen <yingjoe.chen@mediatek.com>:
>> Hi Matthias,
>>
>> Is this series + this new 8/8 patch OK?
>> Anything else that I should change?
>>
>
> I checked the patches on my mt8135 board and they work for me. So from
> my site everything fine.

I just had another look on them and I think they are not correct,
please see my comments in the other mail.

>
> I added the patches to my tree [0] branches v3.19-next/soc and v3.19-next/dts
> I made a small change to the commit message of patch 8 and I will try
> to send the pull request asap.
>
> Thanks,
> Matthias
>
> [0] https://github.com/mbgg/linux-mediatek
>
>> Joe.C
>>
>> On Fri, 2014-10-24 at 13:37 +0800, Yingjoe Chen wrote:
>>> From: "Joe.C" <yingjoe.chen@mediatek.com>
>>>
>>> We support more MediaTek SoCs now, update the description.
>>>
>>> Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
>>> ---
>>>  arch/arm/mach-mediatek/Kconfig | 4 ++--
>>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-mediatek/Kconfig
>>> b/arch/arm/mach-mediatek/Kconfig
>>> index 2c043a2..f73f588 100644
>>> --- a/arch/arm/mach-mediatek/Kconfig
>>> +++ b/arch/arm/mach-mediatek/Kconfig
>>> @@ -1,6 +1,6 @@
>>>  config ARCH_MEDIATEK
>>> -     bool "Mediatek MT6589 SoC" if ARCH_MULTI_V7
>>> +     bool "Mediatek MT65xx & MT81xx SoC" if ARCH_MULTI_V7
>>>       select ARM_GIC
>>>       select MTK_TIMER
>>>       help
>>> -       Support for Mediatek Cortex-A7 Quad-Core-SoC MT6589.
>>> +       Support for Mediatek MT65xx & MT81xx SoCs
>>
>>
>>
>
>
>
> --
> motzblog.wordpress.com



-- 
motzblog.wordpress.com

Re: [PATCH v4 1/8] ARM: mediatek: Add basic support for mt8127

[Matthias Brugger]

2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
> From: "Joe.C" <yingjoe.chen@mediatek.com>
>
> This adds a basic dtsi for MT8127 SoC.
>
> Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
> ---
>  arch/arm/boot/dts/mt8127.dtsi     | 93 +++++++++++++++++++++++++++++++++++++++
>  arch/arm/mach-mediatek/mediatek.c |  1 +
>  2 files changed, 94 insertions(+)
>  create mode 100644 arch/arm/boot/dts/mt8127.dtsi
>
> diff --git a/arch/arm/boot/dts/mt8127.dtsi b/arch/arm/boot/dts/mt8127.dtsi
> new file mode 100644
> index 0000000..25c9f69
> --- /dev/null
> +++ b/arch/arm/boot/dts/mt8127.dtsi
> @@ -0,0 +1,93 @@
> +/*
> + * Copyright (c) 2014 MediaTek Inc.
> + * Author: Joe.C <yingjoe.chen@mediatek.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include "skeleton64.dtsi"

Cortex a7 is 32 bits, right? So why do you use skeleton64.dtsi?

> +
> +/ {
> +       compatible = "mediatek,mt8127";
> +       interrupt-parent = <&gic>;
> +
> +       cpus {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +
> +               cpu@0 {
> +                       device_type = "cpu";
> +                       compatible = "arm,cortex-a7";
> +                       reg = <0x0>;
> +               };
> +               cpu@1 {
> +                       device_type = "cpu";
> +                       compatible = "arm,cortex-a7";
> +                       reg = <0x1>;
> +               };
> +               cpu@2 {
> +                       device_type = "cpu";
> +                       compatible = "arm,cortex-a7";
> +                       reg = <0x2>;
> +               };
> +               cpu@3 {
> +                       device_type = "cpu";
> +                       compatible = "arm,cortex-a7";
> +                       reg = <0x3>;
> +               };
> +
> +       };
> +
> +       clocks {
> +               #address-cells = <2>;
> +               #size-cells = <2>;
> +               compatible = "simple-bus";
> +               ranges;
> +
> +               system_clk: dummy13m {
> +                       compatible = "fixed-clock";
> +                       clock-frequency = <13000000>;
> +                       #clock-cells = <0>;
> +               };
> +
> +               rtc_clk: dummy32k {
> +                       compatible = "fixed-clock";
> +                       clock-frequency = <32000>;
> +                       #clock-cells = <0>;
> +               };
> +       };
> +
> +       soc {
> +               #address-cells = <2>;
> +               #size-cells = <2>;
> +               compatible = "simple-bus";
> +               ranges;
> +
> +               timer: timer@10008000 {
> +                       compatible = "mediatek,mt8127-timer", "mediatek,mt6577-timer";
> +                       reg = <0 0x10008000 0 0x80>;

This should be "reg = <0x10008000 0x80>;" right?
Same in mt8135.dtsi

> +                       interrupts = <GIC_SPI 112 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks = <&system_clk>, <&rtc_clk>;
> +                       clock-names = "system-clk", "rtc-clk";
> +               };
> +
> +               gic: interrupt-controller@10211000 {
> +                       compatible = "arm,cortex-a7-gic";
> +                       interrupt-controller;
> +                       #interrupt-cells = <3>;
> +                       reg = <0 0x10211000 0 0x1000>,
> +                             <0 0x10212000 0 0x1000>,
> +                             <0 0x10214000 0 0x2000>,
> +                             <0 0x10216000 0 0x2000>;
> +               };
> +       };
> +};
> diff --git a/arch/arm/mach-mediatek/mediatek.c b/arch/arm/mach-mediatek/mediatek.c
> index f2acf07..7f478ce 100644
> --- a/arch/arm/mach-mediatek/mediatek.c
> +++ b/arch/arm/mach-mediatek/mediatek.c
> @@ -19,6 +19,7 @@
>
>  static const char * const mediatek_board_dt_compat[] = {
>         "mediatek,mt6589",
> +       "mediatek,mt8127",
>         NULL,
>  };
>
> --
> 1.8.1.1.dirty
>



-- 
motzblog.wordpress.com

Re: [PATCH v4 2/8] ARM: mediatek: add dts for 8127 Moose board

[Matthias Brugger]

2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
> From: "Joe.C" <yingjoe.chen@mediatek.com>
>
> Moose is a tablet evalutation board based on MT8127 SoC.
>
> Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
> ---
>  arch/arm/boot/dts/mt8127-moose.dts | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 arch/arm/boot/dts/mt8127-moose.dts
>
> diff --git a/arch/arm/boot/dts/mt8127-moose.dts b/arch/arm/boot/dts/mt8127-moose.dts
> new file mode 100644
> index 0000000..602e2f0
> --- /dev/null
> +++ b/arch/arm/boot/dts/mt8127-moose.dts
> @@ -0,0 +1,24 @@
> +/*
> + * Copyright (c) 2014 MediaTek Inc.
> + * Author: Joe.C <yingjoe.chen@mediatek.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +/dts-v1/;
> +#include "mt8127.dtsi"
> +
> +/ {
> +       model = "mediatek,mt8127-moose", "mediatek,mt8127";

The model should be a string that identifies the board, e.g. "Moose".
Please add the compatible property.

> +
> +       memory {
> +               reg = <0 0x80000000 0 0x40000000>;

See comment on mt8127 register definitions.

> +       };
> +};
> --
> 1.8.1.1.dirty
>



-- 
motzblog.wordpress.com

Re: [PATCH v4 3/8] ARM: mediatek: Add basic support for mt8135

[Matthias Brugger]

2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
> From: "Joe.C" <yingjoe.chen@mediatek.com>
>
> This adds a basic dtsi for MT8135 based SoC.
>
> Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
> ---
>  arch/arm/boot/dts/mt8135.dtsi     | 115 ++++++++++++++++++++++++++++++++++++++
>  arch/arm/mach-mediatek/mediatek.c |   1 +
>  2 files changed, 116 insertions(+)
>  create mode 100644 arch/arm/boot/dts/mt8135.dtsi
>
> diff --git a/arch/arm/boot/dts/mt8135.dtsi b/arch/arm/boot/dts/mt8135.dtsi
> new file mode 100644
> index 0000000..90a56ad
> --- /dev/null
> +++ b/arch/arm/boot/dts/mt8135.dtsi
> @@ -0,0 +1,115 @@
> +/*
> + * Copyright (c) 2014 MediaTek Inc.
> + * Author: Joe.C <yingjoe.chen@mediatek.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +#include <dt-bindings/interrupt-controller/irq.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include "skeleton64.dtsi"

Same here A15 is 32 bits.

> +
> +/ {
> +       compatible = "mediatek,mt8135";
> +       interrupt-parent = <&gic>;
> +
> +       cpu-map {
> +               cluster0 {
> +                       core0 {
> +                               cpu = <&cpu0>;
> +                       };
> +                       core1 {
> +                               cpu = <&cpu1>;
> +                       };
> +               };
> +
> +               cluster1 {
> +                       core0 {
> +                               cpu = <&cpu2>;
> +                       };
> +                       core1 {
> +                               cpu = <&cpu3>;
> +                       };
> +               };
> +       };
> +
> +       cpus {
> +               #address-cells = <1>;
> +               #size-cells = <0>;
> +
> +               cpu0: cpu@0 {
> +                       device_type = "cpu";
> +                       compatible = "arm,cortex-a7";
> +                       reg = <0x000>;
> +               };
> +
> +               cpu1: cpu@1 {
> +                       device_type = "cpu";
> +                       compatible = "arm,cortex-a7";
> +                       reg = <0x001>;
> +               };
> +
> +               cpu2: cpu@100 {
> +                       device_type = "cpu";
> +                       compatible = "arm,cortex-a15";
> +                       reg = <0x100>;
> +               };
> +
> +               cpu3: cpu@101 {
> +                       device_type = "cpu";
> +                       compatible = "arm,cortex-a15";
> +                       reg = <0x101>;
> +               };
> +       };
> +
> +       clocks {
> +               #address-cells = <2>;
> +               #size-cells = <2>;
> +               compatible = "simple-bus";
> +               ranges;
> +
> +               system_clk: dummy13m {
> +                       compatible = "fixed-clock";
> +                       clock-frequency = <13000000>;
> +                       #clock-cells = <0>;
> +               };
> +
> +               rtc_clk: dummy32k {
> +                       compatible = "fixed-clock";
> +                       clock-frequency = <32000>;
> +                       #clock-cells = <0>;
> +               };
> +       };
> +
> +       soc {
> +               #address-cells = <2>;
> +               #size-cells = <2>;
> +               compatible = "simple-bus";
> +               ranges;
> +
> +               timer: timer@10008000 {
> +                       compatible = "mediatek,mt8135-timer", "mediatek,mt6577-timer";
> +                       reg = <0 0x10008000 0 0x80>;
> +                       interrupts = <GIC_SPI 113 IRQ_TYPE_LEVEL_HIGH>;
> +                       clocks = <&system_clk>, <&rtc_clk>;
> +                       clock-names = "system-clk", "rtc-clk";
> +               };
> +
> +               gic: interrupt-controller@10211000 {
> +                       compatible = "arm,cortex-a15-gic";
> +                       interrupt-controller;
> +                       #interrupt-cells = <3>;
> +                       reg = <0 0x10211000 0 0x1000>,
> +                             <0 0x10212000 0 0x1000>,
> +                             <0 0x10214000 0 0x2000>,
> +                             <0 0x10216000 0 0x2000>;
> +               };
> +       };
> +};
> diff --git a/arch/arm/mach-mediatek/mediatek.c b/arch/arm/mach-mediatek/mediatek.c
> index 7f478ce..48051a2 100644
> --- a/arch/arm/mach-mediatek/mediatek.c
> +++ b/arch/arm/mach-mediatek/mediatek.c
> @@ -20,6 +20,7 @@
>  static const char * const mediatek_board_dt_compat[] = {
>         "mediatek,mt6589",
>         "mediatek,mt8127",
> +       "mediatek,mt8135",
>         NULL,
>  };
>
> --
> 1.8.1.1.dirty
>



-- 
motzblog.wordpress.com

Re: [PATCH v4 4/8] ARM: mediatek: add dts for MT8135 evaluation board.

[Matthias Brugger]

2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
> From: "Joe.C" <yingjoe.chen@mediatek.com>
>
> Evbp1 is a tablet evaluation board based on MT8135 SoC.
>
> Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
> ---
>  arch/arm/boot/dts/mt8135-evbp1.dts | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>  create mode 100644 arch/arm/boot/dts/mt8135-evbp1.dts
>
> diff --git a/arch/arm/boot/dts/mt8135-evbp1.dts b/arch/arm/boot/dts/mt8135-evbp1.dts
> new file mode 100644
> index 0000000..cba80b8
> --- /dev/null
> +++ b/arch/arm/boot/dts/mt8135-evbp1.dts
> @@ -0,0 +1,24 @@
> +/*
> + * Copyright (c) 2014 MediaTek Inc.
> + * Author: Joe.C <yingjoe.chen@mediatek.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + */
> +
> +/dts-v1/;
> +#include "mt8135.dtsi"
> +
> +/ {
> +       model = "mediatek,mt8135-evbp1", "mediatek,mt8135";

Same here, you switched model and compatible property. Please provide
both of them.

> +
> +       memory {
> +               reg = <0 0x80000000 0 0x40000000>;
> +       };
> +};
> --
> 1.8.1.1.dirty
>



-- 
motzblog.wordpress.com

Re: [PATCH v4 2/8] ARM: mediatek: add dts for 8127 Moose board

[Yingjoe Chen]

On Mon, 2014-11-03 at 18:55 +0100, Matthias Brugger wrote:
> 2014-10-22 12:29 GMT+02:00 Joe.C <yingjoe.chen@mediatek.com>:
> > From: "Joe.C" <yingjoe.chen@mediatek.com>
> >
> > Moose is a tablet evalutation board based on MT8127 SoC.
> >
> > Signed-off-by: Joe.C <yingjoe.chen@mediatek.com>
> > ---
> >  arch/arm/boot/dts/mt8127-moose.dts | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> >  create mode 100644 arch/arm/boot/dts/mt8127-moose.dts
> >
> > diff --git a/arch/arm/boot/dts/mt8127-moose.dts b/arch/arm/boot/dts/mt8127-moose.dts
> > new file mode 100644
> > index 0000000..602e2f0
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/mt8127-moose.dts
> > @@ -0,0 +1,24 @@
> > +/*
> > + * Copyright (c) 2014 MediaTek Inc.
> > + * Author: Joe.C <yingjoe.chen@mediatek.com>
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + */
> > +
> > +/dts-v1/;
> > +#include "mt8127.dtsi"
> > +
> > +/ {
> > +       model = "mediatek,mt8127-moose", "mediatek,mt8127";
> 
> The model should be a string that identifies the board, e.g. "Moose".
> Please add the compatible property.

Thanks for catching this. I just note we have warning on this line.
Will fix in next version.

Joe.C

Re: [PATCH v4 1/8] ARM: mediatek: Add basic support for mt8127

[Arnd Bergmann]

On Tuesday 04 November 2014 14:36:45 HC Yen wrote:
> > > +
> > > +#include <dt-bindings/interrupt-controller/irq.h>
> > > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> > > +#include "skeleton64.dtsi"
> > 
> > Cortex a7 is 32 bits, right? So why do you use skeleton64.dtsi?
> 
> Cortex-A7 is 32-bit, but that doesn't mean it can only have 32-bit
> physical address.  With LPAE enabled, we can have physical address more
> than 32 bits.
> 
> The main difference between "skeleton64.dtsi" and "skeleton.dtsi" is
> "#address-cells" property set to 2.  Although there are few sources
> using "skeleton64.dtsi", some of them write "#address-cells = <2>"
> directly in order to have 64-bit address space.  ARM's TC2 reference
> platform (vexpress-v2p-ca15_a7.dts) is an example.
> 
> Some of MediaTek ARMv7 SoCs support address space larger than 4GB. It
> will be convenient to share the sources if we all use 64-bit device
> tree.

Right, in general, I'd use #address-cells=<2> for Cortex-A7/A15/A17.

	Arnd

Re: [PATCH v4 1/8] ARM: mediatek: Add basic support for mt8127

[Matthias Brugger]

2014-11-04 8:39 GMT+01:00 Arnd Bergmann <arnd@arndb.de>:
> On Tuesday 04 November 2014 14:36:45 HC Yen wrote:
>> > > +
>> > > +#include <dt-bindings/interrupt-controller/irq.h>
>> > > +#include <dt-bindings/interrupt-controller/arm-gic.h>
>> > > +#include "skeleton64.dtsi"
>> >
>> > Cortex a7 is 32 bits, right? So why do you use skeleton64.dtsi?
>>
>> Cortex-A7 is 32-bit, but that doesn't mean it can only have 32-bit
>> physical address.  With LPAE enabled, we can have physical address more
>> than 32 bits.
>>
>> The main difference between "skeleton64.dtsi" and "skeleton.dtsi" is
>> "#address-cells" property set to 2.  Although there are few sources
>> using "skeleton64.dtsi", some of them write "#address-cells = <2>"
>> directly in order to have 64-bit address space.  ARM's TC2 reference
>> platform (vexpress-v2p-ca15_a7.dts) is an example.
>>
>> Some of MediaTek ARMv7 SoCs support address space larger than 4GB. It
>> will be convenient to share the sources if we all use 64-bit device
>> tree.
>
> Right, in general, I'd use #address-cells=<2> for Cortex-A7/A15/A17.

Alright, thanks for clarification. So we should use skeleton64.dtsi
for mt6589 as well, right?

>
>         Arnd



-- 
motzblog.wordpress.com

Re: [PATCH v4 1/8] ARM: mediatek: Add basic support for mt8127

[Arnd Bergmann]

On Tuesday 04 November 2014 09:36:39 Matthias Brugger wrote:
> 2014-11-04 8:39 GMT+01:00 Arnd Bergmann <arnd@arndb.de>:
> > On Tuesday 04 November 2014 14:36:45 HC Yen wrote:
> >> > > +
> >> > > +#include <dt-bindings/interrupt-controller/irq.h>
> >> > > +#include <dt-bindings/interrupt-controller/arm-gic.h>
> >> > > +#include "skeleton64.dtsi"
> >> >
> >> > Cortex a7 is 32 bits, right? So why do you use skeleton64.dtsi?
> >>
> >> Cortex-A7 is 32-bit, but that doesn't mean it can only have 32-bit
> >> physical address.  With LPAE enabled, we can have physical address more
> >> than 32 bits.
> >>
> >> The main difference between "skeleton64.dtsi" and "skeleton.dtsi" is
> >> "#address-cells" property set to 2.  Although there are few sources
> >> using "skeleton64.dtsi", some of them write "#address-cells = <2>"
> >> directly in order to have 64-bit address space.  ARM's TC2 reference
> >> platform (vexpress-v2p-ca15_a7.dts) is an example.
> >>
> >> Some of MediaTek ARMv7 SoCs support address space larger than 4GB. It
> >> will be convenient to share the sources if we all use 64-bit device
> >> tree.
> >
> > Right, in general, I'd use #address-cells=<2> for Cortex-A7/A15/A17.
> 
> Alright, thanks for clarification. So we should use skeleton64.dtsi
> for mt6589 as well, right?

If the chip is capable of accessing memory or registers higher than 4GB
physical address, then you should, yes.

If the SoC has limitations that mean you can't have higher addresses
anyway, then either way is fine, no need to change it.

	Arnd