* [PATCH 1/2] pinctrl: tegra: Make PINCTRL_TEGRA select PINMUX && PINCONF
@ 2012-11-11 2:21 Axel Lin
2012-11-11 2:22 ` [PATCH 2/2] pinctrl: mxs: Make PINCTRL_MXS " Axel Lin
2012-11-12 16:14 ` [PATCH 1/2] pinctrl: tegra: Make PINCTRL_TEGRA " Stephen Warren
0 siblings, 2 replies; 4+ messages in thread
From: Axel Lin @ 2012-11-11 2:21 UTC (permalink / raw)
To: Linus Walleij; +Cc: Stephen Warren, linux-kernel
Then we can remove "select PINMUX && PINCONF" from PINCTRL_TEGRA{20,30}.
This simplifies the dependency.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/Kconfig | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index 6d5a50b..fc0f49a 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -157,18 +157,16 @@ config PINCTRL_SIRF
select PINMUX
config PINCTRL_TEGRA
+ select PINMUX
+ select PINCONF
bool
config PINCTRL_TEGRA20
bool
- select PINMUX
- select PINCONF
select PINCTRL_TEGRA
config PINCTRL_TEGRA30
bool
- select PINMUX
- select PINCONF
select PINCTRL_TEGRA
config PINCTRL_U300
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] pinctrl: mxs: Make PINCTRL_MXS select PINMUX && PINCONF
2012-11-11 2:21 [PATCH 1/2] pinctrl: tegra: Make PINCTRL_TEGRA select PINMUX && PINCONF Axel Lin
@ 2012-11-11 2:22 ` Axel Lin
2012-11-12 1:46 ` Shawn Guo
2012-11-12 16:14 ` [PATCH 1/2] pinctrl: tegra: Make PINCTRL_TEGRA " Stephen Warren
1 sibling, 1 reply; 4+ messages in thread
From: Axel Lin @ 2012-11-11 2:22 UTC (permalink / raw)
To: Linus Walleij
Cc: Shawn Guo, Dong Aisheng, Devendra Naga, Stephen Warren,
linux-kernel
Then we can remove "select PINMUX && PINCONF" from PINCTRL_IMX{23,28}.
This simplifies the dependency.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/pinctrl/Kconfig | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index fc0f49a..d5c9431 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -99,18 +99,16 @@ config PINCTRL_MMP2
select PINCONF
config PINCTRL_MXS
+ select PINMUX
+ select PINCONF
bool
config PINCTRL_IMX23
bool
- select PINMUX
- select PINCONF
select PINCTRL_MXS
config PINCTRL_IMX28
bool
- select PINMUX
- select PINCONF
select PINCTRL_MXS
config PINCTRL_NOMADIK
--
1.7.9.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] pinctrl: mxs: Make PINCTRL_MXS select PINMUX && PINCONF
2012-11-11 2:22 ` [PATCH 2/2] pinctrl: mxs: Make PINCTRL_MXS " Axel Lin
@ 2012-11-12 1:46 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2012-11-12 1:46 UTC (permalink / raw)
To: Axel Lin
Cc: Linus Walleij, Dong Aisheng, Devendra Naga, Stephen Warren,
linux-kernel
On Sun, Nov 11, 2012 at 10:22:42AM +0800, Axel Lin wrote:
> Then we can remove "select PINMUX && PINCONF" from PINCTRL_IMX{23,28}.
> This simplifies the dependency.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/pinctrl/Kconfig | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index fc0f49a..d5c9431 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -99,18 +99,16 @@ config PINCTRL_MMP2
> select PINCONF
>
> config PINCTRL_MXS
> + select PINMUX
> + select PINCONF
Better have them after 'bool' below, otherwise,
Acked-by: Shawn Guo <shawn.guo@linaro.org>
> bool
>
> config PINCTRL_IMX23
> bool
> - select PINMUX
> - select PINCONF
> select PINCTRL_MXS
>
> config PINCTRL_IMX28
> bool
> - select PINMUX
> - select PINCONF
> select PINCTRL_MXS
>
> config PINCTRL_NOMADIK
> --
> 1.7.9.5
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] pinctrl: tegra: Make PINCTRL_TEGRA select PINMUX && PINCONF
2012-11-11 2:21 [PATCH 1/2] pinctrl: tegra: Make PINCTRL_TEGRA select PINMUX && PINCONF Axel Lin
2012-11-11 2:22 ` [PATCH 2/2] pinctrl: mxs: Make PINCTRL_MXS " Axel Lin
@ 2012-11-12 16:14 ` Stephen Warren
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Warren @ 2012-11-12 16:14 UTC (permalink / raw)
To: Axel Lin; +Cc: Linus Walleij, Stephen Warren, linux-kernel
On 11/10/2012 07:21 PM, Axel Lin wrote:
> Then we can remove "select PINMUX && PINCONF" from PINCTRL_TEGRA{20,30}.
> This simplifies the dependency.
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> config PINCTRL_TEGRA
> + select PINMUX
> + select PINCONF
> bool
With the same ordering comment as Shawn gave,
Acked-by: Stephen Warren <swarren@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-12 16:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-11 2:21 [PATCH 1/2] pinctrl: tegra: Make PINCTRL_TEGRA select PINMUX && PINCONF Axel Lin
2012-11-11 2:22 ` [PATCH 2/2] pinctrl: mxs: Make PINCTRL_MXS " Axel Lin
2012-11-12 1:46 ` Shawn Guo
2012-11-12 16:14 ` [PATCH 1/2] pinctrl: tegra: Make PINCTRL_TEGRA " Stephen Warren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox