* [PATCH] gpio: samsung: Add terminating entry for exynos_pinctrl_ids
@ 2012-12-10 1:35 Axel Lin
2012-12-10 10:13 ` Linus Walleij
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2012-12-10 1:35 UTC (permalink / raw)
To: Grant Likely, Linus Walleij
Cc: Kukjin Kim, Thomas Abraham, Tomasz Figa, linux-kernel
The of_device_id table is supposed to be zero-terminated.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
drivers/gpio/gpio-samsung.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
index 01f7fe9..9e251be 100644
--- a/drivers/gpio/gpio-samsung.c
+++ b/drivers/gpio/gpio-samsung.c
@@ -3026,6 +3026,7 @@ static __init int samsung_gpiolib_init(void)
static const struct of_device_id exynos_pinctrl_ids[] = {
{ .compatible = "samsung,pinctrl-exynos4210", },
{ .compatible = "samsung,pinctrl-exynos4x12", },
+ { }
};
for_each_matching_node(pctrl_np, exynos_pinctrl_ids)
if (pctrl_np && of_device_is_available(pctrl_np))
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: samsung: Add terminating entry for exynos_pinctrl_ids
2012-12-10 1:35 [PATCH] gpio: samsung: Add terminating entry for exynos_pinctrl_ids Axel Lin
@ 2012-12-10 10:13 ` Linus Walleij
2012-12-10 22:10 ` Grant Likely
0 siblings, 1 reply; 3+ messages in thread
From: Linus Walleij @ 2012-12-10 10:13 UTC (permalink / raw)
To: Axel Lin
Cc: Grant Likely, Kukjin Kim, Thomas Abraham, Tomasz Figa,
linux-kernel
On Mon, Dec 10, 2012 at 2:35 AM, Axel Lin <axel.lin@ingics.com> wrote:
> The of_device_id table is supposed to be zero-terminated.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/gpio/gpio-samsung.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index 01f7fe9..9e251be 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -3026,6 +3026,7 @@ static __init int samsung_gpiolib_init(void)
> static const struct of_device_id exynos_pinctrl_ids[] = {
> { .compatible = "samsung,pinctrl-exynos4210", },
> { .compatible = "samsung,pinctrl-exynos4x12", },
> + { }
Wasn't somebody complaining that this was unnecessary recently?
Ohwell, I'll let the Samsung people comment first...
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gpio: samsung: Add terminating entry for exynos_pinctrl_ids
2012-12-10 10:13 ` Linus Walleij
@ 2012-12-10 22:10 ` Grant Likely
0 siblings, 0 replies; 3+ messages in thread
From: Grant Likely @ 2012-12-10 22:10 UTC (permalink / raw)
To: Linus Walleij, Axel Lin
Cc: Kukjin Kim, Thomas Abraham, Tomasz Figa, linux-kernel
On Mon, 10 Dec 2012 11:13:06 +0100, Linus Walleij <linus.walleij@linaro.org> wrote:
> On Mon, Dec 10, 2012 at 2:35 AM, Axel Lin <axel.lin@ingics.com> wrote:
>
> > The of_device_id table is supposed to be zero-terminated.
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > ---
> > drivers/gpio/gpio-samsung.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> > index 01f7fe9..9e251be 100644
> > --- a/drivers/gpio/gpio-samsung.c
> > +++ b/drivers/gpio/gpio-samsung.c
> > @@ -3026,6 +3026,7 @@ static __init int samsung_gpiolib_init(void)
> > static const struct of_device_id exynos_pinctrl_ids[] = {
> > { .compatible = "samsung,pinctrl-exynos4210", },
> > { .compatible = "samsung,pinctrl-exynos4x12", },
> > + { }
>
> Wasn't somebody complaining that this was unnecessary recently?
>
> Ohwell, I'll let the Samsung people comment first...
And this doesn't apply on my gpio/next branch. I assume it applies
somewhere else so I'll ignore for now. :-)
Acked-by: Grant Likely <grant.likely@secretlab.ca>
g.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-12-10 22:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-12-10 1:35 [PATCH] gpio: samsung: Add terminating entry for exynos_pinctrl_ids Axel Lin
2012-12-10 10:13 ` Linus Walleij
2012-12-10 22:10 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox