From: Joe Perches <joe@perches.com>
To: David Howells <dhowells@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Alexander Graf <agraf@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Warn on #include <uapi/...
Date: Tue, 18 Dec 2012 11:52:48 -0800 [thread overview]
Message-ID: <1355860368.30366.33.camel@joe-AO722> (raw)
In-Reply-To: <12373.1355858223@warthog.procyon.org.uk>
On Tue, 2012-12-18 at 19:17 +0000, David Howells wrote:
> Joe Perches <joe@perches.com> wrote:
>
> > + if ($path =~ "^uapi/") {
> > + ERROR("UAPI_INCLUDE",
> > + "#include should not start with uapi/\n" . $herecurr);
> > }
>
> But does this limit the check only to headers in uapi/ directories?
No. I'm confused, I believe your example was:
arch/powerpc/include/asm/kvm_para.h
@@ -16,77 +16,11 @@
*
* Authors: Hollis Blanchard <hollisb@us.ibm.com>
*/
-
#ifndef __POWERPC_KVM_PARA_H__
#define __POWERPC_KVM_PARA_H__
-#include <linux/types.h>
+#include <uapi/asm/kvm_para.h>
---------------
What do you want this to check?
next prev parent reply other threads:[~2012-12-18 19:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 14:23 checkpatch.pl should check UAPI headers don't #include <uapi/...> David Howells
2012-12-18 17:53 ` [PATCH] checkpatch: Warn on #include <uapi/ Joe Perches
2012-12-18 19:17 ` David Howells
2012-12-18 19:52 ` Joe Perches [this message]
2012-12-18 20:35 ` David Howells
2012-12-18 22:14 ` Joe Perches
2012-12-18 22:35 ` David Howells
2012-12-19 1:30 ` [PATCH V2] checkpatch: Warn on uapi #includes that " Joe Perches
2012-12-19 13:18 ` David Howells
2012-12-19 13:31 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355860368.30366.33.camel@joe-AO722 \
--to=joe@perches.com \
--cc=agraf@suse.de \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox