public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Joe Perches <joe@perches.com>, Marcelo Tosatti <mtosatti@redhat.com>
Cc: dhowells@redhat.com, Alexander Graf <agraf@suse.de>,
	linux-kernel@vger.kernel.org
Subject: checkpatch.pl should check UAPI headers don't #include <uapi/...>
Date: Tue, 18 Dec 2012 14:23:30 +0000	[thread overview]
Message-ID: <6433.1355840610@warthog.procyon.org.uk> (raw)


Hi Joe,

Can you make checkpatch.pl check that lines added to UAPI headers don't have
the form:

	#include <uapi/...>

or:

	#include "uapi/..."

Such as these should be regarded as errors as they will likely break userspace
which shouldn't get to see any uapi/ directories.

An example of this is in:

	commit 19bf7f8ac3f8131100027281c495dbbe00cd5ae0
	Merge: 787c57c 35fd3dc
	Author: Marcelo Tosatti <mtosatti@redhat.com>
	Date:   Mon Oct 29 19:15:32 2012 -0200

where during the conflict resolution, the following change was made:

	- #include <asm/epapr_hcalls.h>
	++#include <uapi/asm/epapr_hcalls.h>

I recognise that checkpatch.pl might not have helped in this case since it
isn't normally applied to merged as far as I know.

Thanks,
David

             reply	other threads:[~2012-12-18 14:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-18 14:23 David Howells [this message]
2012-12-18 17:53 ` [PATCH] checkpatch: Warn on #include <uapi/ Joe Perches
2012-12-18 19:17   ` David Howells
2012-12-18 19:52     ` Joe Perches
2012-12-18 20:35       ` David Howells
2012-12-18 22:14         ` Joe Perches
2012-12-18 22:35           ` David Howells
2012-12-19  1:30             ` [PATCH V2] checkpatch: Warn on uapi #includes that " Joe Perches
2012-12-19 13:18               ` David Howells
2012-12-19 13:31               ` Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6433.1355840610@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=agraf@suse.de \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox