From: Joe Perches <joe@perches.com>
To: David Howells <dhowells@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andy Whitcroft <apw@canonical.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Alexander Graf <agraf@suse.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] checkpatch: Warn on #include <uapi/...
Date: Tue, 18 Dec 2012 14:14:52 -0800 [thread overview]
Message-ID: <1355868892.3982.6.camel@joe-AO722> (raw)
In-Reply-To: <14276.1355862945@warthog.procyon.org.uk>
On Tue, 2012-12-18 at 20:35 +0000, David Howells wrote:
> Joe Perches <joe@perches.com> wrote:
[]
> > arch/powerpc/include/asm/kvm_para.h
> > ...
> > -#include <linux/types.h>
> > +#include <uapi/asm/kvm_para.h>
>
> No, that is a correct alteration.
>
> The example I gave was:
>
> - #include <asm/epapr_hcalls.h>
> ++#include <uapi/asm/epapr_hcalls.h>
>
> which is to be found in arch/powerpc/include/uapi/asm/kvm_para.h.
Just to verify, any file in any path [.../]include/uapi/...
should not itself have a line like '#include <uapi/...' ?
next prev parent reply other threads:[~2012-12-18 22:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-18 14:23 checkpatch.pl should check UAPI headers don't #include <uapi/...> David Howells
2012-12-18 17:53 ` [PATCH] checkpatch: Warn on #include <uapi/ Joe Perches
2012-12-18 19:17 ` David Howells
2012-12-18 19:52 ` Joe Perches
2012-12-18 20:35 ` David Howells
2012-12-18 22:14 ` Joe Perches [this message]
2012-12-18 22:35 ` David Howells
2012-12-19 1:30 ` [PATCH V2] checkpatch: Warn on uapi #includes that " Joe Perches
2012-12-19 13:18 ` David Howells
2012-12-19 13:31 ` Andy Whitcroft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355868892.3982.6.camel@joe-AO722 \
--to=joe@perches.com \
--cc=agraf@suse.de \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox