* [PATCH 1/1] scripts/package/Makefile: remove useless KBUILD_OUTPUT test
@ 2013-01-21 7:28 Bin Wang
2013-02-22 10:20 ` Michal Marek
0 siblings, 1 reply; 2+ messages in thread
From: Bin Wang @ 2013-01-21 7:28 UTC (permalink / raw)
To: Michal Marek, linux-kbuild, linux-kernel; +Cc: Bin Wang
The test of KBUILD_OUTPUT in "rpm-pkg rpm" target is useless.
KBUILD_OUTPUT is always empty here.
Signed-off-by: Bin Wang <wbin00@gmail.com>
---
scripts/package/Makefile | 6 ------
1 file changed, 6 deletions(-)
diff --git a/scripts/package/Makefile b/scripts/package/Makefile
index 87bf080..ba073a6 100644
--- a/scripts/package/Makefile
+++ b/scripts/package/Makefile
@@ -36,12 +36,6 @@ $(objtree)/kernel.spec: $(MKSPEC) $(srctree)/Makefile
$(CONFIG_SHELL) $(MKSPEC) > $@
rpm-pkg rpm: $(objtree)/kernel.spec FORCE
- @if test -n "$(KBUILD_OUTPUT)"; then \
- echo "Building source + binary RPM is not possible outside the"; \
- echo "kernel source tree. Don't set KBUILD_OUTPUT, or use the"; \
- echo "binrpm-pkg target instead."; \
- false; \
- fi
$(MAKE) clean
$(PREV) ln -sf $(srctree) $(KERNELPATH)
$(CONFIG_SHELL) $(srctree)/scripts/setlocalversion --save-scmversion
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] scripts/package/Makefile: remove useless KBUILD_OUTPUT test
2013-01-21 7:28 [PATCH 1/1] scripts/package/Makefile: remove useless KBUILD_OUTPUT test Bin Wang
@ 2013-02-22 10:20 ` Michal Marek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Marek @ 2013-02-22 10:20 UTC (permalink / raw)
To: Bin Wang; +Cc: linux-kbuild, linux-kernel
On Mon, Jan 21, 2013 at 03:28:05PM +0800, Bin Wang wrote:
> The test of KBUILD_OUTPUT in "rpm-pkg rpm" target is useless.
> KBUILD_OUTPUT is always empty here.
Right, but the error message is valid, make rpm-pkg does not work with
O=. So I suggest to either fix make O=... rpm-pkg, or fix the test to
compare $(srctree) and $(objtree) instead.
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-02-22 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-21 7:28 [PATCH 1/1] scripts/package/Makefile: remove useless KBUILD_OUTPUT test Bin Wang
2013-02-22 10:20 ` Michal Marek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox