* [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes
@ 2013-07-10 11:55 Andy Shevchenko
2013-07-10 11:55 ` [PATCH 1/5] pinctrl-baytrail: fix indentations Andy Shevchenko
` (5 more replies)
0 siblings, 6 replies; 14+ messages in thread
From: Andy Shevchenko @ 2013-07-10 11:55 UTC (permalink / raw)
To: Linus Walleij, linux-kernel, Mika Westerberg; +Cc: Andy Shevchenko
This is a set of small minor fixes against pinctrl-baytrail driver.
Andy Shevchenko (5):
pinctrl-baytrail: fix indentations
pinctrl-baytrail: change lvl to level
pinctrl-baytrail: remove redundant ptr variable
pinctrl-baytrail: introduce to_byt_gpio() macro
pinctrl-baytrail: fix to avoid sparse warnings
drivers/pinctrl/Kconfig | 2 +-
drivers/pinctrl/pinctrl-baytrail.c | 37 +++++++++++++++++++++----------------
2 files changed, 22 insertions(+), 17 deletions(-)
--
1.8.3.2
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 1/5] pinctrl-baytrail: fix indentations 2013-07-10 11:55 [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes Andy Shevchenko @ 2013-07-10 11:55 ` Andy Shevchenko 2013-07-22 20:47 ` Linus Walleij 2013-07-10 11:55 ` [PATCH 2/5] pinctrl-baytrail: change lvl to level Andy Shevchenko ` (4 subsequent siblings) 5 siblings, 1 reply; 14+ messages in thread From: Andy Shevchenko @ 2013-07-10 11:55 UTC (permalink / raw) To: Linus Walleij, linux-kernel, Mika Westerberg; +Cc: Andy Shevchenko There are two minor issues with indentation in the code. This patch fixes them. No functional changes. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/Kconfig | 2 +- drivers/pinctrl/pinctrl-baytrail.c | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig index 5a8ad51..bc830af 100644 --- a/drivers/pinctrl/Kconfig +++ b/drivers/pinctrl/Kconfig @@ -61,7 +61,7 @@ config PINCTRL_AT91 config PINCTRL_BAYTRAIL bool "Intel Baytrail GPIO pin control" depends on GPIOLIB && ACPI && X86 - select IRQ_DOMAIN + select IRQ_DOMAIN help driver for memory mapped GPIO functionality on Intel Baytrail platforms. Supports 3 banks with 102, 28 and 44 gpios. diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c index e9d735d..fccf72e 100644 --- a/drivers/pinctrl/pinctrl-baytrail.c +++ b/drivers/pinctrl/pinctrl-baytrail.c @@ -516,6 +516,7 @@ static int byt_gpio_remove(struct platform_device *pdev) { struct byt_gpio *vg = platform_get_drvdata(pdev); int err; + pm_runtime_disable(&pdev->dev); err = gpiochip_remove(&vg->chip); if (err) -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 1/5] pinctrl-baytrail: fix indentations 2013-07-10 11:55 ` [PATCH 1/5] pinctrl-baytrail: fix indentations Andy Shevchenko @ 2013-07-22 20:47 ` Linus Walleij 0 siblings, 0 replies; 14+ messages in thread From: Linus Walleij @ 2013-07-22 20:47 UTC (permalink / raw) To: Andy Shevchenko; +Cc: linux-kernel@vger.kernel.org, Mika Westerberg On Wed, Jul 10, 2013 at 1:55 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > There are two minor issues with indentation in the code. This patch fixes them. > No functional changes. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Patch applied. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 2/5] pinctrl-baytrail: change lvl to level 2013-07-10 11:55 [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes Andy Shevchenko 2013-07-10 11:55 ` [PATCH 1/5] pinctrl-baytrail: fix indentations Andy Shevchenko @ 2013-07-10 11:55 ` Andy Shevchenko 2013-07-10 13:42 ` [PATCH v1.5] " Andy Shevchenko 2013-07-10 11:55 ` [PATCH 3/5] pinctrl-baytrail: remove redundant ptr variable Andy Shevchenko ` (3 subsequent siblings) 5 siblings, 1 reply; 14+ messages in thread From: Andy Shevchenko @ 2013-07-10 11:55 UTC (permalink / raw) To: Linus Walleij, linux-kernel, Mika Westerberg; +Cc: Andy Shevchenko Additionally remove trailing whitespace when print triggering type. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/pinctrl-baytrail.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c index fccf72e..06ffeee 100644 --- a/drivers/pinctrl/pinctrl-baytrail.c +++ b/drivers/pinctrl/pinctrl-baytrail.c @@ -296,7 +296,7 @@ static void byt_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) conf0 & 0x7, conf0 & BYT_TRIG_NEG ? "fall " : "", conf0 & BYT_TRIG_POS ? "rise " : "", - conf0 & BYT_TRIG_LVL ? "lvl " : ""); + conf0 & BYT_TRIG_LVL ? "level" : ""); } spin_unlock_irqrestore(&vg->lock, flags); } -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v1.5] pinctrl-baytrail: change lvl to level 2013-07-10 11:55 ` [PATCH 2/5] pinctrl-baytrail: change lvl to level Andy Shevchenko @ 2013-07-10 13:42 ` Andy Shevchenko 2013-07-22 20:48 ` Linus Walleij 0 siblings, 1 reply; 14+ messages in thread From: Andy Shevchenko @ 2013-07-10 13:42 UTC (permalink / raw) To: Linus Walleij, linux-kernel, Mika Westerberg; +Cc: Andy Shevchenko Additionally remove trailing whitespace when print triggering type. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/pinctrl-baytrail.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c index fccf72e..f3d3053 100644 --- a/drivers/pinctrl/pinctrl-baytrail.c +++ b/drivers/pinctrl/pinctrl-baytrail.c @@ -294,9 +294,9 @@ static void byt_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) val & BYT_LEVEL ? "hi" : "lo", vg->range->pins[i], offs, conf0 & 0x7, - conf0 & BYT_TRIG_NEG ? "fall " : "", - conf0 & BYT_TRIG_POS ? "rise " : "", - conf0 & BYT_TRIG_LVL ? "lvl " : ""); + conf0 & BYT_TRIG_NEG ? " fall" : "", + conf0 & BYT_TRIG_POS ? " rise" : "", + conf0 & BYT_TRIG_LVL ? " level" : ""); } spin_unlock_irqrestore(&vg->lock, flags); } -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH v1.5] pinctrl-baytrail: change lvl to level 2013-07-10 13:42 ` [PATCH v1.5] " Andy Shevchenko @ 2013-07-22 20:48 ` Linus Walleij 0 siblings, 0 replies; 14+ messages in thread From: Linus Walleij @ 2013-07-22 20:48 UTC (permalink / raw) To: Andy Shevchenko; +Cc: linux-kernel@vger.kernel.org, Mika Westerberg On Wed, Jul 10, 2013 at 3:42 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Additionally remove trailing whitespace when print triggering type. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Patch applied. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 3/5] pinctrl-baytrail: remove redundant ptr variable 2013-07-10 11:55 [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes Andy Shevchenko 2013-07-10 11:55 ` [PATCH 1/5] pinctrl-baytrail: fix indentations Andy Shevchenko 2013-07-10 11:55 ` [PATCH 2/5] pinctrl-baytrail: change lvl to level Andy Shevchenko @ 2013-07-10 11:55 ` Andy Shevchenko 2013-07-22 20:49 ` Linus Walleij 2013-07-10 11:55 ` [PATCH 4/5] pinctrl-baytrail: introduce to_byt_gpio() macro Andy Shevchenko ` (2 subsequent siblings) 5 siblings, 1 reply; 14+ messages in thread From: Andy Shevchenko @ 2013-07-10 11:55 UTC (permalink / raw) To: Linus Walleij, linux-kernel, Mika Westerberg; +Cc: Andy Shevchenko There is no need to have an additional variable in byt_gpio_reg(). Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/pinctrl-baytrail.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c index 06ffeee..14a143c 100644 --- a/drivers/pinctrl/pinctrl-baytrail.c +++ b/drivers/pinctrl/pinctrl-baytrail.c @@ -135,15 +135,13 @@ static void __iomem *byt_gpio_reg(struct gpio_chip *chip, unsigned offset, { struct byt_gpio *vg = container_of(chip, struct byt_gpio, chip); u32 reg_offset; - void __iomem *ptr; if (reg == BYT_INT_STAT_REG) reg_offset = (offset / 32) * 4; else reg_offset = vg->range->pins[offset] * 16; - ptr = (void __iomem *) (vg->reg_base + reg_offset + reg); - return ptr; + return vg->reg_base + reg_offset + reg; } static int byt_gpio_request(struct gpio_chip *chip, unsigned offset) -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 3/5] pinctrl-baytrail: remove redundant ptr variable 2013-07-10 11:55 ` [PATCH 3/5] pinctrl-baytrail: remove redundant ptr variable Andy Shevchenko @ 2013-07-22 20:49 ` Linus Walleij 0 siblings, 0 replies; 14+ messages in thread From: Linus Walleij @ 2013-07-22 20:49 UTC (permalink / raw) To: Andy Shevchenko; +Cc: linux-kernel@vger.kernel.org, Mika Westerberg On Wed, Jul 10, 2013 at 1:55 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > There is no need to have an additional variable in byt_gpio_reg(). > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Patch applied. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 4/5] pinctrl-baytrail: introduce to_byt_gpio() macro 2013-07-10 11:55 [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes Andy Shevchenko ` (2 preceding siblings ...) 2013-07-10 11:55 ` [PATCH 3/5] pinctrl-baytrail: remove redundant ptr variable Andy Shevchenko @ 2013-07-10 11:55 ` Andy Shevchenko 2013-07-22 20:50 ` Linus Walleij 2013-07-10 11:55 ` [PATCH 5/5] pinctrl-baytrail: fix to avoid sparse warnings Andy Shevchenko 2013-07-15 10:24 ` [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes Andy Shevchenko 5 siblings, 1 reply; 14+ messages in thread From: Andy Shevchenko @ 2013-07-10 11:55 UTC (permalink / raw) To: Linus Walleij, linux-kernel, Mika Westerberg; +Cc: Andy Shevchenko The introduced macro helps to convert struct gpio_chip to struct byt_gpio. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/pinctrl-baytrail.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c index 14a143c..14e1e22 100644 --- a/drivers/pinctrl/pinctrl-baytrail.c +++ b/drivers/pinctrl/pinctrl-baytrail.c @@ -130,10 +130,12 @@ struct byt_gpio { struct pinctrl_gpio_range *range; }; +#define to_byt_gpio(c) container_of(c, struct byt_gpio, chip) + static void __iomem *byt_gpio_reg(struct gpio_chip *chip, unsigned offset, int reg) { - struct byt_gpio *vg = container_of(chip, struct byt_gpio, chip); + struct byt_gpio *vg = to_byt_gpio(chip); u32 reg_offset; if (reg == BYT_INT_STAT_REG) @@ -146,7 +148,7 @@ static void __iomem *byt_gpio_reg(struct gpio_chip *chip, unsigned offset, static int byt_gpio_request(struct gpio_chip *chip, unsigned offset) { - struct byt_gpio *vg = container_of(chip, struct byt_gpio, chip); + struct byt_gpio *vg = to_byt_gpio(chip); pm_runtime_get(&vg->pdev->dev); @@ -155,7 +157,7 @@ static int byt_gpio_request(struct gpio_chip *chip, unsigned offset) static void byt_gpio_free(struct gpio_chip *chip, unsigned offset) { - struct byt_gpio *vg = container_of(chip, struct byt_gpio, chip); + struct byt_gpio *vg = to_byt_gpio(chip); void __iomem *reg = byt_gpio_reg(&vg->chip, offset, BYT_CONF0_REG); u32 value; @@ -216,7 +218,7 @@ static int byt_gpio_get(struct gpio_chip *chip, unsigned offset) static void byt_gpio_set(struct gpio_chip *chip, unsigned offset, int value) { - struct byt_gpio *vg = container_of(chip, struct byt_gpio, chip); + struct byt_gpio *vg = to_byt_gpio(chip); void __iomem *reg = byt_gpio_reg(chip, offset, BYT_VAL_REG); unsigned long flags; u32 old_val; @@ -235,7 +237,7 @@ static void byt_gpio_set(struct gpio_chip *chip, unsigned offset, int value) static int byt_gpio_direction_input(struct gpio_chip *chip, unsigned offset) { - struct byt_gpio *vg = container_of(chip, struct byt_gpio, chip); + struct byt_gpio *vg = to_byt_gpio(chip); void __iomem *reg = byt_gpio_reg(chip, offset, BYT_VAL_REG); unsigned long flags; u32 value; @@ -254,7 +256,7 @@ static int byt_gpio_direction_input(struct gpio_chip *chip, unsigned offset) static int byt_gpio_direction_output(struct gpio_chip *chip, unsigned gpio, int value) { - struct byt_gpio *vg = container_of(chip, struct byt_gpio, chip); + struct byt_gpio *vg = to_byt_gpio(chip); void __iomem *reg = byt_gpio_reg(chip, gpio, BYT_VAL_REG); unsigned long flags; u32 reg_val; @@ -272,7 +274,7 @@ static int byt_gpio_direction_output(struct gpio_chip *chip, static void byt_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) { - struct byt_gpio *vg = container_of(chip, struct byt_gpio, chip); + struct byt_gpio *vg = to_byt_gpio(chip); int i; unsigned long flags; u32 conf0, val, offs; @@ -301,7 +303,7 @@ static void byt_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip) static int byt_gpio_to_irq(struct gpio_chip *chip, unsigned offset) { - struct byt_gpio *vg = container_of(chip, struct byt_gpio, chip); + struct byt_gpio *vg = to_byt_gpio(chip); return irq_create_mapping(vg->domain, offset); } -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 4/5] pinctrl-baytrail: introduce to_byt_gpio() macro 2013-07-10 11:55 ` [PATCH 4/5] pinctrl-baytrail: introduce to_byt_gpio() macro Andy Shevchenko @ 2013-07-22 20:50 ` Linus Walleij 0 siblings, 0 replies; 14+ messages in thread From: Linus Walleij @ 2013-07-22 20:50 UTC (permalink / raw) To: Andy Shevchenko; +Cc: linux-kernel@vger.kernel.org, Mika Westerberg On Wed, Jul 10, 2013 at 1:55 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > The introduced macro helps to convert struct gpio_chip to struct byt_gpio. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Patch applied. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 14+ messages in thread
* [PATCH 5/5] pinctrl-baytrail: fix to avoid sparse warnings 2013-07-10 11:55 [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes Andy Shevchenko ` (3 preceding siblings ...) 2013-07-10 11:55 ` [PATCH 4/5] pinctrl-baytrail: introduce to_byt_gpio() macro Andy Shevchenko @ 2013-07-10 11:55 ` Andy Shevchenko 2013-07-22 20:51 ` Linus Walleij 2013-07-15 10:24 ` [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes Andy Shevchenko 5 siblings, 1 reply; 14+ messages in thread From: Andy Shevchenko @ 2013-07-10 11:55 UTC (permalink / raw) To: Linus Walleij, linux-kernel, Mika Westerberg; +Cc: Andy Shevchenko There are couple of sparse warnings we could avoid if we use a bit verbose version of the code in byt_gpio_direction_output(). drivers/pinctrl/pinctrl-baytrail.c:266:45: warning: dubious: x | !y drivers/pinctrl/pinctrl-baytrail.c:267:36: warning: dubious: x | !y Additionally simplify a bit the code in byt_gpio_direction_input(). Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/pinctrl-baytrail.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/pinctrl/pinctrl-baytrail.c b/drivers/pinctrl/pinctrl-baytrail.c index 14e1e22..f808b4b 100644 --- a/drivers/pinctrl/pinctrl-baytrail.c +++ b/drivers/pinctrl/pinctrl-baytrail.c @@ -245,7 +245,7 @@ static int byt_gpio_direction_input(struct gpio_chip *chip, unsigned offset) spin_lock_irqsave(&vg->lock, flags); value = readl(reg) | BYT_DIR_MASK; - value = value & (~BYT_INPUT_EN); /* active low */ + value &= ~BYT_INPUT_EN; /* active low */ writel(value, reg); spin_unlock_irqrestore(&vg->lock, flags); @@ -263,9 +263,13 @@ static int byt_gpio_direction_output(struct gpio_chip *chip, spin_lock_irqsave(&vg->lock, flags); - reg_val = readl(reg) | (BYT_DIR_MASK | !!value); - reg_val &= ~(BYT_OUTPUT_EN | !value); - writel(reg_val, reg); + reg_val = readl(reg) | BYT_DIR_MASK; + reg_val &= ~BYT_OUTPUT_EN; + + if (value) + writel(reg_val | BYT_LEVEL, reg); + else + writel(reg_val & ~BYT_LEVEL, reg); spin_unlock_irqrestore(&vg->lock, flags); -- 1.8.3.2 ^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH 5/5] pinctrl-baytrail: fix to avoid sparse warnings 2013-07-10 11:55 ` [PATCH 5/5] pinctrl-baytrail: fix to avoid sparse warnings Andy Shevchenko @ 2013-07-22 20:51 ` Linus Walleij 0 siblings, 0 replies; 14+ messages in thread From: Linus Walleij @ 2013-07-22 20:51 UTC (permalink / raw) To: Andy Shevchenko; +Cc: linux-kernel@vger.kernel.org, Mika Westerberg On Wed, Jul 10, 2013 at 1:55 PM, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > There are couple of sparse warnings we could avoid if we use a bit verbose > version of the code in byt_gpio_direction_output(). > > drivers/pinctrl/pinctrl-baytrail.c:266:45: warning: dubious: x | !y > drivers/pinctrl/pinctrl-baytrail.c:267:36: warning: dubious: x | !y > > Additionally simplify a bit the code in byt_gpio_direction_input(). > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Patch applied. Yours, Linus Walleij ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes 2013-07-10 11:55 [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes Andy Shevchenko ` (4 preceding siblings ...) 2013-07-10 11:55 ` [PATCH 5/5] pinctrl-baytrail: fix to avoid sparse warnings Andy Shevchenko @ 2013-07-15 10:24 ` Andy Shevchenko 2013-07-15 18:34 ` Mika Westerberg 5 siblings, 1 reply; 14+ messages in thread From: Andy Shevchenko @ 2013-07-15 10:24 UTC (permalink / raw) To: Linus Walleij; +Cc: linux-kernel, Mika Westerberg On Wed, 2013-07-10 at 14:55 +0300, Andy Shevchenko wrote: > This is a set of small minor fixes against pinctrl-baytrail driver. Linus, Mika, anyone do you have any comment on the series? > > Andy Shevchenko (5): > pinctrl-baytrail: fix indentations > pinctrl-baytrail: change lvl to level > pinctrl-baytrail: remove redundant ptr variable > pinctrl-baytrail: introduce to_byt_gpio() macro > pinctrl-baytrail: fix to avoid sparse warnings > > drivers/pinctrl/Kconfig | 2 +- > drivers/pinctrl/pinctrl-baytrail.c | 37 +++++++++++++++++++++---------------- > 2 files changed, 22 insertions(+), 17 deletions(-) > -- Andy Shevchenko <andriy.shevchenko@linux.intel.com> Intel Finland Oy ^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes 2013-07-15 10:24 ` [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes Andy Shevchenko @ 2013-07-15 18:34 ` Mika Westerberg 0 siblings, 0 replies; 14+ messages in thread From: Mika Westerberg @ 2013-07-15 18:34 UTC (permalink / raw) To: Andy Shevchenko; +Cc: Linus Walleij, linux-kernel On Mon, Jul 15, 2013 at 01:24:30PM +0300, Andy Shevchenko wrote: > On Wed, 2013-07-10 at 14:55 +0300, Andy Shevchenko wrote: > > This is a set of small minor fixes against pinctrl-baytrail driver. > > Linus, Mika, anyone do you have any comment on the series? Well, looks good to me but I don't know the HW details. Anyway, I reviewed the code so: Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> ^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2013-07-22 20:51 UTC | newest] Thread overview: 14+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-07-10 11:55 [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes Andy Shevchenko 2013-07-10 11:55 ` [PATCH 1/5] pinctrl-baytrail: fix indentations Andy Shevchenko 2013-07-22 20:47 ` Linus Walleij 2013-07-10 11:55 ` [PATCH 2/5] pinctrl-baytrail: change lvl to level Andy Shevchenko 2013-07-10 13:42 ` [PATCH v1.5] " Andy Shevchenko 2013-07-22 20:48 ` Linus Walleij 2013-07-10 11:55 ` [PATCH 3/5] pinctrl-baytrail: remove redundant ptr variable Andy Shevchenko 2013-07-22 20:49 ` Linus Walleij 2013-07-10 11:55 ` [PATCH 4/5] pinctrl-baytrail: introduce to_byt_gpio() macro Andy Shevchenko 2013-07-22 20:50 ` Linus Walleij 2013-07-10 11:55 ` [PATCH 5/5] pinctrl-baytrail: fix to avoid sparse warnings Andy Shevchenko 2013-07-22 20:51 ` Linus Walleij 2013-07-15 10:24 ` [PATCH 0/5] pinctrl-baytrail: miscellaneous minor fixes Andy Shevchenko 2013-07-15 18:34 ` Mika Westerberg
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox