[PATCH 1/1] fs/jffs2/compr.c: remove 0 assignment on static

[PATCH 1/1] fs/jffs2/compr.c: remove 0 assignment on static

[Fabian Frederick]

static values are automatically initialized to NULL

Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 fs/jffs2/compr.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/fs/jffs2/compr.c b/fs/jffs2/compr.c
index 4849a4c..a673221 100644
--- a/fs/jffs2/compr.c
+++ b/fs/jffs2/compr.c
@@ -25,7 +25,8 @@ static LIST_HEAD(jffs2_compressor_list);
 static int jffs2_compression_mode = JFFS2_COMPR_MODE_PRIORITY;
 
 /* Statistics for blocks stored without compression */
-static uint32_t none_stat_compr_blocks=0,none_stat_decompr_blocks=0,none_stat_compr_size=0;
+static uint32_t none_stat_compr_blocks, none_stat_decompr_blocks,
+		none_stat_compr_size;
 
 
 /*
-- 
1.8.4.5

Re: [PATCH 1/1] fs/jffs2/compr.c: remove 0 assignment on static

[Joe Perches]

On Mon, 2014-05-19 at 21:31 +0200, Fabian Frederick wrote:
> static values are automatically initialized to NULL
[]
> diff --git a/fs/jffs2/compr.c b/fs/jffs2/compr.c
[]
> @@ -25,7 +25,8 @@ static LIST_HEAD(jffs2_compressor_list);
>  static int jffs2_compression_mode = JFFS2_COMPR_MODE_PRIORITY;
>  
>  /* Statistics for blocks stored without compression */
> -static uint32_t none_stat_compr_blocks=0,none_stat_decompr_blocks=0,none_stat_compr_size=0;
> +static uint32_t none_stat_compr_blocks, none_stat_decompr_blocks,
> +		none_stat_compr_size;

Maybe nicer on 3 lines.

static uint32_t none_stat_compr_blocks;
static uint32_t none_stat_decompr_blocks,
static uint32_t none_stat_compr_size;

These none_stat_<foo> variables seem to
be write only so it'd probably be better
to remove them instead.

Maybe all the uint32_t uses in fs/jffs2/
would be nicer as u32.

Re: [PATCH 1/1] fs/jffs2/compr.c: remove 0 assignment on static

[David Woodhouse]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

On Mon, 2014-05-19 at 12:53 -0700, Joe Perches wrote:
> Maybe all the uint32_t uses in fs/jffs2/
> would be nicer as u32.

No thanks. We prefer this code in standard C.
1999 is a long time ago now...

-- 
dwmw2


[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5745 bytes --]

Re: [PATCH 1/1] fs/jffs2/compr.c: remove 0 assignment on static

[Joe Perches]

On Mon, 2014-05-19 at 20:56 +0100, David Woodhouse wrote:
> On Mon, 2014-05-19 at 12:53 -0700, Joe Perches wrote:
> > Maybe all the uint32_t uses in fs/jffs2/
> > would be nicer as u32.
> 
> No thanks. We prefer this code in standard C.
> 1999 is a long time ago now...

That's certainly your choice you nonconformist...

$ git grep -w u32 | wc -l
138805
$ git grep -w uint32_t | wc -l
20420

But I gather you don't like to party?