* [PATCH] x86: intel-mid: fix watchdog platform code
[not found] <20140526211820.GB23751@spo001.leaseweb.com>
@ 2014-05-27 21:11 ` David Cohen
2014-05-27 21:21 ` David Cohen
0 siblings, 1 reply; 3+ messages in thread
From: David Cohen @ 2014-05-27 21:11 UTC (permalink / raw)
To: wim, tglx, mingo, hpa, x86
Cc: linux-watchdog, linux-kernel, gnomes, David Cohen
This patch fixes missing include asm/io_apic.h which may lead to
following error:
arch/x86/platform/intel-mid/device_libs/platform_wdt.c: In function 'tangier_probe':
>> arch/x86/platform/intel-mid/device_libs/platform_wdt.c:37:2: error: implicit declaration of function 'mp_find_ioapic' [-Werror=implicit-function-declaration]
ioapic = mp_find_ioapic(irq);
^
>> arch/x86/platform/intel-mid/device_libs/platform_wdt.c:44:3: error: implicit declaration of function 'io_apic_set_pci_routing' [-Werror=implicit-function-declaration]
ret = io_apic_set_pci_routing(NULL, irq, &irq_attr);
^
Signed-off-by: David Cohen <david.a.cohen@intel.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
---
arch/x86/platform/intel-mid/device_libs/platform_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/platform/intel-mid/device_libs/platform_wdt.c b/arch/x86/platform/intel-mid/device_libs/platform_wdt.c
index a05315eb052d..973cf3bfa9fd 100644
--- a/arch/x86/platform/intel-mid/device_libs/platform_wdt.c
+++ b/arch/x86/platform/intel-mid/device_libs/platform_wdt.c
@@ -15,6 +15,7 @@
#include <linux/platform_device.h>
#include <linux/platform_data/intel-mid_wdt.h>
#include <asm/intel-mid.h>
+#include <asm/io_apic.h>
#define TANGIER_EXT_TIMER0_MSI 15
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] x86: intel-mid: fix watchdog platform code
2014-05-27 21:11 ` [PATCH] x86: intel-mid: fix watchdog platform code David Cohen
@ 2014-05-27 21:21 ` David Cohen
2014-05-27 23:34 ` Guenter Roeck
0 siblings, 1 reply; 3+ messages in thread
From: David Cohen @ 2014-05-27 21:21 UTC (permalink / raw)
To: wim, tglx, mingo, hpa, x86
Cc: linux-watchdog, linux-kernel, gnomes, David Cohen
This patch fixes missing include asm/io_apic.h which may lead to
following error:
arch/x86/platform/intel-mid/device_libs/platform_wdt.c: In function 'tangier_probe':
>> arch/x86/platform/intel-mid/device_libs/platform_wdt.c:37:2: error: implicit declaration of function 'mp_find_ioapic' [-Werror=implicit-function-declaration]
ioapic = mp_find_ioapic(irq);
^
>> arch/x86/platform/intel-mid/device_libs/platform_wdt.c:44:3: error: implicit declaration of function 'io_apic_set_pci_routing' [-Werror=implicit-function-declaration]
ret = io_apic_set_pci_routing(NULL, irq, &irq_attr);
^
Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
Reported-by: kbuild test robot <fengguang.wu@intel.com>
---
Hi,
Delta from v1 to v1.1: amend my e-mail from @intel.com to @linux.intel.com
FWIW it is not required to make INTEL_MID_WATCHDOG to depend on X86_IO_APIC,
because this driver already depends on X86_INTEL_MID (which depends on
X86_IO_APIC).
BR, David
---
arch/x86/platform/intel-mid/device_libs/platform_wdt.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/x86/platform/intel-mid/device_libs/platform_wdt.c b/arch/x86/platform/intel-mid/device_libs/platform_wdt.c
index a05315eb052d..973cf3bfa9fd 100644
--- a/arch/x86/platform/intel-mid/device_libs/platform_wdt.c
+++ b/arch/x86/platform/intel-mid/device_libs/platform_wdt.c
@@ -15,6 +15,7 @@
#include <linux/platform_device.h>
#include <linux/platform_data/intel-mid_wdt.h>
#include <asm/intel-mid.h>
+#include <asm/io_apic.h>
#define TANGIER_EXT_TIMER0_MSI 15
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] x86: intel-mid: fix watchdog platform code
2014-05-27 21:21 ` David Cohen
@ 2014-05-27 23:34 ` Guenter Roeck
0 siblings, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2014-05-27 23:34 UTC (permalink / raw)
To: David Cohen, wim, tglx, mingo, hpa, x86
Cc: linux-watchdog, linux-kernel, gnomes
On 05/27/2014 02:21 PM, David Cohen wrote:
> This patch fixes missing include asm/io_apic.h which may lead to
> following error:
>
> arch/x86/platform/intel-mid/device_libs/platform_wdt.c: In function 'tangier_probe':
>>> arch/x86/platform/intel-mid/device_libs/platform_wdt.c:37:2: error: implicit declaration of function 'mp_find_ioapic' [-Werror=implicit-function-declaration]
> ioapic = mp_find_ioapic(irq);
> ^
>>> arch/x86/platform/intel-mid/device_libs/platform_wdt.c:44:3: error: implicit declaration of function 'io_apic_set_pci_routing' [-Werror=implicit-function-declaration]
> ret = io_apic_set_pci_routing(NULL, irq, &irq_attr);
> ^
> Signed-off-by: David Cohen <david.a.cohen@linux.intel.com>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-05-27 23:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20140526211820.GB23751@spo001.leaseweb.com>
2014-05-27 21:11 ` [PATCH] x86: intel-mid: fix watchdog platform code David Cohen
2014-05-27 21:21 ` David Cohen
2014-05-27 23:34 ` Guenter Roeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox