* [PATCH] regulator: sky81452: Remove module version
@ 2014-10-08 1:57 Axel Lin
2014-10-08 8:57 ` Gyungoh Yoo
2014-10-08 11:27 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Axel Lin @ 2014-10-08 1:57 UTC (permalink / raw)
To: Mark Brown; +Cc: Gyungoh Yoo, Liam Girdwood, linux-kernel@vger.kernel.org
The module version is unlikely to be updated, use kernel version should be
enough.
Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
Hi Gyungoh,
Seems you have added MODULE_VERSION for the sky81452 serial patches.
Do you really need that and will keep updating it?
Otherwise, you may want to drop the MODULE_VERSION in sky81452 serial patches.
drivers/regulator/sky81452-regulator.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/regulator/sky81452-regulator.c b/drivers/regulator/sky81452-regulator.c
index 97aff0c..476b80a 100644
--- a/drivers/regulator/sky81452-regulator.c
+++ b/drivers/regulator/sky81452-regulator.c
@@ -127,4 +127,3 @@ module_platform_driver(sky81452_reg_driver);
MODULE_DESCRIPTION("Skyworks SKY81452 Regulator driver");
MODULE_AUTHOR("Gyungoh Yoo <jack.yoo@skyworksinc.com>");
MODULE_LICENSE("GPL");
-MODULE_VERSION("1.0");
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] regulator: sky81452: Remove module version
2014-10-08 1:57 [PATCH] regulator: sky81452: Remove module version Axel Lin
@ 2014-10-08 8:57 ` Gyungoh Yoo
2014-10-08 11:27 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Gyungoh Yoo @ 2014-10-08 8:57 UTC (permalink / raw)
To: Axel Lin
Cc: Mark Brown, Liam Girdwood, linux-kernel@vger.kernel.org, jack.yoo
On Wed, Oct 08, 2014 at 09:57:43AM +0800, Axel Lin wrote:
> The module version is unlikely to be updated, use kernel version should be
> enough.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> Hi Gyungoh,
> Seems you have added MODULE_VERSION for the sky81452 serial patches.
> Do you really need that and will keep updating it?
> Otherwise, you may want to drop the MODULE_VERSION in sky81452 serial patches.
I see.
I will remove MODULE_VERSION and resumit.
Thank you.
>
> drivers/regulator/sky81452-regulator.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/regulator/sky81452-regulator.c b/drivers/regulator/sky81452-regulator.c
> index 97aff0c..476b80a 100644
> --- a/drivers/regulator/sky81452-regulator.c
> +++ b/drivers/regulator/sky81452-regulator.c
> @@ -127,4 +127,3 @@ module_platform_driver(sky81452_reg_driver);
> MODULE_DESCRIPTION("Skyworks SKY81452 Regulator driver");
> MODULE_AUTHOR("Gyungoh Yoo <jack.yoo@skyworksinc.com>");
> MODULE_LICENSE("GPL");
> -MODULE_VERSION("1.0");
> --
> 1.9.1
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] regulator: sky81452: Remove module version
2014-10-08 1:57 [PATCH] regulator: sky81452: Remove module version Axel Lin
2014-10-08 8:57 ` Gyungoh Yoo
@ 2014-10-08 11:27 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2014-10-08 11:27 UTC (permalink / raw)
To: Axel Lin; +Cc: Gyungoh Yoo, Liam Girdwood, linux-kernel@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 163 bytes --]
On Wed, Oct 08, 2014 at 09:57:43AM +0800, Axel Lin wrote:
> The module version is unlikely to be updated, use kernel version should be
> enough.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-08 11:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-08 1:57 [PATCH] regulator: sky81452: Remove module version Axel Lin
2014-10-08 8:57 ` Gyungoh Yoo
2014-10-08 11:27 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox