[PATCH] soc: versatile: Add terminating entry for realview_soc_of_match

[PATCH] soc: versatile: Add terminating entry for realview_soc_of_match

[Axel Lin]

The of_device_id table is supposed to be zero-terminated.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
---
 drivers/soc/versatile/soc-realview.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/versatile/soc-realview.c b/drivers/soc/versatile/soc-realview.c
index cea8ea3..1a07bf5 100644
--- a/drivers/soc/versatile/soc-realview.c
+++ b/drivers/soc/versatile/soc-realview.c
@@ -26,6 +26,7 @@ static const struct of_device_id realview_soc_of_match[] = {
 	{ .compatible = "arm,realview-pb11mp-soc", },
 	{ .compatible = "arm,realview-pba8-soc", },
 	{ .compatible = "arm,realview-pbx-soc", },
+	{ }
 };
 
 static u32 realview_coreid;
-- 
1.9.1

Re: [PATCH] soc: versatile: Add terminating entry for realview_soc_of_match

[Linus Walleij]

On Sun, Oct 19, 2014 at 5:41 PM, Axel Lin <axel.lin@ingics.com> wrote:

> The of_device_id table is supposed to be zero-terminated.
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Arnd are you merging this directly into ARM SoC?

Yours,
Linus Walleij

Re: [PATCH] soc: versatile: Add terminating entry for realview_soc_of_match

[Arnd Bergmann]

On Monday 20 October 2014 14:37:04 Linus Walleij wrote:
> On Sun, Oct 19, 2014 at 5:41 PM, Axel Lin <axel.lin@ingics.com> wrote:
> 
> > The of_device_id table is supposed to be zero-terminated.
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Arnd are you merging this directly into ARM SoC?
> 

Applied to the fixes branch.

Please remember to add arm@kernel.org when you want us to pick up the
patches.

	Arnd

Re: [PATCH] soc: versatile: Add terminating entry for realview_soc_of_match

[Axel Lin]

>>
>> Arnd are you merging this directly into ARM SoC?
>>
>
> Applied to the fixes branch.
Thanks.
>
> Please remember to add arm@kernel.org when you want us to pick up the
> patches.
scripts/get_maintainer.pl does not suggest arm@kernel.org for this patch.

$ scripts/get_maintainer.pl
0001-soc-versatile-Add-terminating-entry-for-realview_soc.patch
Linus Walleij <linus.walleij@linaro.org>
(commit_signer:1/1=100%,authored:1/1=100%,added_lines:144/144=100%)
Arnd Bergmann <arnd@arndb.de> (commit_signer:1/1=100%)
linux-kernel@vger.kernel.org (open list)

Maybe it needs update the maintainer entry?

Axel

Re: [PATCH] soc: versatile: Add terminating entry for realview_soc_of_match

[Arnd Bergmann]

On Wednesday 29 October 2014 08:48:11 Axel Lin wrote:
> >>
> >> Arnd are you merging this directly into ARM SoC?
> >>
> >
> > Applied to the fixes branch.
> Thanks.
> >
> > Please remember to add arm@kernel.org when you want us to pick up the
> > patches.
> scripts/get_maintainer.pl does not suggest arm@kernel.org for this patch.
> 
> $ scripts/get_maintainer.pl
> 0001-soc-versatile-Add-terminating-entry-for-realview_soc.patch
> Linus Walleij <linus.walleij@linaro.org>
> (commit_signer:1/1=100%,authored:1/1=100%,added_lines:144/144=100%)
> Arnd Bergmann <arnd@arndb.de> (commit_signer:1/1=100%)
> linux-kernel@vger.kernel.org (open list)
> 
> Maybe it needs update the maintainer entry?

We generally don't want developers other than subarch maintainers to
send us stuff directly and we certainly don't want to be Cc'd on
(literally, if you count every version in review) thousands of patches
per kernel release.

My comment was directed at Linus, who has sent us the updates for
vexpress recently and who was (rightfully) asking for the patch to
be picked up.

	Arnd