* [PATCH] [media] omap24xx/tcm825x: remove pointless Makefile entry
@ 2014-11-24 10:53 Paul Bolle
2014-11-24 11:08 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2014-11-24 10:53 UTC (permalink / raw)
To: Hans Verkuil, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: Valentin Rothberg, Sakari Ailus, linux-media, devel, linux-kernel
The deprecated omap2 camera drivers were recently removed. Both the
Kconfig symbol VIDEO_TCM825X and the drivers/staging/media/omap24xx
directory are gone. So the Makefile entry that references both is now
pointless. Remove it too.
Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
---
Tested by grepping the tree.
Triggered by commit db85a0403be4 ("[media] omap24xx/tcm825x: remove
deprecated omap2 camera drivers."), which is included in next-20141124.
What happened is that it removed only one of the two Makefile entries
for omap24xx.
drivers/staging/media/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/Makefile b/drivers/staging/media/Makefile
index 97bfef97f838..30fb352fc4a9 100644
--- a/drivers/staging/media/Makefile
+++ b/drivers/staging/media/Makefile
@@ -4,7 +4,6 @@ obj-$(CONFIG_LIRC_STAGING) += lirc/
obj-$(CONFIG_VIDEO_DT3155) += dt3155v4l/
obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci_vpfe/
obj-$(CONFIG_VIDEO_OMAP4) += omap4iss/
-obj-$(CONFIG_VIDEO_TCM825X) += omap24xx/
obj-$(CONFIG_DVB_MN88472) += mn88472/
obj-$(CONFIG_DVB_MN88473) += mn88473/
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] omap24xx/tcm825x: remove pointless Makefile entry
2014-11-24 10:53 [PATCH] [media] omap24xx/tcm825x: remove pointless Makefile entry Paul Bolle
@ 2014-11-24 11:08 ` Hans Verkuil
2014-11-24 11:15 ` Paul Bolle
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2014-11-24 11:08 UTC (permalink / raw)
To: Paul Bolle, Hans Verkuil, Mauro Carvalho Chehab,
Greg Kroah-Hartman
Cc: Valentin Rothberg, Sakari Ailus, linux-media, devel, linux-kernel
I found the same thing and it is already part of my pull request
to Mauro.
I'm setting this patch as Obsoleted in patchwork.
It's unclear what happened. My original patch definitely removed both
Makefile lines.
Regards,
Hans
On 11/24/14 11:53, Paul Bolle wrote:
> The deprecated omap2 camera drivers were recently removed. Both the
> Kconfig symbol VIDEO_TCM825X and the drivers/staging/media/omap24xx
> directory are gone. So the Makefile entry that references both is now
> pointless. Remove it too.
>
> Signed-off-by: Paul Bolle <pebolle@tiscali.nl>
> ---
> Tested by grepping the tree.
>
> Triggered by commit db85a0403be4 ("[media] omap24xx/tcm825x: remove
> deprecated omap2 camera drivers."), which is included in next-20141124.
> What happened is that it removed only one of the two Makefile entries
> for omap24xx.
>
> drivers/staging/media/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/media/Makefile b/drivers/staging/media/Makefile
> index 97bfef97f838..30fb352fc4a9 100644
> --- a/drivers/staging/media/Makefile
> +++ b/drivers/staging/media/Makefile
> @@ -4,7 +4,6 @@ obj-$(CONFIG_LIRC_STAGING) += lirc/
> obj-$(CONFIG_VIDEO_DT3155) += dt3155v4l/
> obj-$(CONFIG_VIDEO_DM365_VPFE) += davinci_vpfe/
> obj-$(CONFIG_VIDEO_OMAP4) += omap4iss/
> -obj-$(CONFIG_VIDEO_TCM825X) += omap24xx/
> obj-$(CONFIG_DVB_MN88472) += mn88472/
> obj-$(CONFIG_DVB_MN88473) += mn88473/
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] omap24xx/tcm825x: remove pointless Makefile entry
2014-11-24 11:08 ` Hans Verkuil
@ 2014-11-24 11:15 ` Paul Bolle
0 siblings, 0 replies; 3+ messages in thread
From: Paul Bolle @ 2014-11-24 11:15 UTC (permalink / raw)
To: Hans Verkuil
Cc: Hans Verkuil, Mauro Carvalho Chehab, Greg Kroah-Hartman,
Valentin Rothberg, Sakari Ailus, linux-media, devel, linux-kernel
On Mon, 2014-11-24 at 12:08 +0100, Hans Verkuil wrote:
> I found the same thing and it is already part of my pull request
> to Mauro.
Either way, this trivial issue will be solved.
Thanks,
Paul Bolle
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-24 11:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-24 10:53 [PATCH] [media] omap24xx/tcm825x: remove pointless Makefile entry Paul Bolle
2014-11-24 11:08 ` Hans Verkuil
2014-11-24 11:15 ` Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox