* [PATCH v2] staging: rtl8188eu: use %pM specifier instead of passing direct values
@ 2015-03-08 16:42 Mike Krinkin
2015-03-08 17:00 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Mike Krinkin @ 2015-03-08 16:42 UTC (permalink / raw)
To: Larry.Finger, gregkh; +Cc: devel, linux-kernel, Mike Krinkin
The patch converts code to use %pM specifier instead of pushing
each byte via stack.
Signed-off-by: Mike Krinkin <krinkin.m.u@gmail.com>
---
Changes in v2:
- use %pM instead %*ph as suggested by Larry Finger.
drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
index 122e9b3..960a7a5 100644
--- a/drivers/staging/rtl8188eu/hal/usb_halinit.c
+++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c
@@ -1096,10 +1096,8 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool
memcpy(eeprom->mac_addr, &hwinfo[EEPROM_MAC_ADDR_88EU], ETH_ALEN);
}
RT_TRACE(_module_hci_hal_init_c_, _drv_notice_,
- ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %02x-%02x-%02x-%02x-%02x-%02x\n",
- eeprom->mac_addr[0], eeprom->mac_addr[1],
- eeprom->mac_addr[2], eeprom->mac_addr[3],
- eeprom->mac_addr[4], eeprom->mac_addr[5]));
+ ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %6phD\n",
+ eeprom->mac_addr));
}
static void
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: rtl8188eu: use %pM specifier instead of passing direct values
2015-03-08 16:42 [PATCH v2] staging: rtl8188eu: use %pM specifier instead of passing direct values Mike Krinkin
@ 2015-03-08 17:00 ` Joe Perches
2015-03-08 17:18 ` Mike Krinkin
0 siblings, 1 reply; 3+ messages in thread
From: Joe Perches @ 2015-03-08 17:00 UTC (permalink / raw)
To: Mike Krinkin; +Cc: Larry.Finger, gregkh, devel, linux-kernel
On Sun, 2015-03-08 at 19:42 +0300, Mike Krinkin wrote:
> The patch converts code to use %pM specifier instead of pushing
> each byte via stack.
Hello Mike.
> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
[]
> @@ -1096,10 +1096,8 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool
> memcpy(eeprom->mac_addr, &hwinfo[EEPROM_MAC_ADDR_88EU], ETH_ALEN);
> }
> RT_TRACE(_module_hci_hal_init_c_, _drv_notice_,
> - ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %02x-%02x-%02x-%02x-%02x-%02x\n",
> - eeprom->mac_addr[0], eeprom->mac_addr[1],
> - eeprom->mac_addr[2], eeprom->mac_addr[3],
> - eeprom->mac_addr[4], eeprom->mac_addr[5]));
> + ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %6phD\n",
> + eeprom->mac_addr));
You changed the subject and commit log but not
the patch. V3?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] staging: rtl8188eu: use %pM specifier instead of passing direct values
2015-03-08 17:00 ` Joe Perches
@ 2015-03-08 17:18 ` Mike Krinkin
0 siblings, 0 replies; 3+ messages in thread
From: Mike Krinkin @ 2015-03-08 17:18 UTC (permalink / raw)
To: Joe Perches; +Cc: Larry.Finger, gregkh, devel, linux-kernel
On Sun, Mar 08, 2015 at 10:00:52AM -0700, Joe Perches wrote:
> On Sun, 2015-03-08 at 19:42 +0300, Mike Krinkin wrote:
> > The patch converts code to use %pM specifier instead of pushing
> > each byte via stack.
>
> Hello Mike.
>
> > diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c
> []
> > @@ -1096,10 +1096,8 @@ static void Hal_EfuseParseMACAddr_8188EU(struct adapter *adapt, u8 *hwinfo, bool
> > memcpy(eeprom->mac_addr, &hwinfo[EEPROM_MAC_ADDR_88EU], ETH_ALEN);
> > }
> > RT_TRACE(_module_hci_hal_init_c_, _drv_notice_,
> > - ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %02x-%02x-%02x-%02x-%02x-%02x\n",
> > - eeprom->mac_addr[0], eeprom->mac_addr[1],
> > - eeprom->mac_addr[2], eeprom->mac_addr[3],
> > - eeprom->mac_addr[4], eeprom->mac_addr[5]));
> > + ("Hal_EfuseParseMACAddr_8188EU: Permanent Address = %6phD\n",
> > + eeprom->mac_addr));
>
> You changed the subject and commit log but not
> the patch. V3?
>
It was stupid fault... Sorry for noise.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-03-08 17:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-03-08 16:42 [PATCH v2] staging: rtl8188eu: use %pM specifier instead of passing direct values Mike Krinkin
2015-03-08 17:00 ` Joe Perches
2015-03-08 17:18 ` Mike Krinkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox