[PATCH] perf, tools: Print stddev in CSV mode with -a

[PATCH] perf, tools: Print stddev in CSV mode with -a

[Andi Kleen]

From: Andi Kleen <ak@linux.intel.com>

Currently with -r.. -a -A ,x or other aggregation we don't print the
stddev into the CSV output. Just drop the checks preventing this.

Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 tools/perf/builtin-stat.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
index d4d1b77..3de0ea5 100644
--- a/tools/perf/builtin-stat.c
+++ b/tools/perf/builtin-stat.c
@@ -1282,8 +1282,7 @@ static void print_aggr(char *prefix)
 			else
 				abs_printout(id, nr, counter, uval);
 
-			if (!csv_output)
-				print_noise(counter, 1.0);
+			print_noise(counter, 1.0);
 
 			print_running(run, ena);
 			fputc('\n', output);
@@ -1392,8 +1391,7 @@ static void print_counter(struct perf_evsel *counter, char *prefix)
 		else
 			abs_printout(cpu, 0, counter, uval);
 
-		if (!csv_output)
-			print_noise(counter, 1.0);
+		print_noise(counter, 1.0);
 		print_running(run, ena);
 
 		fputc('\n', output);
-- 
2.3.3

Re: [PATCH] perf, tools: Print stddev in CSV mode with -a

[Jiri Olsa]

On Wed, Apr 08, 2015 at 07:48:21AM -0700, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> Currently with -r.. -a -A ,x or other aggregation we don't print the
> stddev into the CSV output. Just drop the checks preventing this.
> 
> Signed-off-by: Andi Kleen <ak@linux.intel.com>

we already print this print_counter_aggr so I think we can consider
this as bugfix even though it changes current csv format

Acked-by: Jiri Olsa <jolsa@kernel.org>

thanks,
jirka

> ---
>  tools/perf/builtin-stat.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/tools/perf/builtin-stat.c b/tools/perf/builtin-stat.c
> index d4d1b77..3de0ea5 100644
> --- a/tools/perf/builtin-stat.c
> +++ b/tools/perf/builtin-stat.c
> @@ -1282,8 +1282,7 @@ static void print_aggr(char *prefix)
>  			else
>  				abs_printout(id, nr, counter, uval);
>  
> -			if (!csv_output)
> -				print_noise(counter, 1.0);
> +			print_noise(counter, 1.0);
>  
>  			print_running(run, ena);
>  			fputc('\n', output);
> @@ -1392,8 +1391,7 @@ static void print_counter(struct perf_evsel *counter, char *prefix)
>  		else
>  			abs_printout(cpu, 0, counter, uval);
>  
> -		if (!csv_output)
> -			print_noise(counter, 1.0);
> +		print_noise(counter, 1.0);
>  		print_running(run, ena);
>  
>  		fputc('\n', output);
> -- 
> 2.3.3
>