From: Spencer Baugh <sbaugh@catern.com>
To: qla2xxx-upstream@qlogic.com (supporter:QLOGIC QLA2XXX FC-SCSI
DRIVER), "James E.J. Bottomley" <JBottomley@odin.com>,
linux-scsi@vger.kernel.org (open list:QLOGIC QLA2XXX FC-SCSI
DRIVER), linux-kernel@vger.kernel.org (open list)
Cc: Joern Engel <joern@purestorage.com>,
Spencer Baugh <Spencer.baugh@purestorage.com>,
Dilip Kumar Uppugandla <dilip@purestorage.com>,
Spencer Baugh <sbaugh@catern.com>
Subject: [PATCH] qla2xxx: Return the fabric command state for non-task management requests
Date: Tue, 21 Jul 2015 15:07:55 -0700 [thread overview]
Message-ID: <1437516477-30554-3-git-send-email-sbaugh@catern.com> (raw)
From: Dilip Kumar Uppugandla <dilip@purestorage.com>
Invoking get_cmd_state for qla2xxx always returns 0. Instead change it
to return the actual fabric state from qla_tgt_cmd. This will help with
debugging.
Signed-off-by: Dilip Kumar Uppugandla <dilip@purestorage.com>
Signed-off-by: Spencer Baugh <sbaugh@catern.com>
---
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/scsi/qla2xxx/tcm_qla2xxx.c b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
index d9a8c60..e859586 100644
--- a/drivers/scsi/qla2xxx/tcm_qla2xxx.c
+++ b/drivers/scsi/qla2xxx/tcm_qla2xxx.c
@@ -420,6 +420,12 @@ static void tcm_qla2xxx_set_default_node_attrs(struct se_node_acl *nacl)
static int tcm_qla2xxx_get_cmd_state(struct se_cmd *se_cmd)
{
+ if (!(se_cmd->se_cmd_flags & SCF_SCSI_TMR_CDB)) {
+ struct qla_tgt_cmd *cmd = container_of(se_cmd,
+ struct qla_tgt_cmd, se_cmd);
+ return cmd->state;
+ }
+
return 0;
}
--
2.4.3
next reply other threads:[~2015-07-21 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 22:07 Spencer Baugh [this message]
2015-07-21 23:00 ` [PATCH] qla2xxx: Return the fabric command state for non-task management requests Himanshu Madhani
2015-07-23 9:46 ` Christoph Hellwig
[not found] ` <CAGxsngq1aBCoqmdSZcX+o=Ef=NyQSeunqDQuo2iwgmOAxsEqDw@mail.gmail.com>
2015-07-25 6:29 ` Christoph Hellwig
2015-07-27 23:25 ` Quinn Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1437516477-30554-3-git-send-email-sbaugh@catern.com \
--to=sbaugh@catern.com \
--cc=JBottomley@odin.com \
--cc=Spencer.baugh@purestorage.com \
--cc=dilip@purestorage.com \
--cc=joern@purestorage.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=qla2xxx-upstream@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox