Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests

[Quinn Tran <quinn.tran@qlogic.com>]

Christoph,

Currently, the command state within TCM (se_cmd.t_state) only track
command states from the point of new to the Back End and from Back End up
to QLA driver.  From the debug perspective, that¹s only half the picture.
The other half comes from qla2xxx¹s private command state provided by this
patch.

Having another trace point that happens 5~10 seconds ago might be
difficult to back track.  For task management debugging, dumping the
current states (se_cmd + qla_tgt_cmd) of each command when the TMR is
received provides some benefit.

If you feel uncomfortable with the "driver defined binary", one
alternative would be to translate QLA¹s private command state into
se_cmd¹s new field.  This new file would be modify by the fabric layer
only.  This would limit any regression with existing se_cmd field
modification.


Regards,
Quinn Tran




On 7/24/15, 11:29 PM, "target-devel-owner@vger.kernel.org on behalf of
Christoph Hellwig" <target-devel-owner@vger.kernel.org on behalf of
hch@infradead.org> wrote:

>Which debug printk do you care about?  I'd much prefer having a trace
>point inside the driver which could even pretty print it instead of the
>hack where a driver defined binary value is printed by the core.
>--
>To unsubscribe from this list: send the line "unsubscribe target-devel" in
>the body of a message to majordomo@vger.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html