From: Christoph Hellwig <hch@infradead.org>
To: Spencer Baugh <sbaugh@catern.com>
Cc: "supporter:QLOGIC QLA2XXX FC-SCSI DRIVER"
<qla2xxx-upstream@qlogic.com>,
"James E.J. Bottomley" <JBottomley@odin.com>,
"open list:QLOGIC QLA2XXX FC-SCSI DRIVER"
<linux-scsi@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Joern Engel <joern@purestorage.com>,
Spencer Baugh <Spencer.baugh@purestorage.com>,
Dilip Kumar Uppugandla <dilip@purestorage.com>,
target-devel@vger.kernel.org,
Bart Van Assche <bart.vanassche@sandisk.com>
Subject: Re: [PATCH] qla2xxx: Return the fabric command state for non-task management requests
Date: Thu, 23 Jul 2015 02:46:51 -0700 [thread overview]
Message-ID: <20150723094651.GA15301@infradead.org> (raw)
In-Reply-To: <1437516477-30554-3-git-send-email-sbaugh@catern.com>
On Tue, Jul 21, 2015 at 03:07:55PM -0700, Spencer Baugh wrote:
> From: Dilip Kumar Uppugandla <dilip@purestorage.com>
>
> Invoking get_cmd_state for qla2xxx always returns 0. Instead change it
> to return the actual fabric state from qla_tgt_cmd. This will help with
> debugging.
I think the ->get_cmd_state callback should go away instead. Returning
values with zero meaning to the core in a callback doesn't make much
sense. I'd rather build some real structured debugging infrastructure,
so it would be useful if you could explain the use case for this.
next prev parent reply other threads:[~2015-07-23 9:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 22:07 [PATCH] qla2xxx: Return the fabric command state for non-task management requests Spencer Baugh
2015-07-21 23:00 ` Himanshu Madhani
2015-07-23 9:46 ` Christoph Hellwig [this message]
[not found] ` <CAGxsngq1aBCoqmdSZcX+o=Ef=NyQSeunqDQuo2iwgmOAxsEqDw@mail.gmail.com>
2015-07-25 6:29 ` Christoph Hellwig
2015-07-27 23:25 ` Quinn Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150723094651.GA15301@infradead.org \
--to=hch@infradead.org \
--cc=JBottomley@odin.com \
--cc=Spencer.baugh@purestorage.com \
--cc=bart.vanassche@sandisk.com \
--cc=dilip@purestorage.com \
--cc=joern@purestorage.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=qla2xxx-upstream@qlogic.com \
--cc=sbaugh@catern.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox