The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Swee Hua Law <sweehua81@gmail.com>
To: oleg.drokin@intel.com, andreas.dilger@intel.com,
	gregkh@linuxfoundation.org
Cc: elfring@users.sourceforge.net, linux.kernel@junien.fridrick.net,
	Julia.Lawall@lip6.fr, sweehua81@gmail.com,
	HPDD-discuss@ml01.01.org, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH V2 2/4] staging: lustre: checkpatch: symbol == NULL should be !symbol
Date: Mon, 10 Aug 2015 21:54:16 +0800	[thread overview]
Message-ID: <1439214858-2994-3-git-send-email-sweehua81@gmail.com> (raw)
In-Reply-To: <1439214858-2994-1-git-send-email-sweehua81@gmail.com>

Fix checkpatch problem: change == NULL comparison to !symbol

Signed-off-by: Swee Hua Law <sweehua81@gmail.com>
---
 drivers/staging/lustre/lustre/llite/remote_perm.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/llite/remote_perm.c b/drivers/staging/lustre/lustre/llite/remote_perm.c
index c9a7816..aeda91a 100644
--- a/drivers/staging/lustre/lustre/llite/remote_perm.c
+++ b/drivers/staging/lustre/lustre/llite/remote_perm.c
@@ -184,7 +184,7 @@ int ll_update_remote_perm(struct inode *inode, struct mdt_remote_perm *perm)
 
 	if (!lli->lli_remote_perms) {
 		perm_hash = alloc_rmtperm_hash();
-		if (perm_hash == NULL) {
+		if (!perm_hash) {
 			CERROR("alloc lli_remote_perms failed!\n");
 			return -ENOMEM;
 		}
@@ -287,7 +287,7 @@ int lustre_check_remote_perm(struct inode *inode, int mask)
 
 		perm = req_capsule_server_swab_get(&req->rq_pill, &RMF_ACL,
 						   lustre_swab_mdt_remote_perm);
-		if (unlikely(perm == NULL)) {
+		if (unlikely(!perm)) {
 			mutex_unlock(&lli->lli_rmtperm_mutex);
 			rc = -EPROTO;
 			break;
-- 
2.1.4


  parent reply	other threads:[~2015-08-10 13:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-09 15:48 [PATCH] Fix various coding style problem Swee Hua Law
2015-08-10  4:44 ` Sudip Mukherjee
2015-08-10 13:54 ` [PATCH V2 0/4] staging: lustre: split checkpatch fix for remote_perm.c into series Swee Hua Law
2015-08-10 13:54   ` [PATCH V2 1/4] staging: lustre: checkpatch: do not init global to NULL Swee Hua Law
2015-08-10 13:54   ` Swee Hua Law [this message]
2015-08-10 13:54   ` [PATCH V2 3/4] staging: lustre: checkpatch: move */ block comment to next line Swee Hua Law
2015-08-10 13:54   ` [PATCH V2 4/4] staging: lustre: checkpatch: argument alignment for readability Swee Hua Law

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439214858-2994-3-git-send-email-sweehua81@gmail.com \
    --to=sweehua81@gmail.com \
    --cc=HPDD-discuss@ml01.01.org \
    --cc=Julia.Lawall@lip6.fr \
    --cc=andreas.dilger@intel.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=elfring@users.sourceforge.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux.kernel@junien.fridrick.net \
    --cc=oleg.drokin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox