From: kan.liang@intel.com
To: acme@kernel.org
Cc: jolsa@kernel.org, a.p.zijlstra@chello.nl, mingo@redhat.com,
namhyung@kernel.org, ak@linux.intel.com,
linux-kernel@vger.kernel.org, Kan Liang <kan.liang@intel.com>
Subject: [PATCH RFC 10/10] perf,tools: show counter read result in tui browser title
Date: Tue, 22 Sep 2015 10:13:43 -0400 [thread overview]
Message-ID: <1442931223-51708-11-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1442931223-51708-1-git-send-email-kan.liang@intel.com>
From: Kan Liang <kan.liang@intel.com>
There is no sampling for counter read event, so only show its value on
the browser title in tui mode.
Signed-off-by: Kan Liang <kan.liang@intel.com>
---
tools/perf/ui/browsers/hists.c | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index e1f28f4..1900363 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -1270,12 +1270,22 @@ static int hists__browser_title(struct hists *hists,
size_t buflen = sizeof(buf);
char ref[30] = " show reference callgraph, ";
bool enable_ref = false;
+ int i, idx = 1;
+ struct perf_env *env = evsel->evlist->env;
+ u64 *counter_val = zalloc(evsel->nr_members * sizeof(u64));
if (symbol_conf.filter_relative) {
nr_samples = hists->stats.nr_non_filtered_samples;
nr_events = hists->stats.total_non_filtered_period;
}
+ if (hists->stats.counter_val != NULL) {
+ for (i = 0; i < env->nr_cpus_online; i++) {
+ if ((socket_id < 0) || (env->cpu[i].socket_id == socket_id))
+ counter_val[0] += hists->stats.counter_val[i];
+ }
+ }
+
if (perf_evsel__is_group_event(evsel)) {
struct perf_evsel *pos;
@@ -1292,6 +1302,13 @@ static int hists__browser_title(struct hists *hists,
nr_samples += pos_hists->stats.nr_events[PERF_RECORD_SAMPLE];
nr_events += pos_hists->stats.total_period;
}
+ if (pos_hists->stats.counter_val != NULL) {
+ for (i = 0; i < env->nr_cpus_online; i++) {
+ if ((socket_id < 0) || (env->cpu[i].socket_id == socket_id))
+ counter_val[idx] += pos_hists->stats.counter_val[i];
+ }
+ }
+ idx++;
}
}
@@ -1318,6 +1335,26 @@ static int hists__browser_title(struct hists *hists,
if (socket_id > -1)
printed += scnprintf(bf + printed, size - printed,
", Processor Socket: %d", socket_id);
+
+ if (hists->stats.counter_val != NULL)
+ printed += scnprintf(bf + printed, size - printed,
+ ", %s: %" PRIu64, evsel->name, counter_val[0]);
+
+ if (perf_evsel__is_group_event(evsel)) {
+ struct perf_evsel *pos;
+
+ idx = 1;
+ for_each_group_member(pos, evsel) {
+ const struct hists *pos_hists = evsel__hists(pos);
+
+ if (pos_hists->stats.counter_val != NULL)
+ printed += scnprintf(bf + printed, size - printed,
+ ", %s: %" PRIu64, pos->name, counter_val[idx]);
+ idx++;
+ }
+ }
+ free(counter_val);
+
if (!is_report_browser(hbt)) {
struct perf_top *top = hbt->arg;
--
1.8.3.1
next prev parent reply other threads:[~2015-09-22 21:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 14:13 [PATCH RFC 00/10] counter read during perf sampling kan.liang
2015-09-22 14:13 ` [PATCH RFC 01/10] perf,tools: Add 'C' event/group modifier kan.liang
2015-09-22 14:13 ` [PATCH RFC 02/10] perf,tools: Enable counter statistic read for perf record kan.liang
2015-09-22 14:13 ` [PATCH RFC 03/10] perf,tools: don't validate counter read event kan.liang
2015-09-22 14:13 ` [PATCH RFC 04/10] perf,tools: New RECORD type PERF_RECORD_COUNTER_READ kan.liang
2015-09-22 14:13 ` [PATCH RFC 05/10] perf,tools: record counter statistics during sampling kan.liang
2015-09-22 14:13 ` [PATCH RFC 06/10] perf,tools: option to set counter read interval kan.liang
2015-09-23 18:55 ` Sukadev Bhattiprolu
2015-09-23 19:07 ` Liang, Kan
2015-09-22 14:13 ` [PATCH RFC 07/10] perf,report: handle PERF_RECORD_COUNTER_READ kan.liang
2015-09-22 14:13 ` [PATCH RFC 08/10] perf,tools: store counter val in events_stats kan.liang
2015-09-22 14:13 ` [PATCH RFC 09/10] perf,tools: show counter read result in studio kan.liang
2015-09-22 14:13 ` kan.liang [this message]
2015-09-24 8:19 ` [PATCH RFC 00/10] counter read during perf sampling Jiri Olsa
2015-09-24 19:47 ` Liang, Kan
2015-09-24 22:28 ` Jiri Olsa
2015-09-25 14:57 ` Liang, Kan
2015-09-27 19:57 ` Jiri Olsa
2015-09-28 15:11 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442931223-51708-11-git-send-email-kan.liang@intel.com \
--to=kan.liang@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox