public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: kan.liang@intel.com
To: acme@kernel.org
Cc: jolsa@kernel.org, a.p.zijlstra@chello.nl, mingo@redhat.com,
	namhyung@kernel.org, ak@linux.intel.com,
	linux-kernel@vger.kernel.org, Kan Liang <kan.liang@intel.com>
Subject: [PATCH RFC 05/10] perf,tools: record counter statistics during sampling
Date: Tue, 22 Sep 2015 10:13:38 -0400	[thread overview]
Message-ID: <1442931223-51708-6-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1442931223-51708-1-git-send-email-kan.liang@intel.com>

From: Kan Liang <kan.liang@intel.com>

Reading at the start and the end of sampling, and save the counter
statistics value to PERF_RECORD_COUNTER_READ.

Signed-off-by: Kan Liang <kan.liang@intel.com>
---
 tools/perf/builtin-record.c | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c
index 142eeb3..cc8fd08 100644
--- a/tools/perf/builtin-record.c
+++ b/tools/perf/builtin-record.c
@@ -398,6 +398,40 @@ static struct perf_event_header finished_round_event = {
 	.type = PERF_RECORD_FINISHED_ROUND,
 };
 
+static void process_counter_read_event(struct record *rec, int id,
+				    struct perf_evsel *pos,
+				    struct perf_counts_values *count)
+{
+	union perf_event ev;
+
+	memset(&ev, 0, sizeof(ev));
+	ev.counter_read.header.type = PERF_RECORD_COUNTER_READ;
+	ev.counter_read.header.size = sizeof(ev.counter_read);
+	ev.counter_read.cpu = pos->cpus->map[id];
+	ev.counter_read.idx = pos->idx;
+	memcpy(ev.counter_read.values, count, 3 * sizeof(u64));
+
+	record__write(rec, &ev, sizeof(ev.counter_read));
+}
+
+static void perf_read_counter(struct record *rec)
+{
+	struct perf_evlist *evlist = rec->evlist;
+	struct perf_counts_values count;
+	struct perf_evsel *pos;
+	int cpu;
+
+	evlist__for_each(evlist, pos) {
+		if (!pos->counter_read)
+			continue;
+
+		for (cpu = 0; cpu < cpu_map__nr(pos->cpus); cpu++) {
+			if (!perf_evsel__read(pos, cpu, 0, &count))
+				process_counter_read_event(rec, cpu, pos, &count);
+		}
+	}
+}
+
 static int record__mmap_read_all(struct record *rec)
 {
 	u64 bytes_written = rec->bytes_written;
@@ -644,6 +678,7 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
 		perf_evlist__enable(rec->evlist);
 	}
 
+	perf_read_counter(rec);
 	auxtrace_snapshot_enabled = 1;
 	for (;;) {
 		int hits = rec->samples;
@@ -688,6 +723,7 @@ static int __cmd_record(struct record *rec, int argc, const char **argv)
 		 */
 		if (done && !disabled && !target__none(&opts->target)) {
 			auxtrace_snapshot_enabled = 0;
+			perf_read_counter(rec);
 			perf_evlist__disable(rec->evlist);
 			disabled = true;
 		}
-- 
1.8.3.1


  parent reply	other threads:[~2015-09-22 21:32 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-22 14:13 [PATCH RFC 00/10] counter read during perf sampling kan.liang
2015-09-22 14:13 ` [PATCH RFC 01/10] perf,tools: Add 'C' event/group modifier kan.liang
2015-09-22 14:13 ` [PATCH RFC 02/10] perf,tools: Enable counter statistic read for perf record kan.liang
2015-09-22 14:13 ` [PATCH RFC 03/10] perf,tools: don't validate counter read event kan.liang
2015-09-22 14:13 ` [PATCH RFC 04/10] perf,tools: New RECORD type PERF_RECORD_COUNTER_READ kan.liang
2015-09-22 14:13 ` kan.liang [this message]
2015-09-22 14:13 ` [PATCH RFC 06/10] perf,tools: option to set counter read interval kan.liang
2015-09-23 18:55   ` Sukadev Bhattiprolu
2015-09-23 19:07     ` Liang, Kan
2015-09-22 14:13 ` [PATCH RFC 07/10] perf,report: handle PERF_RECORD_COUNTER_READ kan.liang
2015-09-22 14:13 ` [PATCH RFC 08/10] perf,tools: store counter val in events_stats kan.liang
2015-09-22 14:13 ` [PATCH RFC 09/10] perf,tools: show counter read result in studio kan.liang
2015-09-22 14:13 ` [PATCH RFC 10/10] perf,tools: show counter read result in tui browser title kan.liang
2015-09-24  8:19 ` [PATCH RFC 00/10] counter read during perf sampling Jiri Olsa
2015-09-24 19:47   ` Liang, Kan
2015-09-24 22:28     ` Jiri Olsa
2015-09-25 14:57       ` Liang, Kan
2015-09-27 19:57         ` Jiri Olsa
2015-09-28 15:11           ` Liang, Kan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442931223-51708-6-git-send-email-kan.liang@intel.com \
    --to=kan.liang@intel.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=acme@kernel.org \
    --cc=ak@linux.intel.com \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox