From: kan.liang@intel.com
To: acme@kernel.org
Cc: jolsa@kernel.org, a.p.zijlstra@chello.nl, mingo@redhat.com,
namhyung@kernel.org, ak@linux.intel.com,
linux-kernel@vger.kernel.org, Kan Liang <kan.liang@intel.com>
Subject: [PATCH RFC 08/10] perf,tools: store counter val in events_stats
Date: Tue, 22 Sep 2015 10:13:41 -0400 [thread overview]
Message-ID: <1442931223-51708-9-git-send-email-kan.liang@intel.com> (raw)
In-Reply-To: <1442931223-51708-1-git-send-email-kan.liang@intel.com>
From: Kan Liang <kan.liang@intel.com>
Add a new item counter_val in events_stats to store the total counter
statistics value on each CPU.
The absolate value from counter will be stored in prev_raw_counts. Then
the detla value will be caculated and added into counter_val.
Signed-off-by: Kan Liang <kan.liang@intel.com>
---
tools/perf/builtin-report.c | 40 ++++++++++++++++++++++++++++++++++++++++
tools/perf/util/event.h | 3 +++
2 files changed, 43 insertions(+)
diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
index 1d8dce2..31818bc 100644
--- a/tools/perf/builtin-report.c
+++ b/tools/perf/builtin-report.c
@@ -38,6 +38,8 @@
#include "util/auxtrace.h"
+#include "util/stat.h"
+
#include <dlfcn.h>
#include <linux/bitmap.h>
@@ -213,12 +215,33 @@ static int process_counter_read_event(struct perf_tool *tool __maybe_unused,
{
struct perf_evlist *evlist = session->evlist;
struct perf_evsel *evsel;
+ int cpu_nr = session->header.env.nr_cpus_online;
+ u32 cpu = event->counter_read.cpu;
+ struct hists *evsel_hists;
evlist__for_each(evlist, evsel) {
if (evsel->idx == event->counter_read.idx)
break;
}
+ if (evsel->prev_raw_counts == NULL) {
+ if (perf_evsel__alloc_prev_raw_counts(evsel, cpu_nr, 1))
+ return -ENOMEM;
+ }
+
+ evsel_hists = evsel__hists(evsel);
+ if (evsel_hists->stats.counter_val == NULL) {
+ evsel_hists->stats.counter_val = zalloc(cpu_nr * sizeof(u64));
+ if (evsel_hists->stats.counter_val == NULL) {
+ perf_evsel__free_prev_raw_counts(evsel);
+ return -ENOMEM;
+ }
+ }
+ evsel_hists->stats.counter_val[cpu] +=
+ event->counter_read.val - perf_counts(evsel->prev_raw_counts, cpu, 0)->val;
+
+ perf_counts(evsel->prev_raw_counts, cpu, 0)->val = event->counter_read.val;
+
hists__inc_nr_events(evsel__hists(evsel), event->header.type);
dump_printf(": %s CPU %d: val %" PRIu64 " ena %" PRIu64 " run %" PRIu64 " \n",
@@ -632,6 +655,21 @@ parse_percent_limit(const struct option *opt, const char *str,
return 0;
}
+static void
+free_counter_read(struct perf_evlist *evlist)
+{
+ struct perf_evsel *evsel;
+ struct hists *evsel_hists;
+
+ evlist__for_each(evlist, evsel) {
+ evsel_hists = evsel__hists(evsel);
+ if (evsel_hists->stats.counter_val != NULL)
+ zfree(&evsel_hists->stats.counter_val);
+ if (evsel->prev_raw_counts != NULL)
+ perf_evsel__free_prev_raw_counts(evsel);
+ }
+}
+
int cmd_report(int argc, const char **argv, const char *prefix __maybe_unused)
{
struct perf_session *session;
@@ -946,12 +984,14 @@ repeat:
ret = __cmd_report(&report);
if (ret == K_SWITCH_INPUT_DATA) {
+ free_counter_read(session->evlist);
perf_session__delete(session);
goto repeat;
} else
ret = 0;
error:
+ free_counter_read(session->evlist);
perf_session__delete(session);
return ret;
}
diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
index 7f125ce..c8a663a 100644
--- a/tools/perf/util/event.h
+++ b/tools/perf/util/event.h
@@ -252,6 +252,8 @@ enum auxtrace_error_type {
* multipling nr_events[PERF_EVENT_SAMPLE] by a frequency isn't possible to get
* the total number of low level events, it is necessary to to sum all struct
* sample_event.period and stash the result in total_period.
+ *
+ * counter_val is used to store the counter statistics value on each CPU
*/
struct events_stats {
u64 total_period;
@@ -268,6 +270,7 @@ struct events_stats {
u32 nr_unprocessable_samples;
u32 nr_auxtrace_errors[PERF_AUXTRACE_ERROR_MAX];
u32 nr_proc_map_timeout;
+ u64 *counter_val;
};
struct attr_event {
--
1.8.3.1
next prev parent reply other threads:[~2015-09-22 21:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 14:13 [PATCH RFC 00/10] counter read during perf sampling kan.liang
2015-09-22 14:13 ` [PATCH RFC 01/10] perf,tools: Add 'C' event/group modifier kan.liang
2015-09-22 14:13 ` [PATCH RFC 02/10] perf,tools: Enable counter statistic read for perf record kan.liang
2015-09-22 14:13 ` [PATCH RFC 03/10] perf,tools: don't validate counter read event kan.liang
2015-09-22 14:13 ` [PATCH RFC 04/10] perf,tools: New RECORD type PERF_RECORD_COUNTER_READ kan.liang
2015-09-22 14:13 ` [PATCH RFC 05/10] perf,tools: record counter statistics during sampling kan.liang
2015-09-22 14:13 ` [PATCH RFC 06/10] perf,tools: option to set counter read interval kan.liang
2015-09-23 18:55 ` Sukadev Bhattiprolu
2015-09-23 19:07 ` Liang, Kan
2015-09-22 14:13 ` [PATCH RFC 07/10] perf,report: handle PERF_RECORD_COUNTER_READ kan.liang
2015-09-22 14:13 ` kan.liang [this message]
2015-09-22 14:13 ` [PATCH RFC 09/10] perf,tools: show counter read result in studio kan.liang
2015-09-22 14:13 ` [PATCH RFC 10/10] perf,tools: show counter read result in tui browser title kan.liang
2015-09-24 8:19 ` [PATCH RFC 00/10] counter read during perf sampling Jiri Olsa
2015-09-24 19:47 ` Liang, Kan
2015-09-24 22:28 ` Jiri Olsa
2015-09-25 14:57 ` Liang, Kan
2015-09-27 19:57 ` Jiri Olsa
2015-09-28 15:11 ` Liang, Kan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1442931223-51708-9-git-send-email-kan.liang@intel.com \
--to=kan.liang@intel.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox