* checkpatch: GIT_COMMIT_ID rule catches 'cherry picked from commit <sha1>' lines
@ 2015-11-26 2:15 Shawn N
2015-11-26 5:56 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Shawn N @ 2015-11-26 2:15 UTC (permalink / raw)
To: joe; +Cc: linux-kernel
Hello,
The checkpatch.pl GIT_COMMIT_ID rule appears to be designed to enforce
a minimum description when citing patches: 'commit <12+ chars of sha1>
(\"<title line>\")'. One (unintended?) consequence of this rule is
that unmodified 'cherry picked from commit <sha1>' (git cherry-pick
-x) lines are flagged.
- Is the disallowing of 'cherry picked from commit <sha1>' lines by
GIT_COMMIT_ID working as intended?
- If yes, would it be acceptable to instead add a new rule with
clearer error output ("Don't include git cherry-pick -x description
lines")?
- If no (and such lines are actually acceptable) then I will just
patch the GIT_COMMIT_ID rule.
Thanks,
Shawn
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: checkpatch: GIT_COMMIT_ID rule catches 'cherry picked from commit <sha1>' lines
2015-11-26 2:15 checkpatch: GIT_COMMIT_ID rule catches 'cherry picked from commit <sha1>' lines Shawn N
@ 2015-11-26 5:56 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2015-11-26 5:56 UTC (permalink / raw)
To: Shawn N; +Cc: linux-kernel, Andrew Morton, Andy Whitcroft
On Wed, 2015-11-25 at 18:15 -0800, Shawn N wrote:
> Hello,
>
> The checkpatch.pl GIT_COMMIT_ID rule appears to be designed to enforce
> a minimum description when citing patches: 'commit <12+ chars of sha1>
> (\"\")'. One (unintended?) consequence of this rule is
> that unmodified 'cherry picked from commit ' (git cherry-pick
> -x) lines are flagged.
>
> - Is the disallowing of 'cherry picked from commit ' lines by
> GIT_COMMIT_ID working as intended?
> - If yes, would it be acceptable to instead add a new rule with
> clearer error output ("Don't include git cherry-pick -x description
> lines")?
> - If no (and such lines are actually acceptable) then I will just
> patch the GIT_COMMIT_ID rule.
>
> Thanks,
>
> Shawn
I think sha1 commit ids should always be followed by a
git commit description.
If that's not the general consensus, it's pretty easy
to change.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-26 5:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-11-26 2:15 checkpatch: GIT_COMMIT_ID rule catches 'cherry picked from commit <sha1>' lines Shawn N
2015-11-26 5:56 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox