From: Chris Phlipot <cphlipot0@gmail.com>
To: adrian.hunter@intel.com, acme@kernel.org, peterz@infradead.org,
mingo@redhat.com
Cc: linux-kernel@vger.kernel.org, Chris Phlipot <cphlipot0@gmail.com>
Subject: [PATCH v2 2/4] perf script: fix symbol insertion behavior in db-export
Date: Tue, 10 May 2016 20:26:47 -0700 [thread overview]
Message-ID: <1462937209-6032-3-git-send-email-cphlipot0@gmail.com> (raw)
In-Reply-To: <1462937209-6032-1-git-send-email-cphlipot0@gmail.com>
Use the dso__insert_symbol function instead of symbols__insert in order to
properly update the dso symbol cache.
If the cache is not updated, then duplicate symbols can be unintentionally
created, inserted, and exported.
This change prevents duplicate symbols from being exported due to
dso__find_symbol using a stale symbol cache.
Signed-off-by: Chris Phlipot <cphlipot0@gmail.com>
---
tools/perf/util/db-export.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/tools/perf/util/db-export.c b/tools/perf/util/db-export.c
index f8e3057..2ef1f69 100644
--- a/tools/perf/util/db-export.c
+++ b/tools/perf/util/db-export.c
@@ -260,8 +260,7 @@ static int db_ids_from_al(struct db_export *dbe, struct addr_location *al,
if (!al->sym) {
al->sym = symbol__new(al->addr, 0, 0, "unknown");
if (al->sym)
- symbols__insert(&dso->symbols[al->map->type],
- al->sym);
+ dso__insert_symbol(dso, al->map->type, al->sym);
}
if (al->sym) {
--
2.7.4
next prev parent reply other threads:[~2016-05-11 3:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 3:26 [PATCH v2 0/4] perf script: fix duplicate symbols in db-export Chris Phlipot
2016-05-11 3:26 ` [PATCH v2 1/4] perf symbols: add dso__insert_symbol function Chris Phlipot
2016-05-12 10:22 ` [tip:perf/core] perf symbols: Add " tip-bot for Chris Phlipot
2016-05-11 3:26 ` Chris Phlipot [this message]
2016-05-12 10:22 ` [tip:perf/core] perf script: Fix symbol insertion behavior in db-export tip-bot for Chris Phlipot
2016-05-11 3:26 ` [PATCH v2 3/4] perf script: fix callchain addresses " Chris Phlipot
2016-05-12 10:22 ` [tip:perf/core] perf script: Fix " tip-bot for Chris Phlipot
2016-05-11 3:26 ` [PATCH v2 4/4] perf script: fix export of callchains with recursion " Chris Phlipot
2016-05-12 10:23 ` [tip:perf/core] perf script: Fix " tip-bot for Chris Phlipot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462937209-6032-3-git-send-email-cphlipot0@gmail.com \
--to=cphlipot0@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox