From: Chris Phlipot <cphlipot0@gmail.com>
To: adrian.hunter@intel.com, acme@kernel.org, peterz@infradead.org,
mingo@redhat.com
Cc: linux-kernel@vger.kernel.org, Chris Phlipot <cphlipot0@gmail.com>
Subject: [PATCH v2 3/4] perf script: fix callchain addresses in db-export
Date: Tue, 10 May 2016 20:26:48 -0700 [thread overview]
Message-ID: <1462937209-6032-4-git-send-email-cphlipot0@gmail.com> (raw)
In-Reply-To: <1462937209-6032-1-git-send-email-cphlipot0@gmail.com>
Remove the call to map_ip, because it has already been called when
assembling the callchain. Calling it a second time can result in incorrect
addresses being used. This can have effects such as duplicate symbols
being created and exported.
Signed-off-by: Chris Phlipot <cphlipot0@gmail.com>
---
tools/perf/util/db-export.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/tools/perf/util/db-export.c b/tools/perf/util/db-export.c
index 2ef1f69..8ca4186 100644
--- a/tools/perf/util/db-export.c
+++ b/tools/perf/util/db-export.c
@@ -324,10 +324,7 @@ static struct call_path *call_path_from_sample(struct db_export *dbe,
al.sym = node->sym;
al.map = node->map;
al.machine = machine;
- if (al.map)
- al.addr = al.map->map_ip(al.map, node->ip);
- else
- al.addr = node->ip;
+ al.addr = node->ip;
db_ids_from_al(dbe, &al, &dso_db_id, &sym_db_id, &offset);
--
2.7.4
next prev parent reply other threads:[~2016-05-11 3:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 3:26 [PATCH v2 0/4] perf script: fix duplicate symbols in db-export Chris Phlipot
2016-05-11 3:26 ` [PATCH v2 1/4] perf symbols: add dso__insert_symbol function Chris Phlipot
2016-05-12 10:22 ` [tip:perf/core] perf symbols: Add " tip-bot for Chris Phlipot
2016-05-11 3:26 ` [PATCH v2 2/4] perf script: fix symbol insertion behavior in db-export Chris Phlipot
2016-05-12 10:22 ` [tip:perf/core] perf script: Fix " tip-bot for Chris Phlipot
2016-05-11 3:26 ` Chris Phlipot [this message]
2016-05-12 10:22 ` [tip:perf/core] perf script: Fix callchain addresses " tip-bot for Chris Phlipot
2016-05-11 3:26 ` [PATCH v2 4/4] perf script: fix export of callchains with recursion " Chris Phlipot
2016-05-12 10:23 ` [tip:perf/core] perf script: Fix " tip-bot for Chris Phlipot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462937209-6032-4-git-send-email-cphlipot0@gmail.com \
--to=cphlipot0@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox