From: Chris Phlipot <cphlipot0@gmail.com>
To: adrian.hunter@intel.com, acme@kernel.org, peterz@infradead.org,
mingo@redhat.com
Cc: linux-kernel@vger.kernel.org, Chris Phlipot <cphlipot0@gmail.com>
Subject: [PATCH v2 4/4] perf script: fix export of callchains with recursion in db-export
Date: Tue, 10 May 2016 20:26:49 -0700 [thread overview]
Message-ID: <1462937209-6032-5-git-send-email-cphlipot0@gmail.com> (raw)
In-Reply-To: <1462937209-6032-1-git-send-email-cphlipot0@gmail.com>
When an IP with an unresolved symbol occurs in the callchain more than
once (ie. recursion), then duplicate symbols can be created because
the callchain nodes are never updated after they are first created.
To fix this issue we call dso__find_symbol whenever we encounter a NULL
symbol, in case we already added a symbol at that IP since we started
traversing the callchain.
This change prevents duplicate symbols from being exported when duplicate
IPs are present in the callchain.
Signed-off-by: Chris Phlipot <cphlipot0@gmail.com>
---
tools/perf/util/db-export.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/tools/perf/util/db-export.c b/tools/perf/util/db-export.c
index 8ca4186..8d96c80 100644
--- a/tools/perf/util/db-export.c
+++ b/tools/perf/util/db-export.c
@@ -326,6 +326,10 @@ static struct call_path *call_path_from_sample(struct db_export *dbe,
al.machine = machine;
al.addr = node->ip;
+ if (al.map && !al.sym)
+ al.sym = dso__find_symbol(al.map->dso, MAP__FUNCTION,
+ al.addr);
+
db_ids_from_al(dbe, &al, &dso_db_id, &sym_db_id, &offset);
/* add node to the call path tree if it doesn't exist */
--
2.7.4
next prev parent reply other threads:[~2016-05-11 3:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 3:26 [PATCH v2 0/4] perf script: fix duplicate symbols in db-export Chris Phlipot
2016-05-11 3:26 ` [PATCH v2 1/4] perf symbols: add dso__insert_symbol function Chris Phlipot
2016-05-12 10:22 ` [tip:perf/core] perf symbols: Add " tip-bot for Chris Phlipot
2016-05-11 3:26 ` [PATCH v2 2/4] perf script: fix symbol insertion behavior in db-export Chris Phlipot
2016-05-12 10:22 ` [tip:perf/core] perf script: Fix " tip-bot for Chris Phlipot
2016-05-11 3:26 ` [PATCH v2 3/4] perf script: fix callchain addresses " Chris Phlipot
2016-05-12 10:22 ` [tip:perf/core] perf script: Fix " tip-bot for Chris Phlipot
2016-05-11 3:26 ` Chris Phlipot [this message]
2016-05-12 10:23 ` [tip:perf/core] perf script: Fix export of callchains with recursion " tip-bot for Chris Phlipot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462937209-6032-5-git-send-email-cphlipot0@gmail.com \
--to=cphlipot0@gmail.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox