From: Joe Perches <joe@perches.com>
To: "SF Markus Elfring" <elfring@users.sourceforge.net>,
linux-input@vger.kernel.org,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
"Bruno Prémont" <bonbons@linux-vserver.org>,
"Jiri Kosina" <jikos@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 13/18] HID-debug: Combine 11 seq_printf() calls into one call in hid_dump_field()
Date: Tue, 07 Feb 2017 14:52:58 -0800 [thread overview]
Message-ID: <1486507978.27834.3.camel@perches.com> (raw)
In-Reply-To: <99abe158-ba41-99eb-95e1-e9aed7bafb53@users.sourceforge.net>
On Tue, 2017-02-07 at 20:56 +0100, SF Markus Elfring wrote:
> diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c
[]
> @@ -614,19 +614,18 @@ void hid_dump_field(struct hid_field *field, int n, struct seq_file *f) {
> tab(n, f); seq_printf(f, "Report Size(%u)\n", field->report_size);
> tab(n, f); seq_printf(f, "Report Count(%u)\n", field->report_count);
> tab(n, f); seq_printf(f, "Report Offset(%u)\n", field->report_offset);
> -
> - tab(n, f); seq_printf(f, "Flags( ");
> + tab(n, f);
Consider converting tab(n, f) to seq_indent(f, n)
making seq_indent a global function or maybe using
a new name like seq_spaces, and converting the
existing uses in net/ipv4/fib_trie.c appropriately.
next prev parent reply other threads:[~2017-02-07 22:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-07 19:36 [PATCH 00/18] HID: Fine-tuning for several function implementations SF Markus Elfring
2017-02-07 19:39 ` [PATCH 01/18] HID: Use kmalloc_array() in hid_input_field() SF Markus Elfring
2017-02-07 19:40 ` [PATCH 02/18] HID: Delete an error message for a failed memory allocation in open_collection() SF Markus Elfring
2017-02-07 19:42 ` [PATCH 03/18] HID: Use kmalloc_array() " SF Markus Elfring
2017-02-07 19:43 ` [PATCH 04/18] HID: Improve another size determination " SF Markus Elfring
2017-02-07 19:46 ` [PATCH 05/18] HID: Improve two size determinations in hid_open_report() SF Markus Elfring
2017-02-07 19:48 ` [PATCH 06/18] HID: Improve another size determination in hid_scan_report() SF Markus Elfring
2017-02-07 19:49 ` [PATCH 07/18] HID: Improve another size determination in hid_register_report() SF Markus Elfring
2017-02-07 19:50 ` [PATCH 08/18] HID: Adjust five checks for null pointers SF Markus Elfring
2017-02-07 19:51 ` [PATCH 09/18] HID: Return an error code only as a constant in hid_allocate_device() SF Markus Elfring
2017-02-07 19:52 ` [PATCH 10/18] HID-debug: Replace five seq_printf() calls by seq_putc() SF Markus Elfring
2017-02-07 19:54 ` [PATCH 11/18] HID-debug: Delete an unnecessary seq_printf() call in hid_dump_device() SF Markus Elfring
2017-02-07 19:55 ` [PATCH 12/18] HID-debug: Replace 12 seq_printf() calls by seq_puts() SF Markus Elfring
2017-02-07 19:56 ` [PATCH 13/18] HID-debug: Combine 11 seq_printf() calls into one call in hid_dump_field() SF Markus Elfring
2017-02-07 22:52 ` Joe Perches [this message]
2017-02-07 19:57 ` [PATCH 14/18] HID-debug: Adjust two function calls together with a variable assignment SF Markus Elfring
2017-02-07 19:58 ` [PATCH 15/18] HID-debug: Return an error code only as a constant in hid_debug_events_open() SF Markus Elfring
2017-02-07 19:59 ` [PATCH 16/18] HID-debug: Add some spaces for better code readability SF Markus Elfring
2017-02-07 20:00 ` [PATCH 17/18] HID-debug: Delete an unnecessary variable initialisation in hid_resolv_usage() SF Markus Elfring
2017-02-07 20:01 ` [PATCH 18/18] HID-picoLCD: Use seq_puts() in picolcd_debug_reset_show() SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1486507978.27834.3.camel@perches.com \
--to=joe@perches.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bonbons@linux-vserver.org \
--cc=elfring@users.sourceforge.net \
--cc=jikos@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox