From: Joe Perches <joe@perches.com>
To: Brian Norris <briannorris@chromium.org>,
Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Herbert Xu <herbert@gondor.apana.org.au>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] checkpatch: don't encourage new code to use "networking" style comments
Date: Fri, 28 Apr 2017 11:24:18 -0700 [thread overview]
Message-ID: <1493403858.1873.5.camel@perches.com> (raw)
In-Reply-To: <20170428175547.61114-1-briannorris@chromium.org>
On Fri, 2017-04-28 at 10:55 -0700, Brian Norris wrote:
> Our glorious leader has made his opinion known [1]: the "networking"
> comment style is not useful for new code.
<shrug> and yet nothing was done.
I think _very_ few people concern themselves one way
or another.
I believe the only person that actually cares about
the networking
comment style is David Miller.
> While the same rules as usual
> still apply -- e.g., don't unnecessarily churn existing code, and follow
> existing practice within files -- that doesn't mean that checkpatch
> should be enforcing that for entire directories. Among other reasons,
> this can cause automatic patch generators to do the exact wrong thing:
> convert perfectly good existing code into the "networking style", just
> because it's in a similar directory.
I believe the patch generator you are referring to is
checkpatch.
And checkpatch doesn't actually offer to "--fix" any
comment style. It just bleats a message.
I don't know of another tool that proposes patches
that vary comment styles based on directory.
next prev parent reply other threads:[~2017-04-28 18:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 17:55 [PATCH] checkpatch: don't encourage new code to use "networking" style comments Brian Norris
2017-04-28 18:24 ` Joe Perches [this message]
2017-04-28 19:27 ` Brian Norris
2017-04-28 19:31 ` David Miller
2017-04-28 19:51 ` Brian Norris
2017-04-28 21:05 ` Joe Perches
2017-04-28 19:36 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493403858.1873.5.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=briannorris@chromium.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox