From: Joe Perches <joe@perches.com>
To: Brian Norris <briannorris@chromium.org>,
David Miller <davem@davemloft.net>
Cc: apw@canonical.com, linux-kernel@vger.kernel.org,
herbert@gondor.apana.org.au, mingo@redhat.com,
akpm@linux-foundation.org
Subject: Re: [PATCH] checkpatch: don't encourage new code to use "networking" style comments
Date: Fri, 28 Apr 2017 14:05:18 -0700 [thread overview]
Message-ID: <1493413518.1873.9.camel@perches.com> (raw)
In-Reply-To: <20170428195131.GA73503@google.com>
On Fri, 2017-04-28 at 12:51 -0700, Brian Norris wrote:
> FWIW, I don't see this consistently applied at all. Unless my regexes
> are completely wrong [*], it's roughly 50/50 in drivers/net/ and net/,
> and roughly 40/60 (favoring "net" style) in net/core/.
More like 5:1 in net/
$ git grep -E -n "/\*[ \t]*\w" net | grep -v ":1:" | wc -l
30461
$ git grep -E -n "/\*[ \t]*$" net | grep -v ":1:" | wc -l
6061
grep -v ":1:" is to avoid the first line in the file comment
next prev parent reply other threads:[~2017-04-28 21:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-28 17:55 [PATCH] checkpatch: don't encourage new code to use "networking" style comments Brian Norris
2017-04-28 18:24 ` Joe Perches
2017-04-28 19:27 ` Brian Norris
2017-04-28 19:31 ` David Miller
2017-04-28 19:51 ` Brian Norris
2017-04-28 21:05 ` Joe Perches [this message]
2017-04-28 19:36 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1493413518.1873.9.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=briannorris@chromium.org \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox