From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "bp@alien8.de" <bp@alien8.de>
Cc: "mchehab@infradead.org" <mchehab@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>
Subject: Re: [PATCH 3/3] EDAC, ghes: Make it a proper module
Date: Mon, 31 Jul 2017 20:19:32 +0000 [thread overview]
Message-ID: <1501531803.2042.95.camel@hpe.com> (raw)
In-Reply-To: <20170729064715.GB30603@nazgul.tnic>
On Sat, 2017-07-29 at 08:47 +0200, Borislav Petkov wrote:
> On Fri, Jul 28, 2017 at 06:50:56PM +0000, Kani, Toshimitsu wrote:
> > This simply sets NULL to pvt, and does not initialize ghes_pvt.
>
> Yeah, I guess we need this ontop:
Yes, this fix looks good.
> > As Mauro pointed out, some type of GHES check needs to be in place
> > before making this change.
>
> Your whitelist I guess.
We still need the two mechanisms provided by the existing code below.
The whitelist simply compliments 1.
1. GHES-presence check. (We can add APEI OSC bit check as well.)
2. Module priority. ghes_edac has higher priority for registration.
I'd prefer to add the whitelist check to ghes_edac first. This makes
the existing code to work. We can then work on refactoring changes
like this on top of it without breaking the functionality.
Thanks,
-Toshi
next prev parent reply other threads:[~2017-07-31 20:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 8:48 [PATCH 0/3] EDAC: Convert ghes_edac to a normal module Borislav Petkov
2017-07-26 8:48 ` [PATCH 1/3] EDAC: Add edac_pr_err/info macros Borislav Petkov
2017-07-26 8:48 ` [PATCH 2/3] ACPI/GHES: Add an EDAC notifier chain Borislav Petkov
2017-07-26 8:48 ` [PATCH 3/3] EDAC, ghes: Make it a proper module Borislav Petkov
2017-07-26 10:24 ` Mauro Carvalho Chehab
2017-07-26 10:37 ` Borislav Petkov
2017-07-26 10:51 ` Mauro Carvalho Chehab
2017-07-26 17:27 ` Luck, Tony
2017-07-26 18:17 ` Mauro Carvalho Chehab
2017-07-26 19:24 ` Kani, Toshimitsu
2017-07-27 5:20 ` Borislav Petkov
2017-07-26 19:49 ` Kani, Toshimitsu
2017-07-28 18:50 ` Kani, Toshimitsu
2017-07-29 6:47 ` Borislav Petkov
2017-07-31 20:19 ` Kani, Toshimitsu [this message]
2017-08-01 9:46 ` Borislav Petkov
2017-08-02 0:19 ` Kani, Toshimitsu
2017-08-02 3:18 ` Borislav Petkov
2017-08-02 22:41 ` Kani, Toshimitsu
2017-07-27 5:54 ` [PATCH 0/3] EDAC: Convert ghes_edac to a normal module Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1501531803.2042.95.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox