From: Borislav Petkov <bp@alien8.de>
To: "Kani, Toshimitsu" <toshi.kani@hpe.com>
Cc: "mchehab@infradead.org" <mchehab@infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"tony.luck@intel.com" <tony.luck@intel.com>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
"rjw@rjwysocki.net" <rjw@rjwysocki.net>
Subject: Re: [PATCH 3/3] EDAC, ghes: Make it a proper module
Date: Tue, 1 Aug 2017 11:46:12 +0200 [thread overview]
Message-ID: <20170801094612.GA18647@nazgul.tnic> (raw)
In-Reply-To: <1501531803.2042.95.camel@hpe.com>
On Mon, Jul 31, 2017 at 08:19:32PM +0000, Kani, Toshimitsu wrote:
> I'd prefer to add the whitelist check to ghes_edac first. This makes
> the existing code to work. We can then work on refactoring changes
> like this on top of it without breaking the functionality.
Yes, but we want only the whitelist - not the FF testing because, as we
said, BIOS is notoriously buggy so we're going to load ghes_edac only on
known-good platforms.
Which brings the question about the priority.
And I *think* the easiest would be if the whitelist were in the core
edac.ko module, perhaps in edac_module.c (even though it doesn't really
matter, technically).
There we can set a "use_ghes" or so bool which the x86 platform drivers
would query through accessor functions and determine whether to load or
not.
In any case, something like that. I'm always open for better
suggestions, though.
I've pushed a rebased branch here:
https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=ghes
feel free to base your changes ontop.
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
next prev parent reply other threads:[~2017-08-01 9:46 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 8:48 [PATCH 0/3] EDAC: Convert ghes_edac to a normal module Borislav Petkov
2017-07-26 8:48 ` [PATCH 1/3] EDAC: Add edac_pr_err/info macros Borislav Petkov
2017-07-26 8:48 ` [PATCH 2/3] ACPI/GHES: Add an EDAC notifier chain Borislav Petkov
2017-07-26 8:48 ` [PATCH 3/3] EDAC, ghes: Make it a proper module Borislav Petkov
2017-07-26 10:24 ` Mauro Carvalho Chehab
2017-07-26 10:37 ` Borislav Petkov
2017-07-26 10:51 ` Mauro Carvalho Chehab
2017-07-26 17:27 ` Luck, Tony
2017-07-26 18:17 ` Mauro Carvalho Chehab
2017-07-26 19:24 ` Kani, Toshimitsu
2017-07-27 5:20 ` Borislav Petkov
2017-07-26 19:49 ` Kani, Toshimitsu
2017-07-28 18:50 ` Kani, Toshimitsu
2017-07-29 6:47 ` Borislav Petkov
2017-07-31 20:19 ` Kani, Toshimitsu
2017-08-01 9:46 ` Borislav Petkov [this message]
2017-08-02 0:19 ` Kani, Toshimitsu
2017-08-02 3:18 ` Borislav Petkov
2017-08-02 22:41 ` Kani, Toshimitsu
2017-07-27 5:54 ` [PATCH 0/3] EDAC: Convert ghes_edac to a normal module Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801094612.GA18647@nazgul.tnic \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=toshi.kani@hpe.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox