public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@alien8.de>
To: linux-edac <linux-edac@vger.kernel.org>
Cc: Tony Luck <tony.luck@intel.com>,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	Toshimitsu Kani <toshi.kani@hpe.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH 0/3] EDAC: Convert ghes_edac to a normal module
Date: Wed, 26 Jul 2017 10:48:24 +0200	[thread overview]
Message-ID: <20170726084827.11447-1-bp@alien8.de> (raw)

From: Borislav Petkov <bp@suse.de>

Hi,

here's the conversion of ghes_edac to a proper module using a notifier.
This is only the bare minimum stuff and we should do all outstanding
work ontop. Which right now is:

* platform whitelist

* Tony: "Additional cleanup: edac_ghes.c should really call
cper_mem_err_location() instead of doing pretty much the same thing but
with subtle formatting differences ("node:%d" vs. "node: %d")."

Yes, I think we should take a look at doing that eventually as a
sensible cleanup.

* Tony: "This driver isn't going to set the EDAC error counts since it
just does:

        e->top_layer = -1;
        e->mid_layer = -1;
        e->low_layer = -1;
"

Right, that we should address by making layer 0 EDAC_MC_LAYER_SLOT and
no other layers as we can't get any channel, branch or whatever DIMM
topology from GHES. At least I'm not aware of any.

But that should be enough as this info is good enough for pinpointing
the DIMM. From our discussion with Tony:

>>  The FRU identifier is:
>>
>> "The module number of the memory error location. (NODE, CARD, and MODULE
>> should provide the information necessary to identify the failing FRU)."
>
> Sounds pretty good. Generally people don't care about the channel. They
> want to know which DIMM to replace. This will give them what they want.

Thanks.

Borislav Petkov (3):
  EDAC: Add edac_pr_err/info macros
  ACPI/GHES: Add an EDAC notifier chain
  EDAC, ghes: Make it a proper module

 drivers/acpi/apei/ghes.c |  32 +++++++-----
 drivers/edac/Kconfig     |   4 +-
 drivers/edac/edac_mc.h   |   3 ++
 drivers/edac/ghes_edac.c | 129 ++++++++++++++++++++++++-----------------------
 include/acpi/ghes.h      |  27 +---------
 5 files changed, 93 insertions(+), 102 deletions(-)

-- 
2.14.0.rc0

             reply	other threads:[~2017-07-26  8:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26  8:48 Borislav Petkov [this message]
2017-07-26  8:48 ` [PATCH 1/3] EDAC: Add edac_pr_err/info macros Borislav Petkov
2017-07-26  8:48 ` [PATCH 2/3] ACPI/GHES: Add an EDAC notifier chain Borislav Petkov
2017-07-26  8:48 ` [PATCH 3/3] EDAC, ghes: Make it a proper module Borislav Petkov
2017-07-26 10:24   ` Mauro Carvalho Chehab
2017-07-26 10:37     ` Borislav Petkov
2017-07-26 10:51       ` Mauro Carvalho Chehab
2017-07-26 17:27         ` Luck, Tony
2017-07-26 18:17           ` Mauro Carvalho Chehab
2017-07-26 19:24             ` Kani, Toshimitsu
2017-07-27  5:20               ` Borislav Petkov
2017-07-26 19:49     ` Kani, Toshimitsu
2017-07-28 18:50   ` Kani, Toshimitsu
2017-07-29  6:47     ` Borislav Petkov
2017-07-31 20:19       ` Kani, Toshimitsu
2017-08-01  9:46         ` Borislav Petkov
2017-08-02  0:19           ` Kani, Toshimitsu
2017-08-02  3:18             ` Borislav Petkov
2017-08-02 22:41               ` Kani, Toshimitsu
2017-07-27  5:54 ` [PATCH 0/3] EDAC: Convert ghes_edac to a normal module Borislav Petkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170726084827.11447-1-bp@alien8.de \
    --to=bp@alien8.de \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=rjw@rjwysocki.net \
    --cc=tony.luck@intel.com \
    --cc=toshi.kani@hpe.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox