* [PATCH 0/5] staging: rtl8712: fix several checkpatch style issues
[not found] <c673a9e2-494d-c2f0-a0bd-3422ec76231d@martinhomuth.de>
@ 2017-12-18 20:36 ` Martin Homuth
2017-12-18 21:21 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Martin Homuth @ 2017-12-18 20:36 UTC (permalink / raw)
To: linux-kernel
This patch series fixes some coding style issues reported by checkpatch.pl.
It is based on next-20171218
Martin Homuth (5):
staging: rtl8712: style fix over 80 characters warnings
staging: rtl8712: style fix multiple line dereferences
staging: rtl8712: style fix indentation
staging: rtl8712: style fix unneeded else
staging: rtl8712: style fix returned error code
drivers/staging/rtl8712/ieee80211.c | 6 ++-
drivers/staging/rtl8712/os_intfs.c | 5 +-
drivers/staging/rtl8712/rtl8712_cmd.c | 18 ++++---
drivers/staging/rtl8712/rtl8712_recv.c | 8 +--
drivers/staging/rtl8712/rtl8712_xmit.c | 3 +-
drivers/staging/rtl8712/rtl871x_cmd.c | 36 +++++++-------
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 72
++++++++++++++-------------
drivers/staging/rtl8712/rtl871x_ioctl_set.c | 72
+++++++++++++--------------
drivers/staging/rtl8712/rtl871x_mlme.c | 6 +--
drivers/staging/rtl8712/rtl871x_mlme.h | 3 +-
drivers/staging/rtl8712/rtl871x_security.c | 37 +++++++-------
drivers/staging/rtl8712/usb_ops_linux.c | 2 +-
12 files changed, 140 insertions(+), 128 deletions(-)
--
2.15.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH 0/5] staging: rtl8712: fix several checkpatch style issues
2017-12-18 20:36 ` [PATCH 0/5] staging: rtl8712: fix several checkpatch style issues Martin Homuth
@ 2017-12-18 21:21 ` Joe Perches
2017-12-18 22:17 ` Martin Homuth
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2017-12-18 21:21 UTC (permalink / raw)
To: Martin Homuth, linux-kernel
On Mon, 2017-12-18 at 21:36 +0100, Martin Homuth wrote:
> This patch series fixes some coding style issues reported by checkpatch.pl.
>
> It is based on next-20171218
>
> Martin Homuth (5):
> staging: rtl8712: style fix over 80 characters warnings
> staging: rtl8712: style fix multiple line dereferences
> staging: rtl8712: style fix indentation
> staging: rtl8712: style fix unneeded else
> staging: rtl8712: style fix returned error code
>
> drivers/staging/rtl8712/ieee80211.c | 6 ++-
> drivers/staging/rtl8712/os_intfs.c | 5 +-
> drivers/staging/rtl8712/rtl8712_cmd.c | 18 ++++---
> drivers/staging/rtl8712/rtl8712_recv.c | 8 +--
> drivers/staging/rtl8712/rtl8712_xmit.c | 3 +-
> drivers/staging/rtl8712/rtl871x_cmd.c | 36 +++++++-------
> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 72
> ++++++++++++++-------------
This line wrapping is generally an indication that your email
client (thunderbird 52.5.0) is wrapping all patches.
If you can, use git send-email instead
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/5] staging: rtl8712: fix several checkpatch style issues
2017-12-18 21:21 ` Joe Perches
@ 2017-12-18 22:17 ` Martin Homuth
2017-12-18 22:28 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Martin Homuth @ 2017-12-18 22:17 UTC (permalink / raw)
To: Joe Perches; +Cc: linux-kernel
On 12/18/2017 10:21 PM, Joe Perches wrote:
> On Mon, 2017-12-18 at 21:36 +0100, Martin Homuth wrote:
>> This patch series fixes some coding style issues reported by checkpatch.pl.
>>
>> It is based on next-20171218
>>
>> Martin Homuth (5):
>> staging: rtl8712: style fix over 80 characters warnings
>> staging: rtl8712: style fix multiple line dereferences
>> staging: rtl8712: style fix indentation
>> staging: rtl8712: style fix unneeded else
>> staging: rtl8712: style fix returned error code
>>
>> drivers/staging/rtl8712/ieee80211.c | 6 ++-
>> drivers/staging/rtl8712/os_intfs.c | 5 +-
>> drivers/staging/rtl8712/rtl8712_cmd.c | 18 ++++---
>> drivers/staging/rtl8712/rtl8712_recv.c | 8 +--
>> drivers/staging/rtl8712/rtl8712_xmit.c | 3 +-
>> drivers/staging/rtl8712/rtl871x_cmd.c | 36 +++++++-------
>> drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 72
>> ++++++++++++++-------------
>
> This line wrapping is generally an indication that your email
> client (thunderbird 52.5.0) is wrapping all patches.
>
> If you can, use git send-email instead
>
>
Thank you very much, I wasn't aware of this problem and finally set up
send-email appropriately. Should I resend the series right away or wait
for additional comments?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/5] staging: rtl8712: fix several checkpatch style issues
2017-12-18 22:17 ` Martin Homuth
@ 2017-12-18 22:28 ` Joe Perches
0 siblings, 0 replies; 4+ messages in thread
From: Joe Perches @ 2017-12-18 22:28 UTC (permalink / raw)
To: Martin Homuth; +Cc: linux-kernel
On Mon, 2017-12-18 at 23:17 +0100, Martin Homuth wrote:
> On 12/18/2017 10:21 PM, Joe Perches wrote:
> > On Mon, 2017-12-18 at 21:36 +0100, Martin Homuth wrote:
> > > This patch series fixes some coding style issues reported by checkpatch.pl.
> > >
> > > It is based on next-20171218
> > >
> > > Martin Homuth (5):
> > > staging: rtl8712: style fix over 80 characters warnings
> > > staging: rtl8712: style fix multiple line dereferences
> > > staging: rtl8712: style fix indentation
> > > staging: rtl8712: style fix unneeded else
> > > staging: rtl8712: style fix returned error code
> > >
> > > drivers/staging/rtl8712/ieee80211.c | 6 ++-
> > > drivers/staging/rtl8712/os_intfs.c | 5 +-
> > > drivers/staging/rtl8712/rtl8712_cmd.c | 18 ++++---
> > > drivers/staging/rtl8712/rtl8712_recv.c | 8 +--
> > > drivers/staging/rtl8712/rtl8712_xmit.c | 3 +-
> > > drivers/staging/rtl8712/rtl871x_cmd.c | 36 +++++++-------
> > > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 72
> > > ++++++++++++++-------------
> >
> > This line wrapping is generally an indication that your email
> > client (thunderbird 52.5.0) is wrapping all patches.
> >
> > If you can, use git send-email instead
> >
> >
>
> Thank you very much, I wasn't aware of this problem and finally set up
> send-email appropriately. Should I resend the series right away or wait
> for additional comments?
I never looked at the patches.
The subjects look innocuous enough though.
I'd just resend as V2 after first resending only to
yourself to make sure the patches apply properly.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-18 22:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <c673a9e2-494d-c2f0-a0bd-3422ec76231d@martinhomuth.de>
2017-12-18 20:36 ` [PATCH 0/5] staging: rtl8712: fix several checkpatch style issues Martin Homuth
2017-12-18 21:21 ` Joe Perches
2017-12-18 22:17 ` Martin Homuth
2017-12-18 22:28 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox